svn commit: r948644 - in /tomcat/trunk/test: org/apache/el/TestELInJsp.java webapp-3.0/WEB-INF/tags/echo-deferred.tag webapp-3.0/el-method.jsp

2010-05-26 Thread markt
Author: markt Date: Thu May 27 00:43:54 2010 New Revision: 948644 URL: http://svn.apache.org/viewvc?rev=948644&view=rev Log: Extend to test deferred expressions. Need to use request scope attributes since page scope ones won't be visible to the tag file when evaluating the deferred expressions.

DO NOT REPLY [Bug 49320] jpa annotaion entity exception when package to a jar

2010-05-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49320 dl changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|

Re: svn commit: r948582 - /tomcat/tc5.5.x/trunk/container/webapps/manager/WEB-INF/web.xml

2010-05-26 Thread Mark Thomas
On 26/05/2010 21:50, rj...@apache.org wrote: > Author: rjung > Date: Wed May 26 20:50:45 2010 > New Revision: 948582 > > URL: http://svn.apache.org/viewvc?rev=948582&view=rev > Log: > Fix typo in web-resource-name (web.xml) for manager webapp. > I assume it's CTR because edge case of docs/comment/

DO NOT REPLY [Bug 48990] Build fails on Linux when skip.installer set to true

2010-05-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48990 --- Comment #8 from Henri Yandell 2010-05-26 19:49:59 EDT --- Gotya. I'm still on 6.0.26 with 1.0.1, but the patch looks good from visual inspection. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email -

DO NOT REPLY [Bug 48990] Build fails on Linux when skip.installer set to true

2010-05-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48990 --- Comment #7 from Mark Thomas 2010-05-26 19:34:59 EDT --- That would be because the build uses commons daemon 1.0.2 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail bec

DO NOT REPLY [Bug 48990] Build fails on Linux when skip.installer set to true

2010-05-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48990 --- Comment #6 from Henri Yandell 2010-05-26 19:20:22 EDT --- With your patch (applied to 6.0.26), I get an error that it can't find the commons-daemon-1.0.1/windows/prunsrv.exe file to copy. Looking at the unpacked commons-daemon-1.0.1

svn commit: r948584 - /tomcat/tc6.0.x/trunk/webapps/manager/WEB-INF/web.xml

2010-05-26 Thread rjung
Author: rjung Date: Wed May 26 20:51:44 2010 New Revision: 948584 URL: http://svn.apache.org/viewvc?rev=948584&view=rev Log: Fix typo in web-resource-name (web.xml) for manager webapp. I assume it's CTR because edge case of docs/comment/trivial fix. Kind of backport of http://svn.apache.org/viewv

svn commit: r948582 - /tomcat/tc5.5.x/trunk/container/webapps/manager/WEB-INF/web.xml

2010-05-26 Thread rjung
Author: rjung Date: Wed May 26 20:50:45 2010 New Revision: 948582 URL: http://svn.apache.org/viewvc?rev=948582&view=rev Log: Fix typo in web-resource-name (web.xml) for manager webapp. I assume it's CTR because edge case of docs/comment/trivial fix. Kind of backport of http://svn.apache.org/viewv

svn commit: r948580 - /tomcat/tc5.5.x/trunk/container/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/HTMLManagerServlet.java

2010-05-26 Thread rjung
Author: rjung Date: Wed May 26 20:46:18 2010 New Revision: 948580 URL: http://svn.apache.org/viewvc?rev=948580&view=rev Log: Fix typo/html syntax error in comment. Modified: tomcat/tc5.5.x/trunk/container/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/HTMLManagerServlet.java Mo

Re: svn commit: r948294 - in /tomcat/tc5.5.x/trunk: ./ container/webapps/docs/ jasper/src/share/org/apache/jasper/ jasper/src/share/org/apache/jasper/compiler/ jasper/src/share/org/apache/jasper/sec

2010-05-26 Thread Konstantin Kolinko
2010/5/26 sebb : >> The "removed" variable is only checked whether it is zero or some >>  positive value. So, the actual value of the variable before the >>  increment operation is irrelevant.  It could be written as "removed = >>  1;" and assignment is atomic. > > In that case, why not do so - or

Re: svn commit: r948294 - in /tomcat/tc5.5.x/trunk: ./ container/webapps/docs/ jasper/src/share/org/apache/jasper/ jasper/src/share/org/apache/jasper/compiler/ jasper/src/share/org/apache/jasper/sec

2010-05-26 Thread sebb
On 26/05/2010, Konstantin Kolinko wrote: > 2010/5/26 sebb : > > >> -private int removed = 0; > >> +private volatile int removed = 0; > > > > Volatile ensures correct publication across threads, but does not > > solve the lost-update problem. > > > > >> removed++; > > The a

Re: svn commit: r948294 - in /tomcat/tc5.5.x/trunk: ./ container/webapps/docs/ jasper/src/share/org/apache/jasper/ jasper/src/share/org/apache/jasper/compiler/ jasper/src/share/org/apache/jasper/sec

2010-05-26 Thread Konstantin Kolinko
2010/5/26 sebb : >>  -    private int removed = 0; >>  +    private volatile int removed = 0; > > Volatile ensures correct publication across threads, but does not > solve the lost-update problem. > >>          removed++; > The above line can suffer from a lost update as the increment is not atomic

DO NOT REPLY [Bug 46403] Persistent cookies written by 6.0.18 do not work in Internet Explorer or Safari

2010-05-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=46403 --- Comment #5 from novoj 2010-05-26 10:59:30 EDT --- The problem is also with Firefox 3.6.3 and Tomcat 6.0.26. When reading Cookie via Firefox API: function getCookie(name, host) { var cookieManager = Cc["@mozilla.org/cookiemanage

Re: svn commit: r948294 - in /tomcat/tc5.5.x/trunk: ./ container/webapps/docs/ jasper/src/share/org/apache/jasper/ jasper/src/share/org/apache/jasper/compiler/ jasper/src/share/org/apache/jasper/sec

2010-05-26 Thread sebb
On 26/05/2010, kkoli...@apache.org wrote: > Author: kkolinko > Date: Wed May 26 02:31:57 2010 > New Revision: 948294 > > URL: http://svn.apache.org/viewvc?rev=948294&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47878 > Return 404's rather than a permanent 500 if a

DO NOT REPLY [Bug 49345] New: EL does not work correctly with JSF 2.0 composite components

2010-05-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49345 Summary: EL does not work correctly with JSF 2.0 composite components Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Sev

DO NOT REPLY [Bug 49343] AbstractReplicatedMap is not removed from channel.

2010-05-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49343 Keiichi Fujino changed: What|Removed |Added Component|Cluster |Cluster Version|trunk

svn commit: r948405 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-05-26 Thread kfujino
Author: kfujino Date: Wed May 26 12:07:15 2010 New Revision: 948405 URL: http://svn.apache.org/viewvc?rev=948405&view=rev Log: Proposal for BZ49343. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STA

svn commit: r948402 - /tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java

2010-05-26 Thread kfujino
Author: kfujino Date: Wed May 26 11:58:55 2010 New Revision: 948402 URL: http://svn.apache.org/viewvc?rev=948402&view=rev Log: Fix for BZ49343. When ChannelException is thrown, remove listener from channel. Modified: tomcat/trunk/java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.ja

DO NOT REPLY [Bug 49343] AbstractReplicatedMap is not removed from channel.

2010-05-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49343 --- Comment #1 from Keiichi Fujino 2010-05-26 07:50:26 EDT --- Created an attachment (id=25485) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25485) AbstractReplicatedMap's patch I made a patch. This patch contains the same f

Re: org.apache.catalina.Core MBeans Descriptor Modifications

2010-05-26 Thread Mark Thomas
On 26/05/2010 11:40, buddhika chamith wrote: > Hi Mark, > > >> *Class: StandardWrapper* >>> >>> >>> Method : >>> add/removeLifeCycleListener(org.apache.catalina.LifecycleListener) >>> Suggestion : Remove the methods since the method can be provided in a >>> generic way with only

DO NOT REPLY [Bug 49343] New: AbstractReplicatedMap is not removed from channel.

2010-05-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49343 Summary: AbstractReplicatedMap is not removed from channel. Product: Tomcat 7 Version: trunk Platform: All OS/Version: All Status: NEW Severity: normal Priori

DO NOT REPLY [Bug 49342] New: Duplicate query string values

2010-05-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49342 Summary: Duplicate query string values Product: Tomcat 6 Version: 6.0.26 Platform: PC OS/Version: Linux Status: NEW Severity: critical Priority: P2 C

Re: org.apache.catalina.Core MBeans Descriptor Modifications

2010-05-26 Thread buddhika chamith
Hi Mark, > *Class: StandardWrapper* >> >> >> Method : >> add/removeLifeCycleListener(org.apache.catalina.LifecycleListener) >> Suggestion : Remove the methods since the method can be provided in a >> generic way with only involving primitives. >> > > Again, I don't get what you m

Re: [VOTE] Release Tomcat 7.0.0 based on Tomcat 7.0.0 RC3

2010-05-26 Thread jean-frederic clere
On 05/24/2010 12:38 AM, Mark Thomas wrote: > All, > > The next Tomcat 7.0.0 release candiate is ready for testing. 7.0.0-RC3 > can be obtained from: > http://people.apache.org/~markt/dev/tomcat-7/v7.0.0-RC3/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_0_RC3/