Re: svn commit: r920093 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/reference/iis.xml

2010-03-07 Thread Tim Whittington
Thanks I'm trying to track down a VC6 install so I can test the .dsp build before I commit. Maybe a move to VC2003 as a minimum might be in order some day. cheers tim On Mon, Mar 8, 2010 at 7:43 PM, Mladen Turk wrote: > On 03/07/2010 09:31 PM, t...@apache.org wrote: > >> Author: timw >> >> +

svn commit: r920223 - /tomcat/jk/trunk/HOWTO-RELEASE.txt

2010-03-07 Thread timw
Author: timw Date: Mon Mar 8 07:54:26 2010 New Revision: 920223 URL: http://svn.apache.org/viewvc?rev=920223&view=rev Log: Removing .rc files from list of files to modify on release (these now get version info from jk_version.h) Modified: tomcat/jk/trunk/HOWTO-RELEASE.txt Modified: tomcat/

Re: svn commit: r920086 - in /tomcat/jk/trunk/native/apache-2.0: Makefile.vc mod_jk.rc

2010-03-07 Thread Tim Whittington
Great - I hadn't considered that. On Mon, Mar 8, 2010 at 10:55 AM, Mladen Turk wrote: > On 03/07/2010 09:17 PM, t...@apache.org wrote: > >> Author: timw >> >> --- tomcat/jk/trunk/native/apache-2.0/mod_jk.rc (added) >> +++ tomcat/jk/trunk/native/apache-2.0/mod_jk.rc Sun Mar 7 20:17:04 2010 >> @@

Re: svn commit: r920199 - /tomcat/jk/trunk/native/apache-2.0/Makefile.vc

2010-03-07 Thread Tim Whittington
Thanks - I was wondering whether to do this, but forgot on the commit. On Mon, Mar 8, 2010 at 7:01 PM, wrote: > Author: mturk > Date: Mon Mar 8 06:01:27 2010 > New Revision: 920199 > > URL: http://svn.apache.org/viewvc?rev=920199&view=rev > Log: > Embed manifest inside dll > > Modified: >to

DO NOT REPLY [Bug 48870] avoid parallel arrays of base types

2010-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48870 --- Comment #1 from Ralf Hauser 2010-03-08 06:58:52 UTC --- oops, the related RFE should have been Bug 48863 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: ---

DO NOT REPLY [Bug 48863] Log directory misconfiguration for class loaders

2010-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48863 --- Comment #5 from Ralf Hauser 2010-03-08 06:58:13 UTC --- see also Bug 48870 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for

DO NOT REPLY [Bug 48870] New: avoid parallel arrays of base types

2010-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48870 Summary: avoid parallel arrays of base types Product: Tomcat 7 Version: unspecified Platform: All OS/Version: All Status: NEW Severity: enhancement Priority:

svn commit: r920211 - /tomcat/jk/trunk/native/common/jk_status.c

2010-03-07 Thread mturk
Author: mturk Date: Mon Mar 8 06:53:52 2010 New Revision: 920211 URL: http://svn.apache.org/viewvc?rev=920211&view=rev Log: Fix compile time warnings Modified: tomcat/jk/trunk/native/common/jk_status.c Modified: tomcat/jk/trunk/native/common/jk_status.c URL: http://svn.apache.org/viewvc/to

Re: svn commit: r920093 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/reference/iis.xml

2010-03-07 Thread Mladen Turk
On 03/07/2010 09:31 PM, t...@apache.org wrote: Author: timw +/* Remember the current log file name for the next potential rotate */ +strcpy_s(log_file_effective, sizeof(log_file_effective), log_file_name); -1 You will have to use StringCb routines here, because strcpy

svn commit: r920210 - /tomcat/jk/trunk/native/common/jk.rc

2010-03-07 Thread mturk
Author: mturk Date: Mon Mar 8 06:40:05 2010 New Revision: 920210 URL: http://svn.apache.org/viewvc?rev=920210&view=rev Log: Stringify the name Modified: tomcat/jk/trunk/native/common/jk.rc Modified: tomcat/jk/trunk/native/common/jk.rc URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/nativ

svn commit: r920209 - /tomcat/jk/trunk/native/apache-2.0/Makefile.vc

2010-03-07 Thread mturk
Author: mturk Date: Mon Mar 8 06:36:52 2010 New Revision: 920209 URL: http://svn.apache.org/viewvc?rev=920209&view=rev Log: Fix copy/paste typo Modified: tomcat/jk/trunk/native/apache-2.0/Makefile.vc Modified: tomcat/jk/trunk/native/apache-2.0/Makefile.vc URL: http://svn.apache.org/viewvc/

svn commit: r920208 - /tomcat/jk/trunk/native/apache-2.0/Makefile.vc

2010-03-07 Thread mturk
Author: mturk Date: Mon Mar 8 06:36:06 2010 New Revision: 920208 URL: http://svn.apache.org/viewvc?rev=920208&view=rev Log: Fix copy/paste typo Modified: tomcat/jk/trunk/native/apache-2.0/Makefile.vc Modified: tomcat/jk/trunk/native/apache-2.0/Makefile.vc URL: http://svn.apache.org/viewvc/

svn commit: r920207 - in /tomcat/jk/trunk/native: apache-2.0/Makefile.vc apache-2.0/mod_jk.rc common/jk.rc common/jk_version.h iis/Makefile.amd64 iis/Makefile.ia64 iis/Makefile.x86 iis/isapi_redirect.

2010-03-07 Thread mturk
Author: mturk Date: Mon Mar 8 06:34:14 2010 New Revision: 920207 URL: http://svn.apache.org/viewvc?rev=920207&view=rev Log: Use common windows .rc file and one place for version (jk_version.h) Added: tomcat/jk/trunk/native/common/jk.rc Removed: tomcat/jk/trunk/native/apache-2.0/mod_jk.rc

svn commit: r920199 - /tomcat/jk/trunk/native/apache-2.0/Makefile.vc

2010-03-07 Thread mturk
Author: mturk Date: Mon Mar 8 06:01:27 2010 New Revision: 920199 URL: http://svn.apache.org/viewvc?rev=920199&view=rev Log: Embed manifest inside dll Modified: tomcat/jk/trunk/native/apache-2.0/Makefile.vc Modified: tomcat/jk/trunk/native/apache-2.0/Makefile.vc URL: http://svn.apache.org/v

Bug report for Tomcat Native [2010/03/07]

2010-03-07 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Connectors [2010/03/07]

2010-03-07 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 5 [2010/03/07]

2010-03-07 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Taglibs [2010/03/07]

2010-03-07 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 6 [2010/03/07]

2010-03-07 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 7 [2010/03/07]

2010-03-07 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

svn commit: r920134 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 22:29:08 2010 New Revision: 920134 URL: http://svn.apache.org/viewvc?rev=920134&view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=920134&

Re: Tomcat build error

2010-03-07 Thread Bharath Vasudevan
Thanks folks. Looks like the gcj that was installed was causing the issue. Had uninstalled it and ant started picking up my jdk path. On Sun, Mar 7, 2010 at 1:34 PM, Mark Thomas wrote: > On 07/03/2010 21:14, Bharath Vasudevan wrote: > > My classpath is set for the tomcat working directory. Looks

Re: svn commit: r920086 - in /tomcat/jk/trunk/native/apache-2.0: Makefile.vc mod_jk.rc

2010-03-07 Thread Mladen Turk
On 03/07/2010 09:17 PM, t...@apache.org wrote: Author: timw --- tomcat/jk/trunk/native/apache-2.0/mod_jk.rc (added) +++ tomcat/jk/trunk/native/apache-2.0/mod_jk.rc Sun Mar 7 20:17:04 2010 @@ -0,0 +1,97 @@ +// Microsoft Visual C++ generated resource script. +// Nice but this should be hand craf

Re: svn commit: r920055 - /tomcat/trunk/java/org/apache/jasper/compiler/Validator.java

2010-03-07 Thread Mark Thomas
On 07/03/2010 21:26, Konstantin Kolinko wrote: > 2010/3/7 Konstantin Kolinko : >> 2010/3/7 Mark Thomas : >>> On 07/03/2010 18:45, ma...@apache.org wrote: Author: markt Date: Sun Mar 7 18:45:50 2010 New Revision: 920055 URL: http://svn.apache.org/viewvc?rev=920055&view=rev

Re: Enable RAW headers by default in IIS Tomcat connector

2010-03-07 Thread Tim Whittington
I've committed this change now. I replaced USE_RAW_HEADERS with USE_CGI_HEADERS, and inverted all the conditionals. cheers tim On Mon, Feb 8, 2010 at 9:13 PM, Tim Whittington wrote: > OK, the most conservative change will be to enable USE_RAW_HEADERS in the > makefiles/projects and leave the co

Re: Tomcat build error

2010-03-07 Thread Mark Thomas
On 07/03/2010 21:14, Bharath Vasudevan wrote: > My classpath is set for the tomcat working directory. Looks like > apache.ant.org is down now (so couldnt see what it should be set to). That is ant.apache.org As you'll see from http://monitoring.apache.org/status/ it is the EU mirror that is down.

DO NOT REPLY [Bug 38895] Http headers with an underscore "_" change into hyphen "-"

2010-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=38895 Konstantin Kolinko changed: What|Removed |Added Summary|Http headers with an|Http headers with an

svn commit: r920123 - /tomcat/trunk/webapps/docs/changelog.xml

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 21:30:54 2010 New Revision: 920123 URL: http://svn.apache.org/viewvc?rev=920123&view=rev Log: Update change log Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/w

svn commit: r920122 - in /tomcat/trunk/java/org/apache/catalina: ./ core/ ha/context/ startup/

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 21:30:32 2010 New Revision: 920122 URL: http://svn.apache.org/viewvc?rev=920122&view=rev Log: Lifecycle refactoring - ContainerBase Adds a new CONFIGURE event to allow Context to fire the START event at the right time Context fires START a little later ReplicatedCon

DO NOT REPLY [Bug 38895] Http headers with an underscore "_" change into hypen "-"

2010-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=38895 Tim Whittington changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r920121 - /tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml

2010-03-07 Thread timw
Author: timw Date: Sun Mar 7 21:26:58 2010 New Revision: 920121 URL: http://svn.apache.org/viewvc?rev=920121&view=rev Log: Updating changelog with recent commits. Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml Modified: tomcat/jk/trunk/xdocs/miscellaneous/changelog.xml URL: ht

Re: svn commit: r920055 - /tomcat/trunk/java/org/apache/jasper/compiler/Validator.java

2010-03-07 Thread Konstantin Kolinko
2010/3/7 Konstantin Kolinko : > 2010/3/7 Mark Thomas : >> On 07/03/2010 18:45, ma...@apache.org wrote: >>> Author: markt >>> Date: Sun Mar  7 18:45:50 2010 >>> New Revision: 920055 >>> >>> URL: http://svn.apache.org/viewvc?rev=920055&view=rev >>> Log: >>> Both TLD and web.xml determine if deferred

svn commit: r920120 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcatSSL.java

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 21:25:37 2010 New Revision: 920120 URL: http://svn.apache.org/viewvc?rev=920120&view=rev Log: Fix intermittent test failures Modified: tomcat/trunk/test/org/apache/catalina/startup/TestTomcatSSL.java Modified: tomcat/trunk/test/org/apache/catalina/startup/TestT

svn commit: r920119 - /tomcat/jk/trunk/native/iis/jk_isapi_plugin.c

2010-03-07 Thread timw
Author: timw Date: Sun Mar 7 21:23:01 2010 New Revision: 920119 URL: http://svn.apache.org/viewvc?rev=920119&view=rev Log: Fix #38895 - use ALL_RAW to obtain HTTP headers by default, instead of ALL_HTTP, which obtains CGI style headers (and does lowercase and '_' -> '-' conversions on header na

Re: Tomcat build error

2010-03-07 Thread Bharath Vasudevan
My classpath is set for the tomcat working directory. Looks like apache.ant.org is down now (so couldnt see what it should be set to). echo $CLASSPATH /usr/share/tomcat6/lib/servlet-api.jar I am working on a ubuntu server edition. I had ant-gcj installed previously. Removed it now and tried it. S

svn commit: r920112 - /tomcat/jk/trunk/native/TODO.txt

2010-03-07 Thread timw
Author: timw Date: Sun Mar 7 20:57:35 2010 New Revision: 920112 URL: http://svn.apache.org/viewvc?rev=920112&view=rev Log: Updating todos Modified: tomcat/jk/trunk/native/TODO.txt Modified: tomcat/jk/trunk/native/TODO.txt URL: http://svn.apache.org/viewvc/tomcat/jk/trunk/native/TODO.txt?re

svn commit: r920111 - /tomcat/jk/trunk/native/STATUS.txt

2010-03-07 Thread timw
Author: timw Date: Sun Mar 7 20:56:04 2010 New Revision: 920111 URL: http://svn.apache.org/viewvc?rev=920111&view=rev Log: Updating status with 1.2.29/30/31 details. Modified: tomcat/jk/trunk/native/STATUS.txt Modified: tomcat/jk/trunk/native/STATUS.txt URL: http://svn.apache.org/viewvc/to

svn commit: r920110 - /tomcat/trunk/java/org/apache/jasper/compiler/Validator.java

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 20:54:01 2010 New Revision: 920110 URL: http://svn.apache.org/viewvc?rev=920110&view=rev Log: isELIgnored depends on library version and web.xml declaration Modified: tomcat/trunk/java/org/apache/jasper/compiler/Validator.java Modified: tomcat/trunk/java/org/ap

svn commit: r920109 - in /tomcat/trunk/test: org/apache/jasper/compiler/ webapp-2.3/ webapp-2.3/WEB-INF/ webapp-2.4/ webapp-2.4/WEB-INF/ webapp-2.5/ webapp-2.5/WEB-INF/ webapp-3.0/

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 20:51:34 2010 New Revision: 920109 URL: http://svn.apache.org/viewvc?rev=920109&view=rev Log: Rename no-el to el-as-literal Add tests for 2.3, 2.4 & 2.5 webapps with Tag libraries that require various JSP versions These currently all work and I think some should fai

DO NOT REPLY [Bug 48501] Log rotation for ISAPI Redirector

2010-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48501 --- Comment #5 from Tim Whittington 2010-03-07 20:46:04 UTC --- Implementation of this is now committed to trunk. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail becaus

Re: svn commit: r920055 - /tomcat/trunk/java/org/apache/jasper/compiler/Validator.java

2010-03-07 Thread Konstantin Kolinko
2010/3/7 Mark Thomas : > On 07/03/2010 18:45, ma...@apache.org wrote: >> Author: markt >> Date: Sun Mar  7 18:45:50 2010 >> New Revision: 920055 >> >> URL: http://svn.apache.org/viewvc?rev=920055&view=rev >> Log: >> Both TLD and web.xml determine if deferred EL syntax is treated as EL or as >> a l

svn commit: r920096 - in /tomcat/trunk/test: org/apache/jasper/compiler/TestValidator.java webapp-3.0/WEB-INF/tags11.tld webapp-3.0/WEB-INF/tags12.tld webapp-3.0/WEB-INF/tags20.tld webapp-3.0/WEB-INF/

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 20:32:26 2010 New Revision: 920096 URL: http://svn.apache.org/viewvc?rev=920096&view=rev Log: Test that tags from libraries that declare various JSP versions have EL and deferred EL enabled/disabled as appropriate. This currently triggers a failure - fix to follow s

svn commit: r920093 - in /tomcat/jk/trunk: native/iis/jk_isapi_plugin.c xdocs/reference/iis.xml

2010-03-07 Thread timw
Author: timw Date: Sun Mar 7 20:31:45 2010 New Revision: 920093 URL: http://svn.apache.org/viewvc?rev=920093&view=rev Log: Adding basic log rotation functionality to the ISAPI redirector - #48501 Config and functionality is modeled after the Apache HTTPD rotatelogs program for consistency. Modi

svn commit: r920092 - in /tomcat/trunk/test: org/apache/jasper/compiler/TestJspConfig.java webapp-2.3/no-el.jsp

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 20:29:39 2010 New Revision: 920092 URL: http://svn.apache.org/viewvc?rev=920092&view=rev Log: Extend the no-el test to cover deferred expressions Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestJspConfig.java tomcat/trunk/test/webapp-2.3/no-el.jsp

DO NOT REPLY [Bug 43303] Versioning under Windows not reported by many connector components

2010-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=43303 --- Comment #3 from Tim Whittington 2010-03-07 20:22:29 UTC --- Version resource for mod_jk.so on Windows has been committed. This will be picked up in the Makefile build, but not the .dsp build (since I'm unable to test those). -- Confi

DO NOT REPLY [Bug 48869] Intermitten SSL handshake failure | Appears that client (Tomcat) is unable to send the certificate chain back

2010-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48869 --- Comment #2 from hbajaj 2010-03-07 20:21:25 UTC --- Hi, I have just added the patch as a reference, I am not sure whether that patch addresses this issue or is it a new issue. Thanks, -- Configure bugmail: https://issues.apache.org

svn commit: r920087 - /tomcat/jk/trunk/HOWTO-RELEASE.txt

2010-03-07 Thread timw
Author: timw Date: Sun Mar 7 20:20:03 2010 New Revision: 920087 URL: http://svn.apache.org/viewvc?rev=920087&view=rev Log: Adding mod_jk.rc to list of files needing version number updates on release. Modified: tomcat/jk/trunk/HOWTO-RELEASE.txt Modified: tomcat/jk/trunk/HOWTO-RELEASE.txt URL

svn commit: r920086 - in /tomcat/jk/trunk/native/apache-2.0: Makefile.vc mod_jk.rc

2010-03-07 Thread timw
Author: timw Date: Sun Mar 7 20:17:04 2010 New Revision: 920086 URL: http://svn.apache.org/viewvc?rev=920086&view=rev Log: Adding version resource for mod_jk.so on Windows. Partial fix for #43303 Added: tomcat/jk/trunk/native/apache-2.0/mod_jk.rc Modified: tomcat/jk/trunk/native/apache-2

DO NOT REPLY [Bug 48869] Intermitten SSL handshake failure | Appears that client (Tomcat) is unable to send the certificate chain back

2010-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48869 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: Tomcat build error

2010-03-07 Thread Konstantin Kolinko
2010/3/7 Bharath Vasudevan : > > I have been using sun jdk only. Even my JAVA_HOME path looks fine. > > echo $JAVA_HOME > /usr/lib/jvm/java-6-openjdk/ > Do not be so sure. I think you self can see that gnu/classpath/Configuration in your logs. What is the value of $CLASSPATH ? http://ant.apache.o

DO NOT REPLY [Bug 48869] New: Intermitten SSL handshake failure | Appears that client (Tomcat) is unable to send the certificate chain back

2010-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48869 Summary: Intermitten SSL handshake failure | Appears that client (Tomcat) is unable to send the certificate chain back Product: Tomcat 5 Version: 5.5.9 Platfo

Re: svn commit: r920055 - /tomcat/trunk/java/org/apache/jasper/compiler/Validator.java

2010-03-07 Thread Mark Thomas
On 07/03/2010 18:45, ma...@apache.org wrote: > Author: markt > Date: Sun Mar 7 18:45:50 2010 > New Revision: 920055 > > URL: http://svn.apache.org/viewvc?rev=920055&view=rev > Log: > Both TLD and web.xml determine if deferred EL syntax is treated as EL or as a > literal With this, the updated t

svn commit: r920055 - /tomcat/trunk/java/org/apache/jasper/compiler/Validator.java

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 18:45:50 2010 New Revision: 920055 URL: http://svn.apache.org/viewvc?rev=920055&view=rev Log: Both TLD and web.xml determine if deferred EL syntax is treated as EL or as a literal Modified: tomcat/trunk/java/org/apache/jasper/compiler/Validator.java Modified:

Re: Tomcat build error

2010-03-07 Thread Bharath Vasudevan
Hi Mark, I have been using sun jdk only. Even my JAVA_HOME path looks fine. echo $JAVA_HOME /usr/lib/jvm/java-6-openjdk/ Bharath On Sun, Mar 7, 2010 at 1:15 AM, Mark Thomas wrote: > On 06/03/2010 22:05, Bharath Vasudevan wrote: > > BUILD FAILED > > java.lang.NoClassDefFoundError: gnu/classpat

Re: svn commit: r919914 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/resources/ test/org/apache/jasper/compiler/ test/webapp/

2010-03-07 Thread Mark Thomas
On 07/03/2010 16:18, Mark Thomas wrote: > On 07/03/2010 14:24, Konstantin Kolinko wrote: >> Can it be related that my change to Compiler.java sets those PageInfo >> attributes as boolean, but PageInfo stores them both as boolean and as >> a String. >> >> This patch will fix that: >> http://people.a

svn commit: r920025 - /tomcat/trunk/java/org/apache/jasper/compiler/JspConfig.java

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 16:22:32 2010 New Revision: 920025 URL: http://svn.apache.org/viewvc?rev=920025&view=rev Log: Line length Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspConfig.java Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspConfig.java URL: http://sv

Re: svn commit: r919914 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/resources/ test/org/apache/jasper/compiler/ test/webapp/

2010-03-07 Thread Mark Thomas
On 07/03/2010 14:24, Konstantin Kolinko wrote: > Can it be related that my change to Compiler.java sets those PageInfo > attributes as boolean, but PageInfo stores them both as boolean and as > a String. > > This patch will fix that: > http://people.apache.org/~kkolinko/patches/2010-03-07_tc7_4866

Re: svn commit: r919914 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/resources/ test/org/apache/jasper/compiler/ test/webapp/

2010-03-07 Thread Konstantin Kolinko
2010/3/7 Mark Thomas : > On 07/03/2010 11:05, Mark Thomas wrote: >> On 07/03/2010 10:19, Mark Thomas wrote: >>> On 07/03/2010 02:43, kkoli...@apache.org wrote: Author: kkolinko Date: Sun Mar  7 02:43:12 2010 New Revision: 919914 URL: http://svn.apache.org/viewvc?rev=919914&

DO NOT REPLY [Bug 48848] fn:endsWith fails with repeated search string

2010-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48848 Jose Miguel Samper changed: What|Removed |Added Summary|fn:endsWith fails with |fn:endsWith fails with

DO NOT REPLY [Bug 48848] fn:endsWith fails with dollar sign

2010-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48848 --- Comment #3 from Jose Miguel Samper 2010-03-07 13:59:47 UTC --- Created an attachment (id=25102) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25102) Simpler JSP which reproduces the bug The bug has nothing to do with doll

DO NOT REPLY [Bug 48848] fn:endsWith fails with dollar sign

2010-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48848 --- Comment #2 from Konstantin Kolinko 2010-03-07 13:44:26 UTC --- Wow! Indeed, broken. Can reproduce it with 6.0.24. In org\apache\taglibs\standard\functions\Functions.java: public static boolean endsWith(String input, String substri

DO NOT REPLY [Bug 48848] fn:endsWith fails with dollar sign

2010-03-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48848 --- Comment #1 from Jose Miguel Samper 2010-03-07 13:34:16 UTC --- Created an attachment (id=25101) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25101) JSP which reproduces bug Drop JSP into web application to see the bug.

svn commit: r919986 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-03-07 Thread kkolinko
Author: kkolinko Date: Sun Mar 7 13:22:02 2010 New Revision: 919986 URL: http://svn.apache.org/viewvc?rev=919986&view=rev Log: vote Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=9199

Re: svn commit: r919914 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/resources/ test/org/apache/jasper/compiler/ test/webapp/

2010-03-07 Thread Mark Thomas
On 07/03/2010 11:05, Mark Thomas wrote: > On 07/03/2010 10:19, Mark Thomas wrote: >> On 07/03/2010 02:43, kkoli...@apache.org wrote: >>> Author: kkolinko >>> Date: Sun Mar 7 02:43:12 2010 >>> New Revision: 919914 >>> >>> URL: http://svn.apache.org/viewvc?rev=919914&view=rev >>> Log: >>> Fix https:

svn commit: r919979 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-03-07 Thread kkolinko
Author: kkolinko Date: Sun Mar 7 12:37:09 2010 New Revision: 919979 URL: http://svn.apache.org/viewvc?rev=919979&view=rev Log: vote and proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS

svn commit: r919974 - /tomcat/trunk/java/org/apache/catalina/deploy/WebXml.java

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 11:41:27 2010 New Revision: 919974 URL: http://svn.apache.org/viewvc?rev=919974&view=rev Log: Make getVersion(), getMagorVersion() and getMinorVersion() return consistent values Modified: tomcat/trunk/java/org/apache/catalina/deploy/WebXml.java Modified: tomca

svn commit: r919973 - /tomcat/trunk/test/org/apache/catalina/deploy/TestWebXml.java

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 11:39:39 2010 New Revision: 919973 URL: http://svn.apache.org/viewvc?rev=919973&view=rev Log: Ensure result of getVersion() is consistent with getMajorVersion() and getMinorVersion() With the current code this fails. Patch to fix this to follow. Modified: tomca

svn commit: r919969 - in /tomcat/trunk: build.xml test/org/apache/TestAll.java

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 11:31:00 2010 New Revision: 919969 URL: http://svn.apache.org/viewvc?rev=919969&view=rev Log: Remove the TestAll suite. Ant doesn't use it, IDEs don't need it and it is often out of sync with the tests Removed: tomcat/trunk/test/org/apache/TestAll.java Modified

svn commit: r919968 - /tomcat/trunk/test/org/apache/catalina/deploy/TestWebXml.java

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 11:27:20 2010 New Revision: 919968 URL: http://svn.apache.org/viewvc?rev=919968&view=rev Log: Check all versions are correctly parsed Modified: tomcat/trunk/test/org/apache/catalina/deploy/TestWebXml.java Modified: tomcat/trunk/test/org/apache/catalina/deploy/T

svn commit: r919966 - in /tomcat/trunk/test: org/apache/jasper/compiler/TestJspConfig.java webapp-2.3/ webapp-2.3/WEB-INF/ webapp-2.3/WEB-INF/web.xml webapp-2.3/no-el.jsp

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 11:09:09 2010 New Revision: 919966 URL: http://svn.apache.org/viewvc?rev=919966&view=rev Log: Add a test the EL doesn't work if the web-app is a 2.3 web-app Added: tomcat/trunk/test/org/apache/jasper/compiler/TestJspConfig.java (with props) tomcat/trunk/t

Re: svn commit: r919914 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/resources/ test/org/apache/jasper/compiler/ test/webapp/

2010-03-07 Thread Mark Thomas
On 07/03/2010 10:19, Mark Thomas wrote: > On 07/03/2010 02:43, kkoli...@apache.org wrote: >> Author: kkolinko >> Date: Sun Mar 7 02:43:12 2010 >> New Revision: 919914 >> >> URL: http://svn.apache.org/viewvc?rev=919914&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48668

Re: svn commit: r919914 - in /tomcat/trunk: java/org/apache/jasper/compiler/ java/org/apache/jasper/resources/ test/org/apache/jasper/compiler/ test/webapp/

2010-03-07 Thread Mark Thomas
On 07/03/2010 02:43, kkoli...@apache.org wrote: > Author: kkolinko > Date: Sun Mar 7 02:43:12 2010 > New Revision: 919914 > > URL: http://svn.apache.org/viewvc?rev=919914&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48668 > Fix remaining issues in BZ48668 > The idea be

svn commit: r919961 - in /tomcat/trunk/test: org/apache/el/ org/apache/jasper/compiler/ webapp-3.0/ webapp/

2010-03-07 Thread markt
Author: markt Date: Sun Mar 7 10:16:38 2010 New Revision: 919961 URL: http://svn.apache.org/viewvc?rev=919961&view=rev Log: Rename webapp to allow tetsing with webapps with different servlet spec versions in web.xml Added: tomcat/trunk/test/webapp-3.0/ - copied from r919952, tomcat/tr

Re: Tomcat build error

2010-03-07 Thread Mark Thomas
On 06/03/2010 22:05, Bharath Vasudevan wrote: > BUILD FAILED > java.lang.NoClassDefFoundError: gnu/classpath/Configuration Don't use gnu - download a Sun JDK. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org Fo