On 07/03/2010 11:05, Mark Thomas wrote: > On 07/03/2010 10:19, Mark Thomas wrote: >> On 07/03/2010 02:43, kkoli...@apache.org wrote: >>> Author: kkolinko >>> Date: Sun Mar 7 02:43:12 2010 >>> New Revision: 919914 >>> >>> URL: http://svn.apache.org/viewvc?rev=919914&view=rev >>> Log: >>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48668 >>> Fix remaining issues in BZ48668 >>> The idea behind this change is to make ELParser aware about >>> isDeferredAsLiteral option. >>> Before this change ELParser was used to parse an attribute regardless of >>> isELIgnored or isDeferredSyntaxAllowedAsLiteral values. With this change we >>> do not use ELParser when isELIgnored is true and ELParser does not parse >>> '#{' in expressions when isDeferredSyntaxAllowedAsLiteral is true. >>> It simplified the code in many places. >>> Also, servlet specification version from web.xml and JSP specification >>> version from TLD file are now taken into account when determining the >>> default values for isELIgnored and isDeferredSyntaxAllowedAsLiteral. As far >>> as I understand the code, previously only isELIgnored was determined by the >>> servlet specification version. >> >> I am now seeing a number of JSP 2.2 TCK failures. I suspect this change >> and/or r919851 since the failures are in this area but I need to do some >> more investigation. > > It looks like these changes have exposed some bugs in my web.xml > parse/merge changes for Tomcat 7. I'll get those fixed and see what > impact that has.
That has fixed one set of failures but some failures remain and they look to be related to the isDeferredSyntaxAllowedAsLiteral detection. Still investgating the root cause... Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
