DO NOT REPLY [Bug 48616] Struts 1.2 and bean:define tag throws jsp 1.1 regression exception

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48616 --- Comment #14 from agharta 2010-01-31 23:09:08 UTC --- (In reply to comment #13) > Thanks for the test case. It speed up the process of fixing this considerably. > > The regression has been fixed in trunk and proposed for 6.0.x. Fantast

Re: svn commit: r905147 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-01-31 Thread Konstantin Kolinko
2010/2/1 : > Author: markt > Date: Mon Feb  1 00:08:07 2010 > New Revision: 905147 > > URL: http://svn.apache.org/viewvc?rev=905147&view=rev > Log: > Update proposal with fix. > Remove Konstantin's vote as this is a very different patch > > Modified: >    tomcat/tc5.5.x/trunk/STATUS.txt > >   Con

DO NOT REPLY [Bug 48648] New: Blank page (dropped connection) when running TC7 with TCnative (APR)

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48648 Summary: Blank page (dropped connection) when running TC7 with TCnative (APR) Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Windows XP Status: NEW

DO NOT REPLY [Bug 48647] RemoteIpFilter : request.secure and request.scheme are not forced to "false" and "http" if X-Forwarded-Proto=http

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48647 Cyrille Le Clerc changed: What|Removed |Added Attachment #24913|Fixed Tomcat 7 patch with |Tomcat 7 patch with updated

DO NOT REPLY [Bug 48613] AprLifecycleListener tries to initialize even if it is not configured in server.xml

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48613 --- Comment #7 from Mark Thomas 2010-01-31 16:30:25 GMT --- This has been fixed in trunk and proposed for 6.0.x by Filip -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail

DO NOT REPLY [Bug 48614] Tomcat does not display logs

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48614 --- Comment #8 from Mark Thomas 2010-01-31 16:29:48 GMT --- This has been fixed in trunk and proposed for 6.0.x by Filip -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail

DO NOT REPLY [Bug 48647] New: RemoteIpFilter : request.secure and request.scheme are not forced to "false" and "http" if X-Forwarded-Proto=http

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48647 Summary: RemoteIpFilter : request.secure and request.scheme are not forced to "false" and "http" if X-Forwarded-Proto=http Product: Tomcat 7 Version: trunk Pl

DO NOT REPLY [Bug 48615] tomcat6.exe, tomcat6w.exe and service.bat are not included in the installation

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48615 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r905155 - /tomcat/tc6.0.x/trunk/res/welcome.bin.html

2010-01-31 Thread markt
Author: markt Date: Mon Feb 1 00:24:26 2010 New Revision: 905155 URL: http://svn.apache.org/viewvc?rev=905155&view=rev Log: Typo Modified: tomcat/tc6.0.x/trunk/res/welcome.bin.html Modified: tomcat/tc6.0.x/trunk/res/welcome.bin.html URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/re

svn commit: r905154 - /tomcat/trunk/res/welcome.bin.html

2010-01-31 Thread markt
Author: markt Date: Mon Feb 1 00:24:00 2010 New Revision: 905154 URL: http://svn.apache.org/viewvc?rev=905154&view=rev Log: Typo Modified: tomcat/trunk/res/welcome.bin.html Modified: tomcat/trunk/res/welcome.bin.html URL: http://svn.apache.org/viewvc/tomcat/trunk/res/welcome.bin.html?rev=9

svn commit: r905152 - in /tomcat/tc6.0.x/trunk: ./ res/welcome.bin.html res/welcome.main.html

2010-01-31 Thread markt
Author: markt Date: Mon Feb 1 00:20:19 2010 New Revision: 905152 URL: http://svn.apache.org/viewvc?rev=905152&view=rev Log: https://issues.apache.org/bugzilla/show_bug.cgi?id=48615 Update info on zip distributions Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/res

svn commit: r905151 - in /tomcat/trunk/res: welcome.bin.html welcome.main.html

2010-01-31 Thread markt
Author: markt Date: Mon Feb 1 00:17:55 2010 New Revision: 905151 URL: http://svn.apache.org/viewvc?rev=905151&view=rev Log: Update info on zip distributions Modified: tomcat/trunk/res/welcome.bin.html tomcat/trunk/res/welcome.main.html Modified: tomcat/trunk/res/welcome.bin.html URL: h

DO NOT REPLY [Bug 42390] JSP compilation error with nested tagfile tags with variables with "AT_BEGIN" scope

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42390 --- Comment #9 from Mark Thomas 2010-01-31 16:09:41 GMT --- The proposed patch for 5.5.x has been updated with a fix for the regession. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are recei

DO NOT REPLY [Bug 48616] Struts 1.2 and bean:define tag throws jsp 1.1 regression exception

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48616 --- Comment #13 from Mark Thomas 2010-01-31 16:09:06 GMT --- Thanks for the test case. It speed up the process of fixing this considerably. The regression has been fixed in trunk and proposed for 6.0.x. -- Configure bugmail: https://issu

svn commit: r905147 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-01-31 Thread markt
Author: markt Date: Mon Feb 1 00:08:07 2010 New Revision: 905147 URL: http://svn.apache.org/viewvc?rev=905147&view=rev Log: Update proposal with fix. Remove Konstantin's vote as this is a very different patch Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.tx

svn commit: r905146 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-31 Thread markt
Author: markt Date: Mon Feb 1 00:06:36 2010 New Revision: 905146 URL: http://svn.apache.org/viewvc?rev=905146&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=905

svn commit: r905145 - in /tomcat/trunk/java/org/apache/jasper/compiler: Generator.java ScriptingVariabler.java

2010-01-31 Thread markt
Author: markt Date: Mon Feb 1 00:04:40 2010 New Revision: 905145 URL: http://svn.apache.org/viewvc?rev=905145&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48616, a regression caused by the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=42390 The requirement fo

svn commit: r905143 - /tomcat/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.java

2010-01-31 Thread markt
Author: markt Date: Mon Feb 1 00:01:45 2010 New Revision: 905143 URL: http://svn.apache.org/viewvc?rev=905143&view=rev Log: Restore the current 6.0.x implementation so patch to fix 48616 will apply cleanly to 6.0.x Modified: tomcat/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.ja

svn commit: r905142 - in /tomcat/trunk/test: org/apache/jasper/compiler/TestScriptingVariabler.java webapp/WEB-INF/bugs.tld webapp/bug48616.jsp

2010-01-31 Thread markt
Author: markt Date: Sun Jan 31 23:57:56 2010 New Revision: 905142 URL: http://svn.apache.org/viewvc?rev=905142&view=rev Log: Add minimal version of test case provided by 'agharta' in for https://issues.apache.org/bugzilla/show_bug.cgi?id=48616 Added: tomcat/trunk/test/webapp/WEB-INF/bugs.tld

Bug report for Tomcat Native [2010/01/31]

2010-01-31 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 5 [2010/01/31]

2010-01-31 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat Connectors [2010/01/31]

2010-01-31 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 6 [2010/01/31]

2010-01-31 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Tomcat 7 [2010/01/31]

2010-01-31 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

Bug report for Taglibs [2010/01/31]

2010-01-31 Thread bugzilla
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned

svn commit: r905133 - in /tomcat/trunk/test: org/apache/jasper/compiler/TestScriptingVariabler.java webapp/WEB-INF/tags/bug42390.tag webapp/bug42390.jsp

2010-01-31 Thread markt
Author: markt Date: Sun Jan 31 22:49:34 2010 New Revision: 905133 URL: http://svn.apache.org/viewvc?rev=905133&view=rev Log: Add test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=42390 JSP & tag file provided by MicroNova YUZU Team Added: tomcat/trunk/test/org/apache/jasper/com

DO NOT REPLY [Bug 44382] Need to add support for HTTPOnly session cookie parameter

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=44382 --- Comment #23 from August Detlefsen 2010-01-31 12:23:31 UTC --- (In reply to comment #22) > This has been applied to 5.5.x and will be included in 5.5.28 onwards. On Tomcat 5.5.28, when using context.xml.default to setup attributes for

svn commit: r905073 - in /tomcat/trunk/java/org/apache/catalina/util: LocalStrings.properties RequestUtil.java

2010-01-31 Thread markt
Author: markt Date: Sun Jan 31 17:07:26 2010 New Revision: 905073 URL: http://svn.apache.org/viewvc?rev=905073&view=rev Log: Align implementation with comments. Unit test now passes. Modified: tomcat/trunk/java/org/apache/catalina/util/LocalStrings.properties tomcat/trunk/java/org/apache/

svn commit: r905039 - in /tomcat/trunk/test/org/apache/catalina/util: ./ TestRequestUtil.java

2010-01-31 Thread markt
Author: markt Date: Sun Jan 31 13:42:09 2010 New Revision: 905039 URL: http://svn.apache.org/viewvc?rev=905039&view=rev Log: Test case for RequestUtil. Current implementation does not agree with comment. Added: tomcat/trunk/test/org/apache/catalina/util/ tomcat/trunk/test/org/apache/catal

svn commit: r905037 - /tomcat/trunk/java/org/apache/catalina/util/RequestUtil.java

2010-01-31 Thread markt
Author: markt Date: Sun Jan 31 13:30:30 2010 New Revision: 905037 URL: http://svn.apache.org/viewvc?rev=905037&view=rev Log: Align url decoding for bytes with url decoding for Strings. No functional change (for Tomcat) since the methods that use bytes are not called directly Modified: tomcat

svn commit: r905035 - in /tomcat/trunk/java/org/apache/catalina: core/ApplicationHttpRequest.java util/LocalStrings.properties util/RequestUtil.java

2010-01-31 Thread markt
Author: markt Date: Sun Jan 31 13:22:04 2010 New Revision: 905035 URL: http://svn.apache.org/viewvc?rev=905035&view=rev Log: Make it clearer how unsupported encodings are handled No functional change for supported encodings Log attempted use of unsupported encodings, removing some empty catch bloc

svn commit: r905030 - /tomcat/trunk/java/org/apache/catalina/util/RequestUtil.java

2010-01-31 Thread markt
Author: markt Date: Sun Jan 31 13:08:39 2010 New Revision: 905030 URL: http://svn.apache.org/viewvc?rev=905030&view=rev Log: Be clear in Javadoc about how unsupported encodings are handled. Add a debug message for this case. Modified: tomcat/trunk/java/org/apache/catalina/util/RequestUtil.ja

DO NOT REPLY [Bug 48645] RequestUtil.URLDecode(byte[] bytes, String enc)

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48645 --- Comment #1 from Mark Thomas 2010-01-31 04:58:44 GMT --- Thanks for the report. This has been fixed in trunk and proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiv

svn commit: r905026 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-31 Thread markt
Author: markt Date: Sun Jan 31 12:58:32 2010 New Revision: 905026 URL: http://svn.apache.org/viewvc?rev=905026&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=905

svn commit: r905020 - /tomcat/trunk/java/org/apache/catalina/util/RequestUtil.java

2010-01-31 Thread markt
Author: markt Date: Sun Jan 31 12:48:53 2010 New Revision: 905020 URL: http://svn.apache.org/viewvc?rev=905020&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48645 Use specified encoding rather than null Modified: tomcat/trunk/java/org/apache/catalina/util/RequestUtil.ja

svn propchange: r905015 - svn:log

2010-01-31 Thread markt
Author: markt Revision: 905015 Modified property: svn:log Modified: svn:log at Sun Jan 31 12:36:31 2010 -- --- svn:log (original) +++ svn:log Sun Jan 31 12:36:31 2010 @@ -1 +1,2 @@ +Revert r804734 (https://issues.apache.or

DO NOT REPLY [Bug 48645] New: RequestUtil.URLDecode(byte[] bytes, String enc)

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48645 Summary: RequestUtil.URLDecode(byte[] bytes, String enc) Product: Tomcat 6 Version: 6.0.20 Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Pr

svn commit: r905015 - /tomcat/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.java

2010-01-31 Thread markt
Author: markt Date: Sun Jan 31 12:34:22 2010 New Revision: 905015 URL: http://svn.apache.org/viewvc?rev=905015&view=rev Log: Tab police Modified: tomcat/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.java Modified: tomcat/trunk/java/org/apache/jasper/compiler/ScriptingVariabler.jav

svn commit: r905014 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-01-31 Thread markt
Author: markt Date: Sun Jan 31 12:31:00 2010 New Revision: 905014 URL: http://svn.apache.org/viewvc?rev=905014&view=rev Log: Change vote due to regression Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/tru

DO NOT REPLY [Bug 42390] JSP compilation error with nested tagfile tags with variables with "AT_BEGIN" scope

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=42390 --- Comment #8 from Mark Thomas 2010-01-31 04:27:55 GMT --- Note that the patch caused bug48616. Find a solution that fixes both bugs will be tracked in bug48616. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=

DO NOT REPLY [Bug 48616] Struts 1.2 and bean:define tag throws jsp 1.1 regression exception

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48616 --- Comment #12 from Mark Thomas 2010-01-31 04:26:44 GMT --- The regression is caused by the fix for bug42390. I'll put together a test case that covers both and then see what can be done to find a fix that allows both to work correctly. -

DO NOT REPLY [Bug 48643] catalina.session.FileStore.save() and load() - close() bugs

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48643 --- Comment #3 from Sebb 2010-01-31 03:23:42 UTC --- (In reply to comment #2) > (In reply to comment #0) > > Note: these bugs were detected by the Eclipse compiler. > > I think it is pointless to try to please Eclipse IDE here. That "possi

DO NOT REPLY [Bug 48616] Struts 1.2 and bean:define tag throws jsp 1.1 regression exception

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48616 --- Comment #11 from Mark Thomas 2010-01-31 03:09:50 GMT --- Thanks for the test case. I can now reproduce this error. Looking at it now... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are r

DO NOT REPLY [Bug 48625] Server started in illegal state

2010-01-31 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48625 --- Comment #1 from Mark Thomas 2010-01-31 03:00:27 GMT --- This was feature was implemented in Tomcat 7 some time ago. I have proposed back porting it to 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=em

svn commit: r904997 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-01-31 Thread markt
Author: markt Date: Sun Jan 31 10:59:56 2010 New Revision: 904997 URL: http://svn.apache.org/viewvc?rev=904997&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=904