Author: markt Date: Sun Jan 31 13:42:09 2010 New Revision: 905039 URL: http://svn.apache.org/viewvc?rev=905039&view=rev Log: Test case for RequestUtil. Current implementation does not agree with comment.
Added: tomcat/trunk/test/org/apache/catalina/util/ tomcat/trunk/test/org/apache/catalina/util/TestRequestUtil.java (with props) Added: tomcat/trunk/test/org/apache/catalina/util/TestRequestUtil.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/util/TestRequestUtil.java?rev=905039&view=auto ============================================================================== --- tomcat/trunk/test/org/apache/catalina/util/TestRequestUtil.java (added) +++ tomcat/trunk/test/org/apache/catalina/util/TestRequestUtil.java Sun Jan 31 13:42:09 2010 @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.catalina.util; + +import junit.framework.TestCase; + +public class TestRequestUtil extends TestCase { + + public void testURLDecodeString() { + // %n rather than %nn should throw an IAE according to the Javadoc + Exception exception = null; + try { + RequestUtil.URLDecode("%5xxxxx"); + } catch (Exception e) { + exception = e; + } + assertTrue(exception instanceof IllegalArgumentException); + + // Edge case trying to trigger ArrayIndexOutOfBoundsException + exception = null; + try { + RequestUtil.URLDecode("%5"); + } catch (Exception e) { + exception = e; + } + assertTrue(exception instanceof IllegalArgumentException); + } +} Propchange: tomcat/trunk/test/org/apache/catalina/util/TestRequestUtil.java ------------------------------------------------------------------------------ svn:eol-style = native Propchange: tomcat/trunk/test/org/apache/catalina/util/TestRequestUtil.java ------------------------------------------------------------------------------ svn:keywords = Date Author Id Revision --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org