Re: svn commit: r892293 - in /tomcat/trunk/java: javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/core/ org/apache/catalina/realm/ org/apache/catalina/valves/ org/apache/ja

2009/12/20 Mark Thomas : > > I don't view an HTTP header where the message is a long string of > characters as better. In that case I think the use English text is a > better option. Neither do I think we want too many configuration options > here. > > What do you think to the following as an

Re: svn commit: r892293 - in /tomcat/trunk/java: javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/core/ org/apache/catalina/realm/ org/apache/catalina/valves/ org/apache/ja

On 20/12/2009 04:10, Konstantin Kolinko wrote: > 2009/12/18 : >> Author: markt >> Date: Fri Dec 18 16:13:28 2009 >> New Revision: 892293 >> >> URL: http://svn.apache.org/viewvc?rev=892293&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47963 >> Anything that could end up

svn commit: r892560 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: kkolinko Date: Sun Dec 20 04:40:16 2009 New Revision: 892560 URL: http://svn.apache.org/viewvc?rev=892560&view=rev Log: votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=892

Re: svn commit: r892293 - in /tomcat/trunk/java: javax/servlet/http/ org/apache/catalina/authenticator/ org/apache/catalina/core/ org/apache/catalina/realm/ org/apache/catalina/valves/ org/apache/ja

2009/12/18 : > Author: markt > Date: Fri Dec 18 16:13:28 2009 > New Revision: 892293 > > URL: http://svn.apache.org/viewvc?rev=892293&view=rev > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47963 > Anything that could end up in an HTTP header must meet the requirements of > RFC26

DO NOT REPLY [Bug 47976] org.apache.catalina.startup.Catalina's usage() method is not complete

https://issues.apache.org/bugzilla/show_bug.cgi?id=47976 --- Comment #1 from Mark Thomas 2009-12-19 20:01:38 GMT --- This has already been fixed in trunk. I have proposed the relevant patches for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You

svn commit: r892559 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: markt Date: Sun Dec 20 04:01:17 2009 New Revision: 892559 URL: http://svn.apache.org/viewvc?rev=892559&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=892

DO NOT REPLY [Bug 48399] Lock fields should be final

https://issues.apache.org/bugzilla/show_bug.cgi?id=48399 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r892558 - in /tomcat/trunk: java/org/apache/catalina/ha/session/DeltaSession.java java/org/apache/catalina/tribes/group/interceptors/OrderInterceptor.java modules/jdbc-pool/java/org/apache

Author: markt Date: Sun Dec 20 03:46:02 2009 New Revision: 892558 URL: http://svn.apache.org/viewvc?rev=892558&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48399 Make locks final Patch by sebb Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java

DO NOT REPLY [Bug 48414] Use of Class.forName may not work well in osgi environment

https://issues.apache.org/bugzilla/show_bug.cgi?id=48414 --- Comment #2 from Mark Thomas 2009-12-19 19:40:39 GMT --- Using the InstanceManager in this way feels more like a convenience since Germonimo's custom InstanceManager happens to have visibility across multiple bundles rather than the 'rig

svn commit: r892557 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

Author: markt Date: Sun Dec 20 03:29:20 2009 New Revision: 892557 URL: http://svn.apache.org/viewvc?rev=892557&view=rev Log: Fix javadoc Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java URL: h

DO NOT REPLY [Bug 48413] correction of typos in valves/LocalStrings_fr.properties

https://issues.apache.org/bugzilla/show_bug.cgi?id=48413 --- Comment #1 from Mark Thomas 2009-12-19 18:49:08 GMT --- Many thanks for the patch. It has been applied to trunk and proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are re

svn commit: r892556 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: markt Date: Sun Dec 20 02:48:52 2009 New Revision: 892556 URL: http://svn.apache.org/viewvc?rev=892556&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=892

svn commit: r892555 - /tomcat/trunk/java/org/apache/catalina/valves/LocalStrings_fr.properties

Author: markt Date: Sun Dec 20 02:47:37 2009 New Revision: 892555 URL: http://svn.apache.org/viewvc?rev=892555&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48413 Correct translations Patch provided by André Warnier Modified: tomcat/trunk/java/org/apache/catalina/valves

svn commit: r892554 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/realm/JNDIRealm.java webapps/docs/changelog.xml webapps/docs/config/realm.xml

Author: markt Date: Sun Dec 20 02:37:18 2009 New Revision: 892554 URL: http://svn.apache.org/viewvc?rev=892554&view=rev Log: Add support for a connectionTimeout attribute to the JNDIRealm Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/

DO NOT REPLY [Bug 47841] CombinedRealm fails to switch to other realm

https://issues.apache.org/bugzilla/show_bug.cgi?id=47841 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

svn commit: r892553 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/realm/ webapps/docs/

Author: markt Date: Sun Dec 20 02:32:53 2009 New Revision: 892553 URL: http://svn.apache.org/viewvc?rev=892553&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47841 Failed sub-realm start prevents combined realm from starting Modified: tomcat/tc6.0.x/trunk/ (props chang

DO NOT REPLY [Bug 47836] TldConfig keeps an internal list of ApplicationListeners

https://issues.apache.org/bugzilla/show_bug.cgi?id=47836 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r892552 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/core/StandardContext.java java/org/apache/catalina/startup/TldConfig.java webapps/docs/changelog.xml

Author: markt Date: Sun Dec 20 02:22:08 2009 New Revision: 892552 URL: http://svn.apache.org/viewvc?rev=892552&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47836 Don't keep TLD/listener info between reloads Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/t

svn commit: r892547 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/jasper/servlet/JspServletWrapper.java webapps/docs/changelog.xml

Author: markt Date: Sun Dec 20 01:21:52 2009 New Revision: 892547 URL: http://svn.apache.org/viewvc?rev=892547&view=rev Log: Test for null rather than just waiting for the NPE to happen Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/tr

DO NOT REPLY [Bug 43656] ELSupport.coerceToType won't handle null for java.lang.Number

https://issues.apache.org/bugzilla/show_bug.cgi?id=43656 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

svn commit: r892546 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/el/lang/ELSupport.java test/org/apache/el/lang/TestELSupport.java webapps/docs/changelog.xml

Author: markt Date: Sun Dec 20 01:15:37 2009 New Revision: 892546 URL: http://svn.apache.org/viewvc?rev=892546&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=43656 Coerce null to zero when target type in Number Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat

Problem loading classes with Class.forName() in StandardContext.createWrapper()

In the tomcat-7 geronimo/osgi integration we've run into a problem when tomcat loads listener classes using Class.forName. Using the InstanceManager to just create the objects works fine for us. In geronimo at the moment the InstanceManager has access to both application and system classes

DO NOT REPLY [Bug 48414] Use of Class.forName may not work well in osgi environment

https://issues.apache.org/bugzilla/show_bug.cgi?id=48414 --- Comment #1 from david jencks 2009-12-19 17:06:29 UTC --- This is also discussed in https://issues.apache.org/jira/browse/GERONIMO-4992 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are r

DO NOT REPLY [Bug 48414] New: Use of Class.forName may not work well in osgi environment

https://issues.apache.org/bugzilla/show_bug.cgi?id=48414 Summary: Use of Class.forName may not work well in osgi environment Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Mac OS X 10.4 Status: NEW

DO NOT REPLY [Bug 45255] support disable jsessionid from url against session fixation attacks

https://issues.apache.org/bugzilla/show_bug.cgi?id=45255 Mark Thomas changed: What|Removed |Added Component|Catalina|Catalina Version|unspecif

svn commit: r892545 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/ java/org/apache/catalina/authenticator/ java/org/apache/catalina/connector/ java/org/apache/catalina/ha/session/ java/org/a

Author: markt Date: Sun Dec 20 01:04:17 2009 New Revision: 892545 URL: http://svn.apache.org/viewvc?rev=892545&view=rev Log: Address https://issues.apache.org/bugzilla/show_bug.cgi?id=45255 Prevent session fixation by changing session ID on authentication by default Modified: tomcat/tc6.0.x/t

svn commit: r892537 - /tomcat/tc5.5.x/trunk/STATUS.txt

Author: markt Date: Sun Dec 20 00:01:52 2009 New Revision: 892537 URL: http://svn.apache.org/viewvc?rev=892537&view=rev Log: Add Konstantin's patch to add getter/setter Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomc

svn commit: r892536 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: markt Date: Sat Dec 19 23:58:46 2009 New Revision: 892536 URL: http://svn.apache.org/viewvc?rev=892536&view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=892536&

DO NOT REPLY [Bug 47453] JasperException for deferred-method with return type void

https://issues.apache.org/bugzilla/show_bug.cgi?id=47453 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r892535 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/jasper/compiler/JspUtil.java webapps/docs/changelog.xml

Author: markt Date: Sat Dec 19 23:57:11 2009 New Revision: 892535 URL: http://svn.apache.org/viewvc?rev=892535&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47453 Handle void return types This is funkman's patch Modified: tomcat/tc6.0.x/trunk/ (props changed) tomc

DO NOT REPLY [Bug 48307] Missing french translations and some weird sentences

https://issues.apache.org/bugzilla/show_bug.cgi?id=48307 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 48306] ome occurences of eacute instead of ecircumflex in french translations

https://issues.apache.org/bugzilla/show_bug.cgi?id=48306 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r892531 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/catalina/manager/ java/org/apache/catalina/session/ webapps/docs/

Author: markt Date: Sat Dec 19 23:38:43 2009 New Revision: 892531 URL: http://svn.apache.org/viewvc?rev=892531&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48306 & https://issues.apache.org/bugzilla/show_bug.cgi?id=48307 Correct French translations Patches provided by Marc

svn commit: r892523 - /tomcat/trunk/webapps/docs/config/listeners.xml

Author: markt Date: Sat Dec 19 23:05:36 2009 New Revision: 892523 URL: http://svn.apache.org/viewvc?rev=892523&view=rev Log: Fix typo Modified: tomcat/trunk/webapps/docs/config/listeners.xml Modified: tomcat/trunk/webapps/docs/config/listeners.xml URL: http://svn.apache.org/viewvc/tomcat/tr

DO NOT REPLY [Bug 48113] Member hostname components are printed as signed 8bits

https://issues.apache.org/bugzilla/show_bug.cgi?id=48113 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r892521 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/tribes/membership/MemberImpl.java java/org/apache/catalina/tribes/util/Arrays.java webapps/docs/changelog.xml

Author: markt Date: Sat Dec 19 22:56:24 2009 New Revision: 892521 URL: http://svn.apache.org/viewvc?rev=892521&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48113 Display IP addresses using 0-255 rather than -128 to +127 Port Filip's patch from trunk plus additional changes

DO NOT REPLY [Bug 47462] The annotation doesn't become effective.(metadata-complete="false" is not effective.)

https://issues.apache.org/bugzilla/show_bug.cgi?id=47462 Mark Thomas changed: What|Removed |Added Component|Catalina|Catalina Version|6.0.20

svn commit: r892516 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/startup/WebRuleSet.java webapps/docs/changelog.xml

Author: markt Date: Sat Dec 19 22:35:15 2009 New Revision: 892516 URL: http://svn.apache.org/viewvc?rev=892516&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47462 Need to be able to override metadata complete if set in the global web.xml Patch provided by Keiichi Fujino Mod

Re: svn commit: r892415 - in /tomcat/trunk/java/org/apache/catalina: authenticator/AuthenticatorBase.java connector/Request.java

On 19/12/2009 01:43, kkoli...@apache.org wrote: > Author: kkolinko > Date: Sat Dec 19 01:43:29 2009 > New Revision: 892415 > > URL: http://svn.apache.org/viewvc?rev=892415&view=rev > Log: > Followup to rev.889716 > The new AuthenticatorBase property needs a setter. Thanks. Good catch. Mark --

DO NOT REPLY [Bug 48409] Cookie information is stripped after colon

https://issues.apache.org/bugzilla/show_bug.cgi?id=48409 --- Comment #3 from Mark Thomas 2009-12-19 12:57:24 GMT --- Tomcat's cookie parsing was made stricter in later versions to deal with some security issues - hence the difference in behaviour. Your company's enterprise site is badly broken.

svn commit: r892491 - in /tomcat/tc5.5.x/trunk: STATUS.txt container/modules/ha/src/share/org/apache/catalina/ha/session/DeltaManager.java container/modules/ha/src/share/org/apache/catalina/ha/session

Author: rjung Date: Sat Dec 19 18:09:37 2009 New Revision: 892491 URL: http://svn.apache.org/viewvc?rev=892491&view=rev Log: DeltaManager needs to replicate changed attributes even if session gets invalidated. Otherwise session listeners will not see the right data on the secondary nodes. Ported

svn commit: r892484 - /tomcat/tc5.5.x/trunk/STATUS.txt

Author: rjung Date: Sat Dec 19 16:34:06 2009 New Revision: 892484 URL: http://svn.apache.org/viewvc?rev=892484&view=rev Log: Vote and comment. Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.tx

svn commit: r892478 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: rjung Date: Sat Dec 19 15:11:05 2009 New Revision: 892478 URL: http://svn.apache.org/viewvc?rev=892478&view=rev Log: Vote, comment. Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?r

svn commit: r892464 - /tomcat/trunk/java/org/apache/catalina/startup/Catalina.java

Author: markt Date: Sat Dec 19 11:34:16 2009 New Revision: 892464 URL: http://svn.apache.org/viewvc?rev=892464&view=rev Log: start not -start, stop not -stop Modified: tomcat/trunk/java/org/apache/catalina/startup/Catalina.java Modified: tomcat/trunk/java/org/apache/catalina/startup/Catalina

DO NOT REPLY [Bug 48413] New: correction of typos in valves/LocalStrings_fr.properties

https://issues.apache.org/bugzilla/show_bug.cgi?id=48413 Summary: correction of typos in valves/LocalStrings_fr.properties Product: Tomcat 6 Version: unspecified Platform: Other OS/Version: All Status: NEW