Re: Please review JDBC Pool before vote

2009-06-22 Thread Filip Hanik - Dev Lists
sebb wrote: On 22/06/2009, Filip Hanik - Dev Lists wrote: in the spirit of trying to get my poop right, http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ Looks a lot better. the binary releases contain everything in individual jar files (including source references for IDEs)

Re: Please review JDBC Pool before vote

2009-06-22 Thread sebb
On 22/06/2009, Filip Hanik - Dev Lists wrote: > in the spirit of trying to get my poop right, > > http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ Looks a lot better. > the binary releases contain everything in individual jar files (including > source references for IDEs) However, there are

Re: dbcp pool evictor deadlock?

2009-06-22 Thread Filip Hanik - Dev Lists
Could be a bug in DBCP, sure looks like it. You can try a drop in replacement that we are working on. http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ Filip Eric B. wrote: Hi, I appologize in advance for the cross-post, but I'm really not sure if this is a problem with the dbcp code or my

Please review JDBC Pool before vote

2009-06-22 Thread Filip Hanik - Dev Lists
in the spirit of trying to get my poop right, http://people.apache.org/~fhanik/jdbc-pool/v1.0.5/ the binary releases contain everything in individual jar files (including source references for IDEs) the source release is "as is" from our repo, with the ability to build by using ant download

svn commit: r787394 - /tomcat/trunk/modules/jdbc-pool/build.xml

2009-06-22 Thread fhanik
Author: fhanik Date: Mon Jun 22 20:51:57 2009 New Revision: 787394 URL: http://svn.apache.org/viewvc?rev=787394&view=rev Log: Don't create the test table during the run Modified: tomcat/trunk/modules/jdbc-pool/build.xml Modified: tomcat/trunk/modules/jdbc-pool/build.xml URL: http://svn.apac

svn commit: r787390 - /tomcat/trunk/modules/jdbc-pool/build.xml

2009-06-22 Thread fhanik
Author: fhanik Date: Mon Jun 22 20:46:32 2009 New Revision: 787390 URL: http://svn.apache.org/viewvc?rev=787390&view=rev Log: Add in test runner Modified: tomcat/trunk/modules/jdbc-pool/build.xml Modified: tomcat/trunk/modules/jdbc-pool/build.xml URL: http://svn.apache.org/viewvc/tomcat/tru

dbcp pool evictor deadlock?

2009-06-22 Thread Eric B.
Hi, I appologize in advance for the cross-post, but I'm really not sure if this is a problem with the dbcp code or my configuration. I ran into the most troublesome deadlock over the weekend on my server, and cannot figure out how/or why this deadlock occured. Via jconsole, I was able to get

svn commit: r787385 - in /tomcat/trunk/modules/jdbc-pool: .classpath build.properties.default build.xml doc/changelog.xml doc/jdbc-pool.xml sign.sh

2009-06-22 Thread fhanik
Author: fhanik Date: Mon Jun 22 20:29:20 2009 New Revision: 787385 URL: http://svn.apache.org/viewvc?rev=787385&view=rev Log: Refactor to be more independent, so that one can build from source archive without too many hooplas as suggested by sebb Added: tomcat/trunk/modules/jdbc-pool/build.p

[Tomcat Wiki] Update of "HowTo" by ChristopherSchultz

2009-06-22 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The following page has been changed by ChristopherSchultz: http://wiki.apache.org/tomcat/HowTo -- Note t

DO NOT REPLY [Bug 47402] DeltaManager expiring sessions upon shutdown with expireSessionsOnShutdown="false"

2009-06-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47402 --- Comment #2 from Federico Pires 2009-06-22 10:02:33 PST --- (In reply to comment #1) > hi Federico, > this is intended behavior. The code looks like > > // Expire all active sessions > if (log.isInfoEnabled()) > lo

DO NOT REPLY [Bug 47402] DeltaManager expiring sessions upon shutdown with expireSessionsOnShutdown="false"

2009-06-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47402 Filip Hanik changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 47402] New: DeltaManager expiring sessions upon shutdown with expireSessionsOnShutdown="false"

2009-06-22 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47402 Summary: DeltaManager expiring sessions upon shutdown with expireSessionsOnShutdown="false" Product: Tomcat 6 Version: 6.0.18 Platform: PC OS/Version: Linux S

svn commit: r787304 - /tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java

2009-06-22 Thread fhanik
Author: fhanik Date: Mon Jun 22 16:19:10 2009 New Revision: 787304 URL: http://svn.apache.org/viewvc?rev=787304&view=rev Log: A more sensible default to avoid too many character array allocations Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java Modified: tomcat/tru

svn commit: r787274 - /tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java

2009-06-22 Thread fhanik
Author: fhanik Date: Mon Jun 22 15:36:35 2009 New Revision: 787274 URL: http://svn.apache.org/viewvc?rev=787274&view=rev Log: Minimize thread local access when possible, since thread local does a map lookup. Idea by kkolinko Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLogVa

Re: [VOTE] Release build 4.1.40 - Take 2

2009-06-22 Thread Konstantin Kolinko
2009/6/16 Mark Thomas : > The (updated) candidates source tarball and derived binaries are > available here: > http://tomcat.apache.org/dev/dist/apache-tomcat-4.1.40/ > Minor issues: a) When installing apache-tomcat-4.1.40.exe, the installer dialog page that allows to specify port number and name/

Re: svn commit: r786667 - /tomcat/trunk/java/org/apache/tomcat/util/http/Parameters.java

2009-06-22 Thread Filip Hanik - Dev Lists
Mark Thomas wrote: Filip Hanik - Dev Lists wrote: we're copying bytes to two new byte arrays on every call, just so that we have info when it fails? For query string there is (and always has been) one copy and then this patch copies again for the failure info. For POST requests the on

Re: svn commit: r787211 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

2009-06-22 Thread Mark Thomas
sebb wrote: > Looks a bit odd - are there really both "tomcat" and "Tomcat" objects/classes? Yes. >> ctx.addServletMapping("/", "myServlet"); >> >> tomcat.start(); > > If so, is this the correct cat? Yes. Mark

Re: svn commit: r787211 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

2009-06-22 Thread sebb
On 22/06/2009, ma...@apache.org wrote: > Author: markt > Date: Mon Jun 22 11:58:07 2009 > New Revision: 787211 > > URL: http://svn.apache.org/viewvc?rev=787211&view=rev > Log: > Fix a couple of Eclipse warnings > > Modified: > tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

svn commit: r787211 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

2009-06-22 Thread markt
Author: markt Date: Mon Jun 22 11:58:07 2009 New Revision: 787211 URL: http://svn.apache.org/viewvc?rev=787211&view=rev Log: Fix a couple of Eclipse warnings Modified: tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java Modified: tomcat/trunk/test/org/apache/catalina/startup/TestTo

svn commit: r787202 - /tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java

2009-06-22 Thread markt
Author: markt Date: Mon Jun 22 11:19:18 2009 New Revision: 787202 URL: http://svn.apache.org/viewvc?rev=787202&view=rev Log: Don't call silent by default. Add the life-cycle listener to the silenced loggers. Modified: tomcat/trunk/java/org/apache/catalina/startup/Tomcat.java Modified: tomca

svn commit: r787197 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

2009-06-22 Thread markt
Author: markt Date: Mon Jun 22 11:03:37 2009 New Revision: 787197 URL: http://svn.apache.org/viewvc?rev=787197&view=rev Log: Remove unnecessary code that just leads to a warning in the logs Modified: tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java Modified: tomcat/trunk/test/or