Re: Cleaning generated jmh classes

2024-08-01 Thread Gus Heck
It doesn't come up when trying to run benchmarks. Typically it comes up when I've switched branches or perhaps if I'me running a "reproduce with" line... for whatever reason, sometimes it decides to regenerate the already generated files, and fails the build when they already exist. This is annoyin

Re: Cleaning generated jmh classes

2024-08-01 Thread David Smiley
BTW I've recently started using Crave for benchmarks, which sidesteps this issue. In fact I never recall seeing the issue reported here, even when I was starting off local. https://github.com/apache/solr/pull/2548#pullrequestreview-2213174440 On Thu, Aug 1, 2024 at 10:12 AM Houston Putman wrote:

Re: Cleaning generated jmh classes

2024-08-01 Thread Houston Putman
I would think we could put them in the build directory, like we do with the api module. On Thu, Aug 1, 2024 at 9:07 AM Mike Drob wrote: > I think the idea is correct, but I would also check if there is something > we could do with the generator task to mark those directories as generated > sourc

Re: Cleaning generated jmh classes

2024-08-01 Thread Mike Drob
I think the idea is correct, but I would also check if there is something we could do with the generator task to mark those directories as generated sources that should be cleaned up (I could be totally wrong here) On Thu, Aug 1, 2024 at 8:49 AM Jason Gerlowski wrote: > +1 - that makes sense afa

Re: Cleaning generated jmh classes

2024-08-01 Thread Jason Gerlowski
+1 - that makes sense afaict. On Thu, Aug 1, 2024 at 8:31 AM Gus Heck wrote: > > I keep having to waste time on errors like this: > > > Task :solr:benchmark:compileJava > error: Annotation generator had thrown the exception. > javax.annotation.processing.FilerException: Attempt to recreate a file