BTW I've recently started using Crave for benchmarks, which sidesteps
this issue. In fact I never recall seeing the issue reported here,
even when I was starting off local.
https://github.com/apache/solr/pull/2548#pullrequestreview-2213174440
On Thu, Aug 1, 2024 at 10:12 AM Houston Putman <hous...@apache.org> wrote:
>
> I would think we could put them in the build directory, like we do with the
> api module.
>
> On Thu, Aug 1, 2024 at 9:07 AM Mike Drob <md...@mdrob.com> wrote:
>
> > I think the idea is correct, but I would also check if there is something
> > we could do with the generator task to mark those directories as generated
> > sources that should be cleaned up (I could be totally wrong here)
> >
> > On Thu, Aug 1, 2024 at 8:49 AM Jason Gerlowski <gerlowsk...@gmail.com>
> > wrote:
> >
> > > +1 - that makes sense afaict.
> > >
> > > On Thu, Aug 1, 2024 at 8:31 AM Gus Heck <gus.h...@gmail.com> wrote:
> > > >
> > > > I keep having to waste time on errors like this:
> > > >
> > > > > Task :solr:benchmark:compileJava
> > > > error: Annotation generator had thrown the exception.
> > > > javax.annotation.processing.FilerException: Attempt to recreate a file
> > > for
> > > > type
> > > >
> > >
> > org.apache.solr.bench.search.jmh_generated.QueryResponseWriters_query_jmhTest
> > > > at
> > > >
> > >
> > jdk.compiler/com.sun.tools.javac.processing.JavacFiler.checkNameAndExistence(JavacFiler.java:732)
> > > > at
> > > >
> > >
> > jdk.compiler/com.sun.tools.javac.processing.JavacFiler.createSourceOrClassFile(JavacFiler.java:498)
> > > > at
> > > >
> > >
> > jdk.compiler/com.sun.tools.javac.processing.JavacFiler.createSourceFile(JavacFiler.java:435)
> > > > at
> > > >
> > >
> > org.gradle.api.internal.tasks.compile.processing.IncrementalFiler.createSourceFile(IncrementalFiler.java:45)
> > > > at
> > > >
> > >
> > org.openjdk.jmh.generators.annotations.APGeneratorDestinaton.newClass(APGeneratorDestinaton.java:62)
> > > > at
> > > >
> > >
> > org.openjdk.jmh.generators.core.BenchmarkGenerator.generateClass(BenchmarkGenerator.java:448)
> > > > at
> > > >
> > >
> > org.openjdk.jmh.generators.core.BenchmarkGenerator.generate(BenchmarkGenerator.java:86)
> > > > ... etc
> > > >
> > > > Does anyone object to adding this to :solr:benchmark so that clean
> > > actually
> > > > cleans everything?
> > > >
> > > > clean {
> > > > delete "${layout.projectDirectory}/src/java/generated"
> > > > }
> > > >
> > > >
> > > > --
> > > > http://www.needhamsoftware.com (work)
> > > > https://a.co/d/b2sZLD9 (my fantasy fiction book)
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org
> > > For additional commands, e-mail: dev-h...@solr.apache.org
> > >
> > >
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org
For additional commands, e-mail: dev-h...@solr.apache.org
