Re: Apache Solr 9.7 branch created

I've merged this in. On Wed, Aug 14, 2024 at 11:40 PM Gus Heck wrote: > Ok PR is ready for RM approval: please approve and merge: > https://github.com/apache/solr/pull/2649 > > On Wed, Aug 14, 2024 at 4:29 PM Gus Heck wrote: > > > https://issues.apache.org/jira/browse/SOLR-17298 needs 1 more

Re: Apache Solr 9.7 branch created

Ok PR is ready for RM approval: please approve and merge: https://github.com/apache/solr/pull/2649 On Wed, Aug 14, 2024 at 4:29 PM Gus Heck wrote: > https://issues.apache.org/jira/browse/SOLR-17298 needs 1 more merge (& > backport), I will try to get it done tonight. Without this several querie

Re: Apache Solr 9.7 branch created

https://issues.apache.org/jira/browse/SOLR-17298 needs 1 more merge (& backport), I will try to get it done tonight. Without this several queries are unnecessarily excluded and this fact is undocumented. There is some contention over exactly how that change is tested so the tests will be excluded

Re: Apache Solr 9.7 branch created

Looks like we don't really have any blockers at this point. Thank you everyone for your help and patience, I'll proceed with this tonight or tomorrow morning. On Tue, Aug 13, 2024 at 8:13 AM David Smiley wrote: > I am not involved with SOLR-17334 PR-2527 (Coordinator node stuff). I > took a lo

Re: Apache Solr 9.7 branch created

I am not involved with SOLR-17334 PR-2527 (Coordinator node stuff). I took a look and I don't think you should hold up the release over this. It's an enhancement, not a bug, despite its title. The PR is apparently not ready; there is supposedly a draft PR that I don't see. Shrug. On Mon, Aug 12

Re: Apache Solr 9.7 branch created

Absolutely Eric, thank you! On Sat, Aug 10, 2024 at 5:26 AM Eric Pugh wrote: > I just backported > https://github.com/apache/solr/commit/affd06e1541ec74b812a9a15314a9ec5117fabe6 > to branch_9x and branch_9_7. Christine pointed out without the backport to > branch_9_7 we would be shipping licens

Re: Apache Solr 9.7 branch created

Thank you everyone for the help with releasing 9.7 so far. David - Do you plan to merge PR-2527 ? I assumed that was the case but might have misunderstood. On Thu, Aug 8, 2024 at 12:41 PM David Smiley wrote: > (Copying what I just added to that PR): >

Re: Apache Solr 9.7 branch created

I just backported https://github.com/apache/solr/commit/affd06e1541ec74b812a9a15314a9ec5117fabe6 to branch_9x and branch_9_7. Christine pointed out without the backport to branch_9_7 we would be shipping license code for libraries that we don't actually use in release 9.7. Realized I shoul

Re: Apache Solr 9.7 branch created

(Copying what I just added to that PR): AFAICT, the only remaining step is to remove the CHANGES.txt entry, possibly update the existing one to include contributors. I could do this or @cpoerschke . I'd love to see this bug fix in for 9.7! (fixes something not released; would be a shame to not rel

Re: Apache Solr 9.7 branch created

I noticed that https://github.com/apache/solr/pull/2607 was not merged. It means that https://issues.apache.org/jira/browse/SOLR-17386 is still open. This means Solr 9.7 will be a regression, because we lose the ability to update coordinator cores. I would consider merging https://github.com/ap

Re: Apache Solr 9.7 branch created

Thanks for reviewing this David. Please feel free to merge it :) On Wed, Aug 7, 2024 at 2:37 PM David Smiley wrote: > Anshum, please review the following: > > Prometheus Response Writer: > * https://github.com/apache/solr/pull/2616 fixes the content type. > Very trivial; ready to merge. No CHAN

Re: Apache Solr 9.7 branch created

Anshum, please review the following: Prometheus Response Writer: * https://github.com/apache/solr/pull/2616 fixes the content type. Very trivial; ready to merge. No CHANGES.txt needed as it improves the existing merged work. * FYI there's another PR that does an internal class rename to avoid con

Re: Apache Solr 9.7 branch created

Yup, realized the 'release wizard early' bit :) The wizard is wonderful, specially as the last time I released it was the manual process! On Tue, Aug 6, 2024 at 11:25 AM Gus Heck wrote: > Yeah release wizard early... see my writeup here: > > https://github.com/apache/solr/blob/main/dev-docs/rel

Re: Apache Solr 9.7 branch created

Another simple item reported by a user with a simple fix under review: https://issues.apache.org/jira/browse/SOLR-17391 On Tue, Aug 6, 2024 at 2:23 PM Gus Heck wrote: > > Yeah release wizard early... see my writeup here: > https://github.com/apache/solr/blob/main/dev-docs/releasing.adoc#step-1-ru

Re: Apache Solr 9.7 branch created

Yeah release wizard early... see my writeup here: https://github.com/apache/solr/blob/main/dev-docs/releasing.adoc#step-1-run-the-release-wizard (and feel free to add to it) Also you'll want to peek at https://issues.apache.org/jira/issues/?jql=project%20%3D%20SOLR%20AND%20resolution%20%3D%20Unres

Re: Apache Solr 9.7 branch created

Thanks for letting me know, Houston and David. I'll take a look and take care of that. On Mon, Aug 5, 2024 at 9:28 PM Houston Putman wrote: > It is in there. Definitely start the steps now anshum. You dont have to be > ready to do the release to do the first 1/3 of them. > > On Mon, Aug 5, 2024

Re: Apache Solr 9.7 branch created

https://issues.apache.org/jira/browse/SOLR-17298 needs 2 more merges... one for https://github.com/apache/solr/pull/2588 and one more I will submit soon with testing to verify the use of graphquery, rankquery and joinquery with multi-threaded search (or prove and document that any of them should b

Re: Apache Solr 9.7 branch created

It is in there. Definitely start the steps now anshum. You dont have to be ready to do the release to do the first 1/3 of them. On Mon, Aug 5, 2024 at 10:54 PM David Smiley wrote: > Does the release wizard not have the next version (9.8) in JIRA get > created? Ideally that is done with the bran

Re: Apache Solr 9.7 branch created

Does the release wizard not have the next version (9.8) in JIRA get created? Ideally that is done with the branch freezing so as to resolve JIRA issues not making the release. On Mon, Aug 5, 2024 at 11:44 PM David Smiley wrote: > > This change here is a super simple fix to the new > PrometheusRe

Re: Apache Solr 9.7 branch created

This change here is a super simple fix to the new PrometheusResponseWriter mime type: https://github.com/apache/solr/pull/2616 I'd like to get this in. On Mon, Aug 5, 2024 at 3:46 PM Anshum Gupta wrote: > > Hi everyone, > > I've created the release branch for 9.7. Can you please let me know what'