I've merged this in.
On Wed, Aug 14, 2024 at 11:40 PM Gus Heck <gus.h...@gmail.com> wrote: > Ok PR is ready for RM approval: please approve and merge: > https://github.com/apache/solr/pull/2649 > > On Wed, Aug 14, 2024 at 4:29 PM Gus Heck <gus.h...@gmail.com> wrote: > > > https://issues.apache.org/jira/browse/SOLR-17298 needs 1 more merge (& > > backport), I will try to get it done tonight. Without this several > queries > > are unnecessarily excluded and this fact is undocumented. There is some > > contention over exactly how that change is tested so the tests will be > > excluded and we can improve that and add a more general method for > testing > > multi-threading (randomized on or off) after the release. I'm already > > confident that the tests I have done in that PR prove that these queries > > work just fine with multi-threaded search and don't need to be excluded. > > > > On Wed, Aug 14, 2024 at 1:07 PM Anshum Gupta <ans...@anshumgupta.net> > > wrote: > > > >> Looks like we don't really have any blockers at this point. > >> > >> Thank you everyone for your help and patience, I'll proceed with this > >> tonight or tomorrow morning. > >> > >> On Tue, Aug 13, 2024 at 8:13 AM David Smiley <dsmi...@apache.org> > wrote: > >> > >> > I am not involved with SOLR-17334 PR-2527 (Coordinator node stuff). I > >> > took a look and I don't think you should hold up the release over > >> > this. It's an enhancement, not a bug, despite its title. The PR is > >> > apparently not ready; there is supposedly a draft PR that I don't see. > >> > Shrug. > >> > > >> > On Mon, Aug 12, 2024 at 11:21 AM Anshum Gupta <ans...@anshumgupta.net > > > >> > wrote: > >> > > > >> > > Thank you everyone for the help with releasing 9.7 so far. > >> > > > >> > > David - Do you plan to merge PR-2527 > >> > > <https://github.com/apache/solr/pull/2527> ? I assumed that was the > >> case > >> > > but might have misunderstood. > >> > > > >> > > On Thu, Aug 8, 2024 at 12:41 PM David Smiley <dsmi...@apache.org> > >> wrote: > >> > > > >> > > > (Copying what I just added to that PR): > >> > > > AFAICT, the only remaining step is to remove the CHANGES.txt > entry, > >> > > > possibly update the existing one to include contributors. I could > do > >> > > > this or @cpoerschke . > >> > > > I'd love to see this bug fix in for 9.7! > >> > > > > >> > > > (fixes something not released; would be a shame to not release it) > >> > > > > >> > > > Christine, if you have no time tonight (it will be your "night" if > >> you > >> > > > read this ~now) I could do this later this evening for me. > >> > > > > >> > > > On Thu, Aug 8, 2024 at 6:42 AM Ellaeln <ella...@proton.me.invalid > > > >> > wrote: > >> > > > > > >> > > > > I noticed that https://github.com/apache/solr/pull/2607 was not > >> > merged. > >> > > > It means that https://issues.apache.org/jira/browse/SOLR-17386 is > >> > still > >> > > > open. > >> > > > > > >> > > > > This means Solr 9.7 will be a regression, because we lose the > >> > ability to > >> > > > update coordinator cores. > >> > > > > > >> > > > > I would consider merging > https://github.com/apache/solr/pull/2607 > >> > and > >> > > > https://github.com/apache/solr/pull/2527 before releasing 9.7. > >> > > > > > >> > > > > > >> > > > > Hoping for the best, > >> > > > > Ella > >> > > > > > >> > > > > On Thursday, August 8th, 2024 at 12:48 AM, Anshum Gupta < > >> > > > ans...@anshumgupta.net> wrote: > >> > > > > > >> > > > > > Thanks for reviewing this David. Please feel free to merge it > :) > >> > > > > > > >> > > > > > On Wed, Aug 7, 2024 at 2:37 PM David Smiley > dsmi...@apache.org > >> > wrote: > >> > > > > > > >> > > > > > > Anshum, please review the following: > >> > > > > > > > >> > > > > > > Prometheus Response Writer: > >> > > > > > > * https://github.com/apache/solr/pull/2616 fixes the > content > >> > type. > >> > > > > > > Very trivial; ready to merge. No CHANGES.txt needed as it > >> > improves > >> > > > > > > the existing merged work. > >> > > > > > > * FYI there's another PR that does an internal class rename > to > >> > avoid > >> > > > > > > confusion before we ship this; it'd be nice to merge this > too > >> if > >> > you > >> > > > > > > let me :-) > >> > > > > > > > >> > > > > > > ThreadPoolExecutor configuration affecting multiple features > >> > albeit > >> > > > one PR: > >> > > > > > > * bad performance for backups of large collections > >> > > > > > > * new multiThreaded executor configuration > >> > > > > > > * nonoptimal for update log replay > >> > > > > > > See this issue and especially this comment: > >> > > > > > > > >> > > > > > > > >> > > > > >> > > >> > https://issues.apache.org/jira/browse/SOLR-17391?focusedCommentId=17871790&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17871790 > >> > > > > > > The PR is ready IMO albeit missing CHANGES.txt. I'd be happy > >> to > >> > move > >> > > > it > >> > > > > > > along. > >> > > > > > > Hats off to my colleague Pierre for spotting a really useful > >> > option > >> > > > > > > "allowCoreThreadTimeOut" > >> > > > > > > > >> > > > > > > On Tue, Aug 6, 2024 at 4:31 PM Anshum Gupta > >> > ans...@anshumgupta.net > >> > > > > > > wrote: > >> > > > > > > > >> > > > > > > > Yup, realized the 'release wizard early' bit :) > >> > > > > > > > > >> > > > > > > > The wizard is wonderful, specially as the last time I > >> released > >> > it > >> > > > was the > >> > > > > > > > manual process! > >> > > > > > > > > >> > > > > > > > On Tue, Aug 6, 2024 at 11:25 AM Gus Heck > gus.h...@gmail.com > >> > wrote: > >> > > > > > > > > >> > > > > > > > > Yeah release wizard early... see my writeup here: > >> > > > > > > > >> > > > > > > > >> > > > > >> > > >> > https://github.com/apache/solr/blob/main/dev-docs/releasing.adoc#step-1-run-the-release-wizard > >> > > > > > > > >> > > > > > > > > (and feel free to add to it) > >> > > > > > > > > > >> > > > > > > > > Also you'll want to peek at > >> > > > > > > > >> > > > > > > https://issues.apache.org/jira/issues/?jql=project %3D SOLR > >> AND > >> > > > resolution %3D Unresolved AND component %3D release-scripts ORDER > BY > >> > > > priority DESC%2C updated DESC > >> > > > > > > > >> > > > > > > > > for a list of gotchas > >> > > > > > > > > > >> > > > > > > > > On Tue, Aug 6, 2024 at 12:25 PM Anshum Gupta > >> > > > ans...@anshumgupta.net > >> > > > > > > > > wrote: > >> > > > > > > > > > >> > > > > > > > > > Thanks for letting me know, Houston and David. I'll > >> take a > >> > > > look and > >> > > > > > > > > > take > >> > > > > > > > > > care of that. > >> > > > > > > > > > > >> > > > > > > > > > On Mon, Aug 5, 2024 at 9:28 PM Houston Putman > >> > > > hous...@apache.org > >> > > > > > > > > > wrote: > >> > > > > > > > > > > >> > > > > > > > > > > It is in there. Definitely start the steps now > anshum. > >> > You > >> > > > dont > >> > > > > > > > > > > have to > >> > > > > > > > > > > be > >> > > > > > > > > > > ready to do the release to do the first 1/3 of them. > >> > > > > > > > > > > > >> > > > > > > > > > > On Mon, Aug 5, 2024 at 10:54 PM David Smiley > >> > > > dsmi...@apache.org > >> > > > > > > > > > > wrote: > >> > > > > > > > > > > > >> > > > > > > > > > > > Does the release wizard not have the next version > >> > (9.8) in > >> > > > JIRA > >> > > > > > > > > > > > get > >> > > > > > > > > > > > created? Ideally that is done with the branch > >> freezing > >> > so > >> > > > as to > >> > > > > > > > > > > > resolve JIRA issues not making the release. > >> > > > > > > > > > > > > >> > > > > > > > > > > > On Mon, Aug 5, 2024 at 11:44 PM David Smiley < > >> > > > dsmi...@apache.org > >> > > > > > > > > >> > > > > > > > > > wrote: > >> > > > > > > > > > > >> > > > > > > > > > > > > This change here is a super simple fix to the > new > >> > > > > > > > > > > > > PrometheusResponseWriter mime type: > >> > > > > > > > > > > > > https://github.com/apache/solr/pull/2616 > >> > > > > > > > > > > > > I'd like to get this in. > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > On Mon, Aug 5, 2024 at 3:46 PM Anshum Gupta < > >> > > > > > > > > > > > > ans...@anshumgupta.net> > >> > > > > > > > > > > > > wrote: > >> > > > > > > > > > > > > > >> > > > > > > > > > > > > > Hi everyone, > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > I've created the release branch for 9.7. Can > you > >> > > > please let > >> > > > > > > > > > > > > > me > >> > > > > > > > > > > > > > know > >> > > > > > > > > > > > > > what's > >> > > > > > > > > > > > > > pending and needs to still make it into the > >> > release? > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > Thanks! > >> > > > > > > > > > > > > > > >> > > > > > > > > > > > > > -- > >> > > > > > > > > > > > > > Anshum Gupta > >> > > > > > > > >> > > > > > > > >> > --------------------------------------------------------------------- > >> > > > > > > > >> > > > > > > > > > > > To unsubscribe, e-mail: > >> > dev-unsubscr...@solr.apache.org > >> > > > > > > > > > > > For additional commands, e-mail: > >> > dev-h...@solr.apache.org > >> > > > > > > > > > > >> > > > > > > > > > -- > >> > > > > > > > > > Anshum Gupta > >> > > > > > > > > > >> > > > > > > > > -- > >> > > > > > > > > http://www.needhamsoftware.com (work) > >> > > > > > > > > https://a.co/d/b2sZLD9 (my fantasy fiction book) > >> > > > > > > > > >> > > > > > > > -- > >> > > > > > > > Anshum Gupta > >> > > > > > > > >> > > > > > > > >> > --------------------------------------------------------------------- > >> > > > > > > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > >> > > > > > > For additional commands, e-mail: dev-h...@solr.apache.org > >> > > > > > > >> > > > > > > >> > > > > > -- > >> > > > > > Anshum Gupta > >> > > > > > >> > > > > > >> --------------------------------------------------------------------- > >> > > > > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > >> > > > > For additional commands, e-mail: dev-h...@solr.apache.org > >> > > > > > >> > > > > >> > > > > >> --------------------------------------------------------------------- > >> > > > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > >> > > > For additional commands, e-mail: dev-h...@solr.apache.org > >> > > > > >> > > > > >> > > > >> > > -- > >> > > Anshum Gupta > >> > > >> > --------------------------------------------------------------------- > >> > To unsubscribe, e-mail: dev-unsubscr...@solr.apache.org > >> > For additional commands, e-mail: dev-h...@solr.apache.org > >> > > >> > > >> > >> -- > >> Anshum Gupta > >> > > > > > > -- > > http://www.needhamsoftware.com (work) > > https://a.co/d/b2sZLD9 (my fantasy fiction book) > > > > > -- > http://www.needhamsoftware.com (work) > https://a.co/d/b2sZLD9 (my fantasy fiction book) > -- Anshum Gupta
