Re: RAT errors during RC1

2022-10-18 Thread Ishan Chattopadhyaya
Ah, my ~/.solr-releases dir was symlinked to my dev repo, which caused this :-D ishan@x1extreme ~/code/solr (branch_9_1) $ ls ~/.solr-releases/9.1.0/ -la total 16 drwxrwxr-x. 3 ishan ishan 4096 Sep 27 11:27 . drwxrwxr-x. 3 ishan ishan 4096 Sep 27 11:10 .. drwxrwxr-x. 3 ishan ishan 4096 Sep 27 11:2

Re: RAT errors during RC1

2022-10-18 Thread Ishan Chattopadhyaya
Right, indeed. I was testing out a recently failed test there ( https://issues.apache.org/jira/browse/SOLR-16425), in the wrong terminal window, which left the release repo's checkout unclean. On Tue, Oct 18, 2022 at 10:28 PM Jan Høydahl wrote: > TIP: If you follow the Release Wizard tediously (

Re: RAT errors during RC1

2022-10-18 Thread Jan Høydahl
TIP: If you follow the Release Wizard tediously (and you always should), all RM building will happen from a clean checkout under ~/.solr-releases/9.1.0/solr Jan > 18. okt. 2022 kl. 18:34 skrev Ishan Chattopadhyaya > : > > Thanks Kevin, "git clean -fdx" did the trick. Reverted the change to > d

Re: RAT errors during RC1

2022-10-18 Thread Ishan Chattopadhyaya
Thanks Kevin, "git clean -fdx" did the trick. Reverted the change to disable rat. On Tue, Oct 18, 2022 at 9:41 PM Ishan Chattopadhyaya < ichattopadhy...@gmail.com> wrote: > I just did that in 9.1 branch (not planning to branch_9x), to see if > things work properly. > Thanks for the pointer on out

Re: RAT errors during RC1

2022-10-18 Thread Ishan Chattopadhyaya
I just did that in 9.1 branch (not planning to branch_9x), to see if things work properly. Thanks for the pointer on out/ directory. I'll try another fresh checkout and try again. On Tue, Oct 18, 2022 at 9:36 PM Kevin Risden wrote: > I see you also already committed the rat change to disable the

Re: RAT errors during RC1

2022-10-18 Thread Kevin Risden
I see you also already committed the rat change to disable the check. The license check from rat is very important to ASF releases so it shouldn't just be removed. Kevin Risden On Tue, Oct 18, 2022 at 12:05 PM Kevin Risden wrote: > `out/` is a weird directory... I would remove the out director

Re: RAT errors during RC1

2022-10-18 Thread Kevin Risden
`out/` is a weird directory... I would remove the out directory and go from there? It looks like maybe there are some old files under the git checkout? I personally don't have an out directory in my Solr checkout. Kevin Risden On Tue, Oct 18, 2022 at 11:30 AM Ishan Chattopadhyaya < ichattopadhy

RAT errors during RC1

2022-10-18 Thread Ishan Chattopadhyaya
I'm trying to build the RC1 of 9.1 release. Here are the errors I ran into: * Where: Script '/home/ishan/code/solr/gradle/globals.gradle' line: 78 * What went wrong: Execution failed for task ':rat'. > Detected license header issues (skip with -Pvalidation.rat.failOnError= false): Unknown license: