It was both great and sad to see a bunch of PR's closed. I looked through,
and there looked to be some nice fixes to various tests that are a shame to not
get to done. On the other hand being open means they didn't get to done
either! I like the "close-stale" label, this could let someone s
Here is the PR: https://github.com/apache/solr/pull/2731
Hope it captures the consensus in this thread.. Add a review comment if you
want to change something. Will leave it open for several days..
One thing to think about is what will happen with the 92 PRs that are currently
open and marked STA
I haven't touch the labeling/workflow stuff, so I'd prefer not to make this
change. Jan, would this be up your alley? I think we have agreement to try
this!
On Tuesday, September 24, 2024 at 10:36:05 AM EDT, Mike Drob
wrote:
I think this is a common sense of false optimism, that w
I think this is a common sense of false optimism, that we will come back
and finish that PR we started. I too suffer from this frequently.
Why does it matter if the PR is open or closed though? Re-opening is a
single click, and after 6 months of zero activity it’s probably full of
merge conflicts
+1 to try.
Especially if the attempt includes the "exempt PR" label feature that
Eric linked to. I'd use that pretty frequently in my workflow, as I
often push code for feedback without knowing exactly when I'll be able
to return to it and get it "over the finish line".
On Mon, Sep 23, 2024 at 1
+1 to try
On Sun, Sep 22, 2024 at 3:43 PM Jan Høydahl wrote:
> +1 to try.
>
> 60 days for stale and another 60 days before close should be enough imo.
>
> We can set the ‘close-pr-label’ for easier reference of what prs were auto
> closed, should anyone wish to do archeology or re-open stuff tha
+1 to try.
60 days for stale and another 60 days before close should be enough imo.
We can set the ‘close-pr-label’ for easier reference of what prs were auto
closed, should anyone wish to do archeology or re-open stuff that obviously
went below people’s radar despite two notifications to the l
What if we tried it for a few months and then reevaluated?
Sent from my iPhone
> On Sep 20, 2024, at 3:02 PM, Jan Høydahl wrote:
>
> Any commit or comment on a stale PR will make it un-stale for 60 more days
> too.
>
> Jan Høydahl
>
>> On 19 Sep 2024, at 23:14, David Smiley wrote:
>>
>>
Any commit or comment on a stale PR will make it un-stale for 60 more days too.
Jan Høydahl
> On 19 Sep 2024, at 23:14, David Smiley wrote:
>
> Upon seeing a "stale" warning, how do I signal to the bot that this PR
> shouldn't be closed soon? Or perhaps upon re-opening, the bot ought to
> bac
It looks like you can have a label that specifies that a PR is exempt from
being marked Stale:
https://github.com/actions/stale?tab=readme-ov-file#exempt-pr-labels
We currently mark stale as 60 days, and if we were to choose 120 days before
closing, well, that gives you half a year before you n
Upon seeing a "stale" warning, how do I signal to the bot that this PR
shouldn't be closed soon? Or perhaps upon re-opening, the bot ought to
back off on this one forevermore?
On Thu, Sep 19, 2024 at 3:06 PM Jan Høydahl wrote:
> +1 I’ve tried suggesting this several times, also for abandoned JI
+1 I’ve tried suggesting this several times, also for abandoned JIRA issues,
but always big pushback.
If we get a stale warning and then, if no one cares, another notification when
auto-closing, no one can say they were not warned. And old closed PRs can
always be re-opened, but at that point t
I don't see in the dev list here a discussion on auto-closing old PRs but
FWIW I'm in favor of that provided we could somehow choose to keep a PR
open that we're still passionate about, that we don't want to be
forgotten. This was discussed in the meetup yesterday.
On Fri, Jan 26, 2024 at 10:56 A
t: 01/26/24 15:56:12 UTCTo: dev@solr.apache.org
Subject: Re: PR labeling
When I picked up https://github.com/apache/solr/pull/2225 it was cool to see
the “start-script” label! Thanks!
> On Jan 26, 2024, at 10:33 AM, Jan Høydahl wrote:
>
> The StaleBot is now active, running once a
When I picked up https://github.com/apache/solr/pull/2225 it was cool to see
the “start-script” label! Thanks!
> On Jan 26, 2024, at 10:33 AM, Jan Høydahl wrote:
>
> The StaleBot is now active, running once a day at midnight.
> I started in a conservative way, only labeling 10 PRs a day, and
The StaleBot is now active, running once a day at midnight.
I started in a conservative way, only labeling 10 PRs a day, and setting the
threshold at 60 days.
This gives us some time to evaluate without labeling the entire backlog.
Will be interesting to see whether the Bot results in some fogotte
Hi,
Got some initial (positive) feedback on the auto-categorization PR and plan to
merge on Thursday, giving you some more time to review. I feel I have not 100%
nailed perfect labels. Obviously we can't auto label things like feature/bug,
or versions, so this is only a "category". Ideally ther
Hi,
We tend to not use the GitHub's PR labels we have defined.
So I whipped up https://github.com/apache/solr/pull/2180 which is configured to
auto-label PRs based on what files are changed. Feedback welcome.
Also, I hope we can implement StaleBot for labeling PRs as stale. Lucene is
going to t
18 matches
Mail list logo
