Re: Overlapping arguments (SOLR-17383)

2024-09-24 Thread David Eric Pugh
Here is a candidate PR for resolving the various -v flavours of verbose, value, and version by moving to --debug in place of -v and --verbose.   https://github.com/apache/solr/pull/2721 On Tuesday, September 24, 2024 at 01:25:57 AM PDT, Christos Malliaridis wrote: I see. I didn't kn

Re: PR labeling

2024-09-24 Thread Mike Drob
I think this is a common sense of false optimism, that we will come back and finish that PR we started. I too suffer from this frequently. Why does it matter if the PR is open or closed though? Re-opening is a single click, and after 6 months of zero activity it’s probably full of merge conflicts

Re: PR labeling

2024-09-24 Thread Jason Gerlowski
+1 to try. Especially if the attempt includes the "exempt PR" label feature that Eric linked to. I'd use that pretty frequently in my workflow, as I often push code for feedback without knowing exactly when I'll be able to return to it and get it "over the finish line". On Mon, Sep 23, 2024 at 1

Re: Overlapping arguments (SOLR-17383)

2024-09-24 Thread Christos Malliaridis
I see. I didn't know that "start" is mandatory now. I am not sure if this case occurs, but we still have in bin/solr.cmd `IF "%SCRIPT_CMD%"=="" set SCRIPT_CMD=start` (see https://github.com/apache/solr/blob/7d6088381d918e4a94e8c3d2c20c1eb5be003186/solr/bin/solr.cmd#L393C1-L393C43), which is why I a