Re: Review SOLR-15955: Update Jetty dependency to 10

2022-11-10 Thread Kevin Risden
I don't think there is anything holding it up right now. I'll merge it to main hopefully today. Let it sit and see what happens with test results. Then look at backport to 9.x next week or week after. Kevin Risden On Thu, Nov 10, 2022 at 10:01 AM Houston Putman wrote: > We decided that the Jet

Re: Review SOLR-15955: Update Jetty dependency to 10

2022-11-10 Thread Houston Putman
We decided that the Jetty upgrade is important enough to be included in 9.2. Lets get this merged then take a look at Jetty 11! Anything else holding this up Kevib? - Houston On Thu, Nov 10, 2022 at 9:47 AM Eric Pugh wrote: > Was chatting with folks about SOLR-16368, which starts migrating tes

Re: Review SOLR-15955: Update Jetty dependency to 10

2022-11-10 Thread Eric Pugh
Was chatting with folks about SOLR-16368, which starts migrating tests over to the Http 2 Solr client, and someone mentioned that until we get to Jetty 10, and the impending bug fix that will probably only show up on Jetty 10, that this PR will potentially increase flakiness of our tests. So...

Re: SolrClient should be immutable?

2022-11-10 Thread Eric Pugh
Any other perspectives on this?At this point, I've migrated all the tests to using the HTTP 2 versions of the SolrClients where that makes sense using the Builder pattern. I'd like to get https://github.com/apache/solr/pull/1158 merged soon, so I can move on to updating more of Solr's c