Re: New committer: Sandra Parsick

2025-06-06 Thread Maarten Mulders
Congratulations Sandra! Thanks for all you've done so far, and good luck on the work ahead! Maarten On June 6, 2025 at 08:31, Hervé Boutemy wrote: Hi, The Project Management Committee (PMC) for Apache Maven has invited Sandra Parsick to become a committer and we are pleased to announce that

Re: Maven 4.0.0 Release - Thoughts?

2025-05-26 Thread Maarten Mulders
quite large IMO. Thanks, Maarten On May 26th, 2025 at 16:39, Elliotte Rusty Harold wrote: On Mon, May 26, 2025 at 2:25 PM Maarten Mulders wrote: That definition makes a lot of sense to me. If we would adhere to it, we should discipline ourselves after "a" next RC and *not* accept

Re: Maven 4.0.0 Release - Thoughts?

2025-05-26 Thread Maarten Mulders
That definition makes a lot of sense to me. If we would adhere to it, we should discipline ourselves after "a" next RC and *not* accept any code changes *except* for fixing critical uses. I think there have been too many changes since last RC to cut a 4.0.0 today. Maarten On 26/05/2025 14:14

Re: [VOTE] Require Java 21 for Maven 4 (Rephrased Vote)

2025-05-03 Thread Maarten Mulders
As much as I would like to use a modern version of Java, I also agree with Michael on this. It's simply too late for Maven 4. -1 Maarten On 02/05/2025 10:02, Michael Osipov wrote: -1 Changing such an important requirement in the RC phase isn't professional. On 2025/04/30 13:12:43 Matthias

Re: New Life Cycles Maven 4.0.0-rc3

2025-03-18 Thread Maarten Mulders
Thinking out loud... would it make more sense to name those phases "before:each" and "after:each" - following the vocabulary that e.g. JUnit uses? - Maarten On 18/03/2025 12:24, Guillaume Nodet wrote: The `all` phase is executed for each project. But you can avoid the plugin execution to be

Re: [DISCUSS] Support YAML poms

2025-03-06 Thread Maarten Mulders
Hi, -1 from me. It has nothing to do with all the things you can dislike about YAML. It's a matter of what we spend our time on. I don't think we should invest too much effort in having additional formats for the POM in Maven itself. We now have one format (XML) for the POM. This, together

Re: [VOTE] Retired Maven PDF Plugin

2025-02-22 Thread Maarten Mulders
+1 Maarten On 22/02/2025 09:43, Matthias Bünger wrote: Good morning everybody, ten days ago I started a discussion about the Maven PDF plugin, asking who is using it, if people have switched over to other tools and what everybody is thinking about archiving the plugin. You can read the mail an

Re: New committer: Martin Desruisseaux

2025-01-30 Thread Maarten Mulders
Congratulations Martin and welcome! - Maarten On January 30, 2025 at 09:35, Slawomir Jaranowski wrote: Hi, The Project Management Committee (PMC) for Apache Maven has invited Martin Desruisseaux to become a committer and we are pleased to announce that they have accepted. Please join us in w

Re: Fwd: [DISCUSS] Switch to GitHub issues

2024-12-11 Thread Maarten Mulders
On 11/12/2024 12:29, Elliotte Rusty Harold wrote: On Tue, Dec 10, 2024 at 5:10 PM Slawomir Jaranowski wrote: On Tue, 10 Dec 2024 at 17:42, Sylwester Lachiewicz wrote: Michale proposed closing all issues that have not been active for more than 3 years, so there will be less to maintain/migra

Re: [VOTE] Retire Maven Patch Plugin

2024-12-09 Thread Maarten Mulders
+1 Maarten On 07/12/2024 11:22, Slawomir Jaranowski wrote: Hi, The plugin is not maintained for a long time. It is rational to make it retire to show the real status of the project. Instead of this plugin we can simply use dedicated source code management tools. https://maven.apache.org/plug

Re: autorun spotless

2024-12-01 Thread Maarten Mulders
+1 to make it part of the Maven build, either in validate or in verify phase. I usually do this in work projects, too. As Eliotte says, it avoids breaking the build in CI. Preferably enabled by default, also on local builds. The only thing where I doubt is whether validate or verify would be

Re: [VOTE] Release Apache Maven 4.0.0-rc-1

2024-11-28 Thread Maarten Mulders
Hi, A little late as the vote has already closed... Tested on several public and internal projects, on Windows and macOS. No blocking issues discovered. +1 from me. We might want to check how the Maven Daemon is built/packaged/shipped. I recall they had the same issues as Karl Heinz mentions

Re: [DISCUSS] Project member emeritus policy change

2024-10-23 Thread Maarten Mulders
+1 Regarding the "dormant PMC member" issue that Eliotte mentioned. I am happy people are willing to contribute again! From what I understand, an inactive member is only marked as inactive / emeritus. They are not removed from the PMC. They can become active again by simply contributing and

Re: [VOTE] Release Apache Maven 4.0.0-beta-5, respin 1

2024-10-22 Thread Maarten Mulders
+1 Generally I am not a big fan of shipping with large known defects, but I agree having the feedback on the majority of the things that do work is important. I think it would be good if we added a few more sample projects to our IT suite that use Maven 4 features that are enabled through th

Re: [VOTE] Release Apache Maven 4.0.0-beta-5

2024-10-18 Thread Maarten Mulders
-1 Discovered a problem in model building when using modelVersion 4.1.0. Some dependencies will not be present in the model. Details are in MNG-8331 [1]. Working on an IT that demonstrates it as well as a fix. Maarten [1] https://issues.apache.org/jira/browse/MNG-8331 On 18/10/2024 18:33,

Re: Disable ASF GitHub Bot comments in JIRA

2024-08-29 Thread Maarten Mulders
Hi Konrad, Definitely agree with you that it's redundant and verbose. The lack of formatting makes them hard to read, they don't get updated when the original comment on GitHub is edited. Fun fact, I have a mail rule to mark them 'read' automatically. If this rule proves to match the right m

Re: GH Action Shared v4 fails for Java 8 on Mac OS

2024-08-11 Thread Maarten Mulders
That's interesting. It means we don't test on macOS 12 or 13 anymore, as ASF Jenkins doesn't do it either. Personally, I don't think all MacBook owners have replaced their Intel-based machines with ARM-based machines. They may be a bit older but I don't think they're out of operation everywher

Re: plugins 3.x branches and dependabot

2024-07-15 Thread Maarten Mulders
Would it be possible to configure Dependabot in such a way that it only offers bugfix updates for the 3.x-branches, but not minor or major updates? Rationale: if there's a security issue ficed in a bugfix release, we most likely want to have it, but we don't want to do double work in migrating

Re: Preparing Maven 4.0.0 release ?

2024-07-08 Thread Maarten Mulders
Hello, On 06/07/2024 12:06, Guillaume Nodet wrote: I'd like to start preparing for the 4.0.0 release. There are a few open PR that needs review: https://github.com/apache/maven/milestone/11 There are a few open issues for 4.0.0 https://issues.apache.org/jira/issues/?jql=project%20%3D%201

Re: [DISCUSS] Maven should ALWAYS install/deploy at end

2024-06-14 Thread Maarten Mulders
Would flipping the defaults make this a backward incompatible change? If users are not aware of this change, it will change their build/deploy in a significant way... Maarten On 14/06/2024 19:49, Tamás Cservenák wrote: Howdy Yes, Martin is right: am talking about the two plugin *AtEnd param

Re: [DISCUSS] Removal of ineffective switch for Maven 4

2024-05-28 Thread Maarten Mulders
5/05/2024 14:00, Guillaume Nodet wrote: I think those have been removed 3 years ago... https://issues.apache.org/jira/browse/MNG-6888 Le ven. 24 mai 2024 à 13:10, Maarten Mulders a écrit : On 24/05/2024 09:43, Michael Osipov wrote: On 2024/05/24 07:06:45 Maarten Mulders wrote: Hi all, Today,

Re: [DISCUSS] Removal of ineffective switch for Maven 4

2024-05-24 Thread Maarten Mulders
On 24/05/2024 09:43, Michael Osipov wrote: On 2024/05/24 07:06:45 Maarten Mulders wrote: Hi all, Today, I noticed Maven has an `-up` switch, for `--update-plugins`. The help text says it's ineffective, only kept for backward compatibility. With the advent of Maven 4, would this be a

Re: [VOTE] Release Apache Maven 4.0.0-beta-3

2024-05-24 Thread Maarten Mulders
+1 Maarten On 23/05/2024 12:14, Tamás Cservenák wrote: +1 On Wed, May 22, 2024 at 5:12 PM Guillaume Nodet wrote: This is a vote to release Apache Maven 4.0.0-beta-3, as I've cut another release to fix blocking issues found in beta-2. We solved 25 issues: https://issues.apache.org/jira/s

[DISCUSS] Removal of `-up` switch for Maven 4

2024-05-24 Thread Maarten Mulders
Hi all, Today, I noticed Maven has an `-up` switch, for `--update-plugins`. The help text says it's ineffective, only kept for backward compatibility. With the advent of Maven 4, would this be a good moment to remove this switch? Thanks, Maarten -

Re: [VOTE] Release Apache Maven 4.0.0-beta-2

2024-05-20 Thread Maarten Mulders
Thanks for pushing the first beta, Guillaume! +1 from me. - Maarten On 13/05/2024 19:40, Guillaume Nodet wrote: I've cut another release after having fixed a bug in the consumer pom creation. This is a vote to release Apache Maven 4.0.0-beta-1. We solved 21 issues: https://issues.apache.org

Re: Road forward for: New flag to verify the status

2024-05-09 Thread Maarten Mulders
On 26/04/2024 15:11, Juul Hobert wrote: Hi, It's been a while since changes have been made to MNG-6869. It adds helpful functionality that is particularly useful when you're on a company network and want to do some basic checks to verify if Maven is working. This will be helpful for a large gro

Re: [VOTE] Release Maven Plugin Tools version 3.13.0

2024-05-03 Thread Maarten Mulders
On 03/05/2024 08:57, Michael Osipov wrote: Hi, we solved 5 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820&version=12354458 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MPLUGIN%20AND%20resolution%20

Re: [DISCUSS] Maven Core Plugins versioning

2024-03-08 Thread Maarten Mulders
It might've been proposed and rejected before, but how about 1. maven4-compiler-plugin -or- 2. maven-compiler-plugin (with maven4/maven5/etc classifier) In both scenario's, we could still use semantic versioning as we do right now, and as Maven users probably expect us to adhere to. Thanks,

Re: [VOTE] Release Apache Maven 4.0.0-alpha-13

2024-03-07 Thread Maarten Mulders
+1 I agree with Romain, isn't it about time we move to beta or milestone releases? I think it may give us two benefits: 1. likely to attract more early-bird testers, which can give us valuable feedback. 2. hopefully convince third-party plugin maintainers to start working on Maven 4 compatib

Re: [VOTE] Require Java 17 for Maven 4

2024-02-28 Thread Maarten Mulders
As a user of Maven: 0 (I don't care, I run Maven with Java 21 anyway) As a developer and PMC of Maven: +1 So, +1 from me. Maarten On 28/02/2024 08:30, Benjamin Marwell wrote: Hi Maven Devs/Users/Committers and PMC members! After several discussions on the mailing lists, I would like to star

Re: [MPH-183] effective-pom + verbose should show path to source

2024-01-29 Thread Maarten Mulders
ge. I'm working closely with them to help them where necessary. Thanks, Maarten On 14/09/2022 13:39, Maarten Mulders wrote: On 08/06/2022 23:03, Robert Scholte wrote: This is already a huge improvement as imported boms now hides this information. Thanks! I do see room for more improv

Re: [VOTE] Release Maven Surefire version 3.2.4

2024-01-01 Thread Maarten Mulders
On 01/01/2024 12:19, Michael Osipov wrote: Hi, we solved 5 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12354030 There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%20SUREFIRE%20AND%20resolution%2

Re: [VOTE] Release Maven Surefire version 3.2.4

2023-12-31 Thread Maarten Mulders
On 31/12/2023 21:58, Michael Osipov wrote: Am 2023-12-31 um 21:33 schrieb Maarten Mulders: Here's (my) last vote of the year: +1 - Maarten PS. I noticed that with this release, both Surefire and Failsafe start spitting out an extra message into the output that is not there in

Re: [VOTE] Release Maven Surefire version 3.2.4

2023-12-31 Thread Maarten Mulders
Here's (my) last vote of the year: +1 - Maarten PS. I noticed that with this release, both Surefire and Failsafe start spitting out an extra message into the output that is not there in 3.2.3: [INFO] --- surefire:3.2.4:test (default-test) @ marky --- [INFO] Using auto detected provider org

Re: [VOTE] Release Apache Maven 4.0.0-alpha-10

2023-12-19 Thread Maarten Mulders
+1 Maarten On 18/12/2023 19:16, Guillaume Nodet wrote: I'm starting a new vote to release this new alpha. This mainly brings in latest resolver alpha release which fixes a nasty bug causing maven to never quit. Fwiw, a few plugins have already been ported to the new API (clean, install, depl

Re: [VOTE] Release Apache Maven 4.0.0-alpha-9

2023-12-10 Thread Maarten Mulders
+1 Thanks, Maarten On December 8, 2023 at 20:12, Guillaume Nodet wrote: I'm starting a new vote to release this new alpha. This alpha release provides a bunch of new things: * switch to maven-resolver 2.0.0-alpha-3 * multi-threaded model builder * namespace support in xml configurati

Re: [VOTE] Apache Maven 4.0.0-alpha-8 release

2023-10-23 Thread Maarten Mulders
+1 Thanks for rolling this release! Maarten On 20/10/2023 23:37, Guillaume Nodet wrote: I'm starting a new vote to release this new alpha. This alpha release provides new cornerstone features for the future Maven evolution. In particular, the POM model which was set in stone to a 4.0.0 versio

Re: [VOTE] Retire Maven Docck Plugin

2023-10-17 Thread Maarten Mulders
+1 On 17/10/2023 00:50, Slawomir Jaranowski wrote: Hi, - Last release was in 2015 - use Maven 2.2.1 - we have a Maven Plugin Tools - which should be one project for build and check Maven plugins - no active development ... https://issues.apache.org/jira/issues/?jql=project%20%3D%20MDOCCK%20AND

Re: [VOTE] Release Apache Maven Release Plugin version 3.0.1

2023-05-31 Thread Maarten Mulders
+1 - tested on macOS using Maven 3.9.2 with a custom release strategy. Maarten On 30/05/2023 23:34, Slawomir Jaranowski wrote: Hi, We solved 8 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317824&version=12353136 There are still a couple of issues left in JIRA: h

Re: [DISCUSS] Apache Maven 4.0 with UTF-8 by default

2023-04-13 Thread Maarten Mulders
A little late to the party, but here's an off-list reply I got when Geoffrey De Smet (creator of OptaPlanner) asked me about this very same topic on Twitter: https://twitter.com/GeoffreyDeSmet/status/1646074136337215494 For those who don't want to use Twitter, let me summarise the conversation

Re: [HEADS UP] Release of surefire

2023-03-09 Thread Maarten Mulders
On 09/03/2023 13:32, Gary Gregory wrote: Yes please, I get a raised eyebrow when a surefire and failsafe M version is reviewed in a PR... Gary Same here. It's hard to explain that latest Surefire is still a "milestone" for 3.0.0 after so many years. Or... there must be a strong reason why i

Re: [VOTE] Release Apache Maven Daemon 0.9.0

2023-01-26 Thread Maarten Mulders
+1, tested on Mac (arm64/aarch64) Maarten On 25/01/2023 10:10, Guillaume Nodet wrote: I've staged a candidate release at https://dist.apache.org/repos/dist/dev/maven/mvnd/0.9.0/ Note that this release is based on Maven 3.8.7. The release notes are available at https://github.com/apache/ma

Re: [VOTE] Release Apache Maven 4.0.0-alpha-3

2022-12-13 Thread Maarten Mulders
Agreed, Slawomir! It would make it much easier for users to find the alpha releases of Maven 4. If it's easier for them to find, it will be easier for them to test the waters and provide us with feedback. Also, a +1 on the 4.0.0-alpha-3 release. Thanks, Maarten On December 14, 2022 at 01:1

Re: Procedure for committing a PR from a non-committer

2022-11-29 Thread Maarten Mulders
On 29/11/2022 22:22, Elliotte Rusty Harold wrote: https://github.com/apache/maven/pull/845 is IMHO ready to merge into core. This is from an external contributor. Can someone point me to or remind me of the steps for getting this PR to run in Jenkins? It has passed our Github CI checks. I don'

Re: Testing plugins in JUnit 5

2022-11-05 Thread Maarten Mulders
On 05/11/2022 12:07, Mark Raynsford wrote: Hello! As the subject says: Is there a documented way to write tests for plugins under JUnit 5? The only thing I've been able to find is the takari testing project: https://github.com/takari/takari-plugin-testing-project There seems to be some prel

Re: [VOTE] Release Apache Maven 4.0.0-alpha-2

2022-10-22 Thread Maarten Mulders
On 15/10/2022 02:18, Guillaume Nodet wrote: I've staged a release candidate at https://repository.apache.org/content/repositories/maven-1811 The binaries are available at: https://repository.apache.org/service/local/repositories/maven-1811/content/org/apache/maven/apache-maven/4.0.0-alpha-2/

Re: [DISCUSS] Release Maven 4.0.0-alpha-1 this week

2022-10-12 Thread Maarten Mulders
Hi all, TL;DR: +1 for releasing an "4.0.0-alpha-1". I think that an "alpha-1" could also be of value for end users. They might want to experiment with new features, see if they work on their project. Nowadays, I mostly hear people being reluctant to download a SNAPSHOT from a Jenkins mach

Re: [MPH-183] effective-pom + verbose should show path to source

2022-09-14 Thread Maarten Mulders
eel that's far from trivial, so let's add that to the backlog of "this would make it even better". this would give quite comprehensive explanation but step by step: dependencyManagement import is really a nice improvement, go, go, go Regards, Hervé Le mardi 7 juin 2022

Re: [MPH-183] effective-pom + verbose should show path to source

2022-09-14 Thread Maarten Mulders
work, Thanks again! Robert -- Oorspronkelijke bericht -- Van "Maarten Mulders" Aan "Maven Developers List" Datum 7-6-2022 17:46:41 Onderwerp [MPH-183] effective-pom + verbose should show path to source Hi all, Over the past months, I have been working on an enhance

Re: Integration test suite

2022-08-22 Thread Maarten Mulders
Hi all, The overall idea of the integation tests in GH Actions is this: 1. Check if the org/owner of the fork where the PR comes from _also_ has a fork of maven-integration-testing. 2. If so, check if they have a branch on that fork with the same name as the fork of maven-core. 3. If so, run t

Re: Question - JDK Minimum of future Apache Maven 4.0.0

2022-07-24 Thread Maarten Mulders
Hi all, Allow me to chime in on this long-running discussion... I haven't raised my voice yet, as I was curious for other opinions. *My vote would be Java 17 for both building and running Maven 4.* I certainly agree with the points brought up by Karl-Heinz and Benjamin regarding Toolchains.

Re: MENFORCER-398 | up for grabs

2022-07-20 Thread Maarten Mulders
Hello Björn, Thanks for reaching out. I think your observations a right, making this _really_ an up-for-grabs issue. Given that most Maven users only enable debug logging for troubleshooting purposes, they will usually not see it. So we would indeed need a small code change to make the infor

Re: ASF Jenkins

2022-07-07 Thread Maarten Mulders
Another advantage I see from GH Actions: it provides instant feedback to those who do not contribute regularly and know their way around in ASF infra. Especially for first-time contributors, it's good to see fast feedback on their contribution. For me, it feels like I'm wasting my time to late

[MPH-183] effective-pom + verbose should show path to source

2022-06-07 Thread Maarten Mulders
Hi all, Over the past months, I have been working on an enhancement [1] for the Maven Help Plugin. The enhancement is about the effective-pom goal. If you pass it the 'verbose' parameter, it will include inline comments saying "this line of the effective pom is caused by this line in a differ

Re: release of surefire M7

2022-05-25 Thread Maarten Mulders
On 25/05/2022 01:53, Olivier Lamy wrote: Hi I'd like to release M7 because of this blocker issue https://issues.apache.org/jira/browse/SUREFIRE-2057 I will start release process by the end of this week and move current non fixed issue to M8 cheers Olivier I'd love to merge SUREFIRE-2077 in fo

Re: [VOTE] Release Apache Maven Wrapper version 3.1.1

2022-05-08 Thread Maarten Mulders
On 08/05/2022 11:28, Hervé BOUTEMY wrote: Hi, We solved 14 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12350929&styleName=Text&projectId=12323721 Staging repo: https://repository.apache.org/content/repositories/maven-1750/ https://repository.apache.org/content/reposit

Re: Trying Maven v4

2022-04-02 Thread Maarten Mulders
On 02/04/2022 15:19, Tibor Digana wrote: AFAIK, maven 4 is just a prototype. T On Sat, Apr 2, 2022 at 3:00 PM John Patrick wrote: Hi, If I want to start testing maven v4.x is it the master branch or the mvn4 branch I need to build? Or is there a guide I can look at with current/known issues o

Re: Surprises on maven 4

2022-03-29 Thread Maarten Mulders
Hi, Let me only chime in on your first question, as I have no idea about the latter one... On 28/03/2022 10:19, Romain Manni-Bucau wrote: Hi all, For an output check (thanks again Michael for the pointer), I tested maven master/4 this morning and get a few question marks: 1. I know we warn

Re: [DISCUSS] Radical Fast Forward to 3.5.4

2022-03-14 Thread Maarten Mulders
Just to clarify: "Raise the entire baseline to Maven 3.5.4" means that the official Maven plugins will only work from Maven Core 3.5.4 onwards? In that case, +1 to move the baseline to 3.5.4. Point of concern/question: this may be a breaking change in some cases - how do we communicate that in

Re: [VOTE] Maven Compiler Plugin 3.10.0

2022-02-11 Thread Maarten Mulders
Did a quick test of MCOMPILER-460 (not in the release notes, but I believe it should be) on a small project and that looks good. Also tried to build Maven itself, worked fine. Vote: +1 Thanks, Maarten On 11/02/2022 10:36, Olivier Lamy wrote: Hi, I'd like to release Apache Maven Compiler P

Re: Can't build Core ITs with Maven master

2021-12-29 Thread Maarten Mulders
Hi Michael e.a., Can confirm, I'm seeing the same. The first error (URL contains an expression but should be a constant) is completely unfamiliar to me. I worked around it in a similar way as part of your patch, but I don't know what caused it or what should be the eventual solution. After h

Re: Welcome Sławomir Jaranowski as Maven Committer

2021-12-14 Thread Maarten Mulders
Congrats and welcome, Sławomir! Maarten On 14/12/2021 11:10, Robert Scholte wrote: The Maven PMC invited Sławomir to become a committer and he has accepted it. Enjoy improving Apache Maven! thanks, Robert - To unsubscribe

Re: reviewing Maven Wrapper before releasing

2021-12-12 Thread Maarten Mulders
Chiming in a little late, but here are my 2 cents nevertheless. I would not feel confident releasing something that we cannot test in an automated way. Not having an integration test suite means we don't know for sure if it works. And if we know it works and we change something, we're back to z

Re: Any reason xi:include is not allowed?

2021-11-17 Thread Maarten Mulders
Gary beat me to it :-) I would be hesitant to add support for XML Entities or XML Includes. Both have proven themselves to be a frequent source of security issues ([1], [2] and probably a lot more). The problem is that XML parsers typically do not allow selective includes, so if we want to prev

Eat our own dogfood

2021-11-09 Thread Maarten Mulders
Hi all, In the last year, we've seen multiple situations where a change in Maven core prevented Maven from building itself [1][2]. On the path to stabilising Maven towards Maven 4, I think this isn't helping us. That's why I propose we introduce an additional GitHub action. Let's call it the

Re: [VOTE] Release Apache Maven version 3.8.3

2021-09-29 Thread Maarten Mulders
Tested on macOS with Java 11 and Java 17. Maven builds itself, and archetype:generate works fine as well. I can't see any issues related to Jansi. +1 Maarten On 29/09/2021 19:01, Michael Osipov wrote: Am 2021-09-27 um 21:17 schrieb Michael Osipov: Hi, We solved 18 issues: https://issues.a

Re: (prop) Canonical property storage

2021-08-24 Thread Maarten Mulders
My main remark - after reading the original post - is already captured in the thread: having method parameters declared Optional feels like an anti-pattern to me. If must be, there could be an overload, but a null parameter would be consistent with the existing API. I think for Maven to be abl

Re: JDK 17 related plugin releases

2021-08-18 Thread Maarten Mulders
do with. If it only were about upgrading ASM, I could do that, but I cannot properly assess the open merge requests. Maarten On 18/08/2021 09:16, Maarten Mulders wrote: I'll take the maven-plugin-plugin for a ride. Maarten On 17/08/2021 19:28, Robert Scholte wrote: With JDK 17 ap

Re: JDK 17 related plugin releases

2021-08-18 Thread Maarten Mulders
I'll take the maven-plugin-plugin for a ride. Maarten On 17/08/2021 19:28, Robert Scholte wrote: With JDK 17 appearing soon we should at least release those plugins that depend on ASM.[1] Even though optional, I'll release both the maven-compiler-plugin and maven-javadoc-plugin too. I could

Re: Welcome Guillaume Nodet as new Maven Committer

2021-05-27 Thread Maarten Mulders
Happy to have you on board, Guillaume! Maarten On 25/05/2021 19:19, Robert Scholte wrote: Hi, On behalf of the Apache Maven PMC I am pleased to announce that Guillaume Nodet has been voted in as new Apache Maven committer and he has accepted this invitation. Welcome on board and have a lot o

Re: [VOTE] Release Maven Resolver version 1.6.3

2021-05-05 Thread Maarten Mulders
+0.5 Tested on my Mac, release is working fine. Could not verify if the issues that have been resolved are indeed solved, but it doesn't seem to break existing stuff either. Maarten On May 5, 2021 at 22:36, Tibor Digaňa wrote: +1 On Tue, May 4, 2021 at 3:32 PM Michael Osipov wrote: Hi

[ANN] Apache Maven Shared Utils 3.3.4 Released

2021-04-30 Thread Maarten Mulders
The Apache Maven team is pleased to announce the release of the Apache Maven Shared Utils, version 3.3.4. This project aims to be a functional replacement for plexus-utils in Maven. https://maven.apache.org/shared/maven-shared-utils/ You should specify the version in your project's plugin conf

[RESULT] [VOTE] Release Apache Maven Shared Utils version 3.3.4

2021-04-30 Thread Maarten Mulders
, Maarten Mulders wrote: Hi, We solved 6 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12350122&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317922%20AND%20resol

[VOTE] Release Apache Maven Shared Utils version 3.3.4

2021-04-26 Thread Maarten Mulders
Hi, We solved 6 issues: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317922&version=12350122&styleName=Text There are still a couple of issues left in JIRA: https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317922%20AND%20resolution%20%3D%20Unresolved%20AND%20com

Re: Failing IT's on Linux in GitHub Actions

2021-04-18 Thread Maarten Mulders
blem and I added one more step to the CI which checked all open ports. For instance they changed something in Github and 8081 or 8082 was allocated. There was a conflict with the ports and I had to shift mine, that;s it. T On Sun, Apr 18, 2021 at 8:17 PM Maarten Mulders wrote: Hi all, It

Failing IT's on Linux in GitHub Actions

2021-04-18 Thread Maarten Mulders
Hi all, It seems the following IT's predictably fail on Linux (not on Windows or MacOS) in GitHub Actions, but not at all in Jenkins: * MavenIT0146InstallerSnapshotNaming * MavenITmng2387InactiveProxyTest * MavenITmng4991NonProxyHostsTest This is also the case in master, by the way. What they

Re: [VOTE] Release Apache Maven Wrapper Plugin version 3.0.2

2021-04-05 Thread Maarten Mulders
+1 Tested with Maven 3.8.1 on macOS. Plugin does not generate a wrapper for Maven 3.6.3, 3.7.0 or 3.8.1. Maarten On 05/04/2021 16:29, Robert Scholte wrote: To: "Maven Developers List" Subject: [VOTE] Release Apache Maven Wrapper Plugin version 3.0.2 Hi, We solved 2 issues: https://issues

Re: [VOTE] Release Apache Maven version 3.8.1

2021-03-30 Thread Maarten Mulders
Retried the test that I did on 3.8.0, this time I observe the desired / correct behaviour. +1 Maarten On March 31, 2021, at 01:46, Mark Derricutt wrote: +1 non-binding - bistro zips are in the /dev/ tree - my multi-repo osgi maven tiles weirdo build works fine. From: Robert Sc

Re: [VOTE] Release Apache Maven version 3.8.0

2021-03-24 Thread Maarten Mulders
A 0-vote from my side. As far as I can tell, non-TLS repos are indeed blocked. That is the main reason for cutting this release, and it works, which is good. But if I understood Hervé correctly, the message that appears when Maven attempts download of an artifact over a non-TLS connection diff

Re: [VOTE] Release Apache Maven version 3.8.0

2021-03-22 Thread Maarten Mulders
Tested on a MacBook, set up a HTTP (non-TLS) repository, and removed a part of my ~/.m2/repository. The missing artifacts are not downloaded over HTTP, which is good: Downloading from maven-default-http-blocker: http://0.0.0.0/... Downloading from maven-default-http-blocker: http://0.0

Re: Doxia 1.10 and maven-site-plugin 3.10

2021-02-28 Thread Maarten Mulders
I happen to have a MacBook and I can confirm the failures - they also happen on my machine with Java 11. Unfortunately I don't have much time on my hands right now to investigate, but I'd be happy to share the log files if somebody else needs them. From what I've seen, three seem to be cause

Superfluous build notifications in JIRA

2021-01-19 Thread Maarten Mulders
Hi all, Last Thursday and Friday, I've received well over 400 notifications from Apache JIRA, all by the "Hudson" user (now Jenkins). They notified me of a failed job regarding a ticket I was watching. Not only does it annoy me, it also annoys people who reported a ticket [1]. As far as I ca

Using Maven snapshot builds (macOS & Ubuntu)

2020-10-26 Thread Maarten Mulders
Hi all, Recently, we've had an issue being reported against a snapshot build of Maven [1]. I think this kind of early feedback is very valuable, especially since this was a scenario not covered in our regular integration tests. Personally, I also prefer to run Maven snapshot builds on my dev

Re: Second review for MNG-6118

2020-10-15 Thread Maarten Mulders
hanks, Maarten On Oct 1st, 2020 at 21:11, Maarten Mulders wrote: Hi all, Over the last month, Martin Kanters and myself have been working to make it possible to execute goals on a specific module while building a multi-module project [1]. The pull request [2] enables resolving inter-m

Re: Hacktoberfest

2020-10-05 Thread Maarten Mulders
to:rfscho...@apache.org] Gesendet: Sonntag, 4. Oktober 2020 10:55 An: Maarten Mulders; dev@maven.apache.org Betreff: Re: Hacktoberfest I think the hacktober is a good initiative. Just be aware that we need to respond to these PRs ASAP, otherwise it might work against us. We already have a huge amo

Re: Hacktoberfest

2020-10-04 Thread Maarten Mulders
s not like we don't have enough PRs. I think we need at least 5 committers that explicitly say the will pick up these PR with the highest priority for 1 month. Otherwise I'd say no. Robert On 3-10-2020 20:41:04, Maarten Mulders wrote: Hi all, Today, I came across this update

Hacktoberfest

2020-10-03 Thread Maarten Mulders
Hi all, Today, I came across this update [1] from DigitalOcean, one of the companies behind Hacktoberfest. TL;DR: to prevent "spam pull requests", only accepted/merged/approved pull requests against GitHub repositories labelled "hacktoberfest" qualify for the free t-shirt or planting a tree.

Second review for MNG-6118

2020-10-01 Thread Maarten Mulders
Hi all, Over the last month, Martin Kanters and myself have been working to make it possible to execute goals on a specific module while building a multi-module project [1]. The pull request [2] enables resolving inter-module dependencies of the whole multi-module project while building a par

Re: [DISCUSS] Make Jira issues viewable.

2020-09-11 Thread Maarten Mulders
Agreed. If there's anything that is too deliberate to discuss in the open, there's the mailing list, direct email or what not. Maarten On 11/09/2020 09:51, Robert Scholte wrote: Based on the https://twitter.com/ameliaeiras/status/1303815661307613184 and the responses of Marten Deinum I agree

Re: Fwd: Maven builds out of control

2020-08-17 Thread Maarten Mulders
On 17/08/2020 09:55, Olivier Lamy wrote: Hi there we definitely need to reduce the matrix we have and cleanup branches ... so I reduced the matrix (no more 14,15) and only '3.3.x','3.6.x' Furthermore, we need to clean up unused branches. What about removing branches older than 1yo? Then older th

Re: Excluding builds of certain git branches on ASF Jenkins

2020-07-22 Thread Maarten Mulders
On 22/07/2020 11:49, Elliotte Rusty Harold wrote: On Wed, Jul 22, 2020 at 8:36 AM Maarten Mulders wrote: In the Jenkins user interface, I see there's an option to build only specific branches. I'm thinking of excluding everything that starts with dependabot/ there, just to be sure

Excluding builds of certain git branches on ASF Jenkins

2020-07-22 Thread Maarten Mulders
Hi all, As you may have noticed, yesterday we had a situation on Jenkins where around 500 jobs where queuing up. Many of them of them where building Dependabot branches from our Github mirrors. The way Dependabot works is they do *not* create a fork of our repo's. Instead they create a branc

Re: Short guide "Working with Github pull requests"

2020-07-13 Thread Maarten Mulders
EQUEST FOR RIDICULOUS COMMIT WHICH DO NOT NEED > REVIEW*** > > it's very noisy and useless notifications (especially because we get > from both gitbox and github) > > > On Tue, 14 Jul 2020 at 16:18, Maarten Mulders > wrote: > >> Good point. I'll sta

Re: Short guide "Working with Github pull requests"

2020-07-13 Thread Maarten Mulders
Good point. I'll start by disabling the "Squash & merge" button using asf.yaml for the repositories I have cloned locally. Maarten On 13/07/2020 22:03, Elliotte Rusty Harold wrote: >>> So then the conclusion is, we can use Github for accepting & merging >>> pull requests, but shouldn't use "Squas

Re: Short guide "Working with Github pull requests"

2020-07-13 Thread Maarten Mulders
to most developers these > days, and the Github UI is significantly advanced beyond Gitbox. > > On Mon, Jul 13, 2020 at 2:20 PM Maarten Mulders wrote: >> >> Hi all, >> >> The other day I was working on a pull request offered through Github. I >> couldn't fin

Short guide "Working with Github pull requests"

2020-07-13 Thread Maarten Mulders
Hi all, The other day I was working on a pull request offered through Github. I couldn't find instructions on how to accept and incorporate it. Based on my own experiences with submitting patches to Maven through Github I came up with a short how-to. I have written it down in a short guide "Worki

Re: second MNG-5760

2020-07-13 Thread Maarten Mulders
Since this message, I have seen one review (and approval). Thanks for that! If nothing more comes in, I'll assume approval and merge this Wednesday morning (Europe/Amsterdam timezone). Thanks, Maarten On July 1st, 2020 at 09:17, Maarten Mulders wrote: > From our own testing as well as

Re: Welcome the new Maven committers: Maarten Mulders en Martin Kanters

2020-07-13 Thread Maarten Mulders
f Arnaud Héritier : > >> Welcome in the team! >> >> Le ven. 10 juil. 2020 à 21:13, Robert Scholte a >> écrit : >> >>> Hi, >>> >>> On behalf of the Apache Maven PMC I am pleased to announce that >>> Maarten Mulders en Martin Kanters h

Re: Automatic batch-mode activation in popular CI environments

2020-07-12 Thread Maarten Mulders
Although no formal standards, many cloud-based CI environments agreed upon setting CI=true, and I think also Jenkins does that. It might be a relatively simple way to detect most CI environments. The next question is what Maven should do with that information. I feel like informing the user is mor

Re: No git tags?

2020-07-10 Thread Maarten Mulders
Hi Gary, That repository contains meta-information about all Apache Maven version control repositories. Its README.md tells you how to use it using Google repo [1]. Alternatively, you can manually clone Apache Maven repositories. For Maven core, you would need [2]. Please be aware that a lot of M

  1   2   >