Since this message, I have seen one review (and approval). Thanks for that! If nothing more comes in, I'll assume approval and merge this Wednesday morning (Europe/Amsterdam timezone).
Thanks, Maarten On July 1st, 2020 at 09:17, Maarten Mulders wrote: > From our own testing as well as through JIRA we have received some > findings in this functionality: > > - Maven crashes when invoked outside a project (no pom.xml present). > This is now also covered in an integration test. > - Resolution of the resume.properties file didn't work properly. > This is now also covered in a unit test. > - The 'excluded projects' stored in the resume.properties file could > be an empty list, which would crash the mvn --resume invocation. > This is now also covered in a unit test. > - The resume feature will skip succeeded modules even if there is no > 'resume from' project. > This is now also covered in a unit and an integration test. > > We would appreciate any feedback on the second set of pull requests: > > - https://github.com/apache/maven/pull/363 > - https://github.com/apache/maven-integration-testing/pull/67 > > Thanks in advance, > > Maarten > > On 19/06/2020 11:42, Robert Scholte wrote: >> I've guided Maarten and Martin with their wok on solving MNG-5760 >> With it you can simply call mvn -r / --resume and it will start from the >> failing module, respecting multiple failed modules in a multithreaded build. >> >> To me these PRs are ready to be merged. >> >> thanks, >> Robert >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
