Re: [GitHub] maven-enforcer pull request: [MENFORCER-193]: Add new rule: Banned...

2014-05-30 Thread Karl Heinz Marbaise
Hi Simon, so after checking it i found the point... I have defined mirrorOf * as usual in case of using a repository manager...in my settings.xml which looks like the following: nexus * http://.../nexus/.. So with the above i can add as much repository entries in my setti

Re: Github pull requests for Maven Core

2014-05-30 Thread Michael Osipov
Am 2014-05-30 15:57, schrieb Jason van Zyl: I'm happy to look at pull requests but in the future can anyone making a pull request please squash your commits before making the pull request. Eventually I want to use Gerrit and create a mechanism where pull requests can be tested against the ITs

Re: Github pull requests for Maven Core

2014-05-30 Thread Jason van Zyl
On May 30, 2014, at 10:42 AM, Stephen Connolly wrote: > On 30 May 2014 14:57, Jason van Zyl wrote: > >> I'm happy to look at pull requests but in the future can anyone making a >> pull request please squash your commits before making the pull request. >> >> Eventually I want to use Gerrit an

Re: Github pull requests for Maven Core

2014-05-30 Thread Stephen Connolly
On 30 May 2014 14:57, Jason van Zyl wrote: > I'm happy to look at pull requests but in the future can anyone making a > pull request please squash your commits before making the pull request. > > Eventually I want to use Gerrit and create a mechanism where pull requests > can be tested against th

Re: Github pull requests for Maven Core

2014-05-30 Thread Michael-O
Am 2014-05-30 15:57, schrieb Jason van Zyl: I'm happy to look at pull requests but in the future can anyone making a pull request please squash your commits before making the pull request. Eventually I want to use Gerrit and create a mechanism where pull requests can be tested against the ITs

Github pull requests for Maven Core

2014-05-30 Thread Jason van Zyl
I'm happy to look at pull requests but in the future can anyone making a pull request please squash your commits before making the pull request. Eventually I want to use Gerrit and create a mechanism where pull requests can be tested against the ITs to make it easier for contributors to know the

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-05-30 Thread cstamas
Github user cstamas commented on the pull request: https://github.com/apache/maven/pull/18#issuecomment-44653198 Done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] maven pull request: [MNG-5640] Make sure participants are called a...

2014-05-30 Thread jvanzyl
Github user jvanzyl commented on the pull request: https://github.com/apache/maven/pull/18#issuecomment-44653025 Can you squash this please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] maven pull request: [MNG-5640] Change order to make sure participa...

2014-05-30 Thread cstamas
GitHub user cstamas opened a pull request: https://github.com/apache/maven/pull/18 [MNG-5640] Change order to make sure participants are called Even in case of failing build. As currently, in case of failed build (`session.getResult().hasExceptions()` return `true`), return statemen