On May 30, 2014, at 10:42 AM, Stephen Connolly <[email protected]> wrote:
> On 30 May 2014 14:57, Jason van Zyl <[email protected]> wrote: > >> I'm happy to look at pull requests but in the future can anyone making a >> pull request please squash your commits before making the pull request. >> >> Eventually I want to use Gerrit and create a mechanism where pull requests >> can be tested against the ITs to make it > > > Noooo not Gerrit. If they are pull requests in github then use github > tooling to interact with them. > I'm going to use whatever is most effective for me trying to work with someone else. If I'm going to try and teach new people about the core and have longer term dialogs over changes I will use whatever I think works best for the work at hand. For smaller things squashed pull-request are fine, for larger more significant changes I'm going to try Gerrit. I'm not forcing my workflow on you. > A pull request builder on our CI system will be sufficient (once I get the > build isolation plugin for Jenkins so that we don't risk drive-by hacking > of ASF hardware). Alternatively I am sure I could get my employers to > donate some build minutes on our hardware to do the pull request building > right now. > > >> easier for contributors to know they haven't broken anything. >> >> Thanks, >> >> Jason >> >> ---------------------------------------------------------- >> Jason van Zyl >> Founder, Apache Maven >> http://twitter.com/jvanzyl >> http://twitter.com/takari_io >> --------------------------------------------------------- >> >> We know what we are, but know not what we may be. >> >> -- Shakespeare >> >> >> >> >> >> >> >> >> >> Thanks, Jason ---------------------------------------------------------- Jason van Zyl Founder, Apache Maven http://twitter.com/jvanzyl http://twitter.com/takari_io --------------------------------------------------------- happiness is like a butterfly: the more you chase it, the more it will elude you, but if you turn your attention to other things, it will come and sit softly on your shoulder ... -- Thoreau
