Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-04-06 Thread Ralph Goers
usly lots wrong here. I’ll keep looking into this. Ralph > On Apr 6, 2021, at 4:16 PM, Ralph Goers wrote: > > I deleted the files from my local repo and restarted the build. It is running > along just fine - at least until it hits json template layout. > > Is there a reason you

Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-04-06 Thread Ralph Goers
test on GitHub. I’ve never seen the issue on Jenkins. Ralph > On Apr 6, 2021, at 4:49 PM, Ralph Goers wrote: > > There was one test I saw saying it couldn’t find the ListAppender. So I ran > that test with -X and -Dlog4j2.debug=true and got > > DEBUG StatusLogger Returnin

Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-04-07 Thread Ralph Goers
.idea directory), compile the sources via Maven, and open the folder >> in >>> IDEA, can you run *any* tests? If so, do you have any custom IDEA >>> configurations? Which IDEA version are you using? If you are not using >> the >>> wrapper, which Maven versio

Re: JsonTemplateLayout failures after Java 11 upgrade (Was: Running "master" tests in IntelliJ IDEA after Java 11 upgrade)

2021-04-07 Thread Ralph Goers
Source-JDK and X-Compile-Target-JDK manifestEntries in > pom.xml. I was expecting something like X-Compile-Release-JDK exposing > maven.compiler.release property. Isn't there such a thing? > > On Wed, Apr 7, 2021 at 7:29 AM Ralph Goers > wrote: > >> I have found the problem with th

Re: Garbage Free Precise Time

2021-04-07 Thread Ralph Goers
I have modified the test to allow -DusePreciseClock=true to be passed in. When I set it to true and run it in JDK 16 the test passes! However, I tried 3 versions of JDK 11 and it failed in all of them. Ralph > On Apr 2, 2021, at 2:54 PM, Ralph Goers wrote: > > I just tried adding

Re: Garbage Free Precise Time

2021-04-08 Thread Ralph Goers
I spoke too soon. It didn’t really pass on Java 16. The allocation instrumenter was unable to instrument anything so it didn’t generate the errors the test looks for. I tried with Java 12-14 and those all failed. In Java 15 the JVM crashed. Ralph > On Apr 7, 2021, at 11:36 PM, Ralph Go

Re: Please do not commit to log4j2 master - but review this PR.

2021-04-08 Thread Ralph Goers
e used by other modules. > > If it would simplify the build setup, why don't we migrate test-jars to > their individual Maven modules? For instance, log4j-core and > log4j-core-test, etc. > > On Tue, Apr 6, 2021 at 5:11 AM Ralph Goers > wrote: > >> >>

Log4j core

2021-04-13 Thread Ralph Goers
I started doing the work to modularize log4j-core last night. We have a blocker in that the disruptor has not had a release in 3 years. They committed the change to make it an automatic module over a year ago and since have fully modularized it. They simply haven’t performed a release. As I was

Re: Log4j core

2021-04-13 Thread Ralph Goers
h that it only supports programmatic configuration and > properties files since every other format requires additional modules > besides base. > > As for exports, that would likely depend on what’s left in core after > splitting out the above mentioned things. > > On Tue, Apr 13,

Re: Log4j core

2021-04-13 Thread Ralph Goers
That is what is concerning. A lot of those items have already been moved to their own modules in master. Yet we still have these dependencies. Ralph > On Apr 13, 2021, at 10:53 AM, Jochen Wiedmann > wrote: > > On Tue, Apr 13, 2021 at 5:44 PM Ralph Goers > wrote: >

Re: Log4j core

2021-04-13 Thread Ralph Goers
base. >> >> As for exports, that would likely depend on what’s left in core after >> splitting out the above mentioned things. >> >> On Tue, Apr 13, 2021 at 10:43 Ralph Goers >> wrote: >> >>> I started doing the work to modularize log4j-core

Re: Missing nanosecond precision in FastDateFormat

2021-04-16 Thread Ralph Goers
Something is definitely odd here. We use FastDateFormat in the DatePatternConverter that is used to print timestamps in the log. It most definitely displays milliseconds while yours are all 0. I don’t know that I have ever tried it with more than 3 though. Are you calling void formatToBuffer

Re: Missing nanosecond precision in FastDateFormat

2021-04-16 Thread Ralph Goers
timestampMillis); > formatResolverContext.timestampFormat.format( >formatResolverContext.calendar, >formatResolverContext.formattedTimestampBuilder); > > > On Fri, Apr 16, 2021 at 6:00 PM Ralph Goers > wrote: > >> Something is defi

Javac/Maven issues issues

2021-04-17 Thread Ralph Goers
I have created a module-info.java file and added it to the project. I then ran mvn clean install in log4j-core. I expected it to have problems but not these. 1. Activator.java is getting an error saying it can’t find the Log4jPlugins class. However, after the compile fails you can clearly see th

Re: Javac/Maven issues issues

2021-04-17 Thread Ralph Goers
Sorry, I should have added that I am sure I can work around the issues listed below but it is going to make the build uglier than it should be. Ralph > On Apr 17, 2021, at 3:56 PM, Ralph Goers wrote: > > I have created a module-info.java file and added it to the project. I then

Re: Garbage Free Precise Time

2021-04-20 Thread Ralph Goers
nges to > the modules config. > > Is there a JIRA ticket for this issue? > > On Thu, Apr 8, 2021 at 16:10 Ralph Goers wrote: > >> I spoke too soon. It didn’t really pass on Java 16. The allocation >> instrumenter was unable to instrument anything so it didn’t gene

Re: Javac/Maven issues issues

2021-04-22 Thread Ralph Goers
FYI - https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8265826 <https://bugs.java.com/bugdatabase/view_bug.do?bug_id=JDK-8265826> has been created. Ralph > On Apr 17, 2021, at 4:04 PM, Ralph Goers wrote: > > Sorry, I should have added that I am sure I can work ar

Re: Javac/Maven issues issues

2021-04-28 Thread Ralph Goers
e file paths but I haven’t figured out where the compiler is creating the symbols despite my trying under the debugger. I still believe I can get around this but the maven gymnastics to do it are going to be ugly. Ralph > On Apr 22, 2021, at 11:18 PM, Ralph Goers wrote: > &

Re: Fix windows build on master (via Tim Perry)

2021-04-28 Thread Ralph Goers
Tim, Go ahead and create a PR and note that it still has unit test failures that need to be looked into. I can’t guarantee one of us will get to it before you but at least that way we might be able to. Ralph > On Apr 28, 2021, at 7:55 AM, Tim Perry wrote: > > Volkan, > > I should probably w

Re: Fix windows build on master (via Tim Perry)

2021-04-28 Thread Ralph Goers
That would be up to you. If you have been working on the same branch there shouldn’t be a problem. But if it is going to cause merge conflicts then I wouldn’t bother as you can just link to the prior PR for the history. Ralph > On Apr 28, 2021, at 7:55 AM, Tim Perry wrote: > > > > It assume

Re: Chainsaw build

2021-04-29 Thread Ralph Goers
Yes, I agree it has been a long time. But I am not aware of anyone else who has performed a release. Who did it last time? Where does the DMG reside for download? In the ASF downloads folder? The current downloads folder doesn’t have them. Looking at the old release site in GitHub it looks like

Re: Quarterly project status updates - please check in

2021-05-01 Thread Ralph Goers
Not sure it is worth mentioning in the board report but I have been working on getting Log4j master to fully support JPMS without a lot of success. Ralph > On May 1, 2021, at 8:39 AM, Matt Sicker wrote: > > Hey all, it’s that time of year again! Please share a list of > accomplishments, kudos

Re: Quarterly project status updates - please check in

2021-05-01 Thread Ralph Goers
It does NOT require the boards attention. Ralph > On May 1, 2021, at 10:22 AM, Gary Gregory wrote: > > JPMS: Worth mentioning FTR as a growing pain but requiring board attention. > > Gary > > On Sat, May 1, 2021, 13:11 Ralph Goers wrote: > >> Not sure it is

Re: [DISCUSS][VOTE] Release log4cxx 0.12.0-RC2

2021-05-01 Thread Ralph Goers
Why? I have never referenced gitbox in any of the Log4j releases. As far as I am concerned https://github.com/apache is an ASF repo. Ralph > On May 1, 2021, at 2:11 PM, Gary Gregory wrote: > > FYI the repo of record should be an Apache repo, not a GitHub repo. > > Gary > > > On Sat, May 1

Re: Javac/Maven issues issues

2021-05-01 Thread Ralph Goers
ore interest from my day job about Java 11 since for us > Java everyone must include IBM hardware. > > Gary > > > On Wed, Apr 28, 2021, 03:14 Ralph Goers wrote: > >> I just thought I would update you that I have created >> https://github.com/rgoers/jpms-comp

Re: Log levels on a schedule

2021-05-03 Thread Ralph Goers
Almost, but not quite. It looks like the TimeFilter will completely disable logging during the interval. Ralph > On May 3, 2021, at 7:50 AM, Matt Sicker wrote: > > Might be able to use a time filter? > http://logging.apache.org/log4j/2.x/manual/filters.html#TimeFilter > > On Mon, May 3, 2021

Re: Log levels on a schedule

2021-05-03 Thread Ralph Goers
I don’t understand. The TimeFilter filters totally based on time. We would need to create a new TimeThresholdFilter. Ralph > On May 3, 2021, at 10:45 AM, Gary Gregory wrote: > > You're talking about a custom class? What about adding a defaultThreshold > to TimeFilter? Would that be reasonable?

Re: [VOTE] Announce EOL for Java 6 and Java 7

2021-05-06 Thread Ralph Goers
Yes. I thought I posted results. Ralph > On May 6, 2021, at 7:59 AM, Matt Sicker wrote: > > Is this vote finished, Ralph? > > On Mon, Mar 15, 2021 at 15:53 Remko Popma wrote: > >> We should at least retain the information of which older version of Log4j >> maps to which older version of Java

Re: [VOTE] Release log4cxx 0.12.0-RC2

2021-05-08 Thread Ralph Goers
+1 Ralph > On May 8, 2021, at 8:28 PM, Remko Popma wrote: > > +1 > > On Sun, May 9, 2021 at 12:21 PM Stephen Webb wrote: > >> +1 >> >> On Sun, May 9, 2021 at 1:13 PM Robert Middleton >> wrote: >> >>> As a reminder, this vote is still outstanding. >>> >>> -Robert Middleton >>> >>> On Tue

Large commit incoming

2021-05-13 Thread Ralph Goers
Just a word of warning that I will be pushing a large commit to master. This one makes log4j-core a JPMS compliant module. Ralph

Re: Large commit incoming

2021-05-13 Thread Ralph Goers
I should have added that I suspect this may require at least Maven 3.6.1. That is the version I have been using and haven’t tried it with older versions but Maven has been fixing quite a few JPMS issues so older versions might not work. Ralph > On May 13, 2021, at 11:14 AM, Ralph Goers wr

Re: Large commit incoming

2021-05-13 Thread Ralph Goers
analysis. Ralph > On May 13, 2021, at 11:39 AM, Carter Kozak wrote: > > Looking forward to it, thank you for the work, Ralph! > > -ck > >> On May 13, 2021, at 2:14 PM, Ralph Goers wrote: >> >> Just a word of warning that I will be pushing a large commit

Re: [VOTE] Release Apache Commons IO 2.9.0 based on RC1

2021-05-22 Thread Ralph Goers
I don’t think the Commons PMC would be too happy if the Logging PMC started voting on its releases. ;-) Ralph > On May 22, 2021, at 10:09 AM, Gary Gregory wrote: > > We have fixed a few bugs and added enhancements since Apache Commons IO > 2.8.0 was released, so I would like to release Apache

Re: [LOG4J2-2803] Getting back to the plugin system rewrite

2021-05-29 Thread Ralph Goers
We do need better docs on this. 3.0 is going to be a mixed bag. It will be easier for “normal” applications because plugins now use ServiceLoader instead of the Log4jPlugins.dat file. However, it is going to be more challenging for those developing plugins if they use the Java Platform Module

Re: [LOG4J2-2803] Getting back to the plugin system rewrite

2021-05-29 Thread Ralph Goers
at 5:40 PM, Ralph Goers wrote: > > We do need better docs on this. 3.0 is going to be a mixed bag. It will be > easier > for “normal” applications because plugins now use ServiceLoader instead of > the Log4jPlugins.dat file. However, it is going to be more challenging for >

Re: [VOTE] Release Apache Chainsaw 2.1.0

2021-06-02 Thread Ralph Goers
Unfortunately, without a source zip or gz there is no release to approve. Ralph > On Jun 1, 2021, at 6:58 PM, Robert Middleton wrote: > > This vote is to release Apache Chainsaw 2.1.0. This fixes a few > annoying issues with chainsaw and some other bugs, as well as updating > some dependencies

Re: [apache/logging-log4j2] Liquibase 4.x Compatibility (#503)

2021-06-03 Thread Ralph Goers
Yeah - I have proposed moving all these extra integrations to a separate repo but I’ve never gotten consensus. I’d prefer to have a project like log4j-pubsub where things like JMS, JeroMQ, etc can go live, log4j-nosql for all the nosql modules, etc. The problem seems to be that some people bel

Re: [LOG4J2-2803] Getting back to the plugin system rewrite

2021-06-05 Thread Ralph Goers
Lazy initialization of required beans > * Determine if and how bean managers should communicate (i.e., one > bean manager per LoggerContext, or one per LoggerContextFactory?) > * Refactor plugins to use new API > > On Sat, 29 May 2021 at 20:58, Ralph Goers wrote: >> >>

[DISCUSS] [VOTE] Release Apache Chainsaw 2.1.0

2021-06-05 Thread Ralph Goers
ve on the tag and > signing/hashing the file. Then commit those to the release candidate repo. > > On Wed, Jun 2, 2021 at 23:22 Ralph Goers wrote: > >> Unfortunately, without a source zip or gz there is no release to approve. >> >> Ralph >> >>>

Re: Running "master" tests in IntelliJ IDEA after Java 11 upgrade

2021-06-06 Thread Ralph Goers
olkan Yazıcı >> wrote: >> >>> I have also tried that too, but no luck so far. @Matt, are you able to run >>> any tests from IDEA using the most recent "master"? >>> >>> On Wed, Apr 7, 2021 at 5:57 PM Matt Sicker wrote: >>> >&g

Re: [CI][FAILURE] Logging/chainsaw/master#25 has potential issues

2021-06-09 Thread Ralph Goers
Another option. Perform the release build on your personal Mac. I’ve done that for every Log4j release. Ralph > On Jun 9, 2021, at 7:40 AM, Matt Sicker wrote: > > Another possibility is that PMCs can get a virtual machine allocated to > them. Perhaps we could request a macOS EC2 instance for o

Re: Breaking up modules into separate sub-projects

2021-06-10 Thread Ralph Goers
elease to 2022. This will probably break the backward compatibility at >> least for the artifact groupId, am I wrong? Not to mention that the entire >> website needs to be adapted to this multi-project setup too. Is there >> anything else? >> >> On Thu, Jun 3, 2021 at 5:

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Ralph Goers
;> >>>> *logging-log4j-spring* >>>> log4j-spring-boot >>>> log4j-spring-cloud-config >>>> >>>> Note that above breakdown contains every available module in master, >>> except >>>> log4j-samples, which has the follo

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Ralph Goers
single log4j train or multiple trains like how > Spring has multiple projects (probably too much overhead for us?). > > On Fri, 11 Jun 2021 at 10:44, Ralph Goers wrote: >> >> I agree with you there. Gary is correct that it would be difficult for users >> to >>

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Ralph Goers
ogging-log4j-osgi* >>>> log4j-osgi >>>> >>>> *logging-log4j-spring* >>>> log4j-spring-boot >>>> log4j-spring-cloud-config >>>> >>>> Note that above breakdown contains every available module in master, >>>

Re: Breaking up modules into separate sub-projects

2021-06-11 Thread Ralph Goers
t above breakdown contains every available module in master, >>> except log4j-samples, which has the following sub-modules: >>> >>> log4j-samples-loggerProperties (contains 2 very trivial example classes, >>> log4j-core [tests] contains more comprehensive a

Re: Breaking up modules into separate sub-projects

2021-06-13 Thread Ralph Goers
with your remarks about the website. > > Ralph, what do you mean by *"I like having both [Jenkins and GitHub > Actions] simply because we can get more coverage"*? In theory, their > coverages are identical. In my experience, having two separate CI pipelines > adds nothing b

Re: Bazel for builds

2021-06-16 Thread Ralph Goers
Actually, Maven has done a decent job of supporting modules for “standard” projects. Our issue is that we are creating a test jars in log4j-api, log4j-core, and log4j-plugins. These also need to comply with JPMS which means they can’t use the same package space as the module they are part of.

Re: Bazel for builds

2021-06-16 Thread Ralph Goers
> On Jun 16, 2021, at 8:29 AM, Matt Sicker wrote: > > I should note some possible benefits we could get from Bazel in theory: > > * Ability to offload builds/tests/etc. to remote build clusters. If > you've ever used things like distcc for compiling things across > multiple machines (handy fo

Re: [Chainsaw] JSON Support

2021-06-17 Thread Ralph Goers
You should look at one of the formats that JsonTemplateLayout supports out of the box. Ralph > On Jun 17, 2021, at 6:09 PM, Robert Middleton wrote: > > I'm looking into adding some more modern JSON support into Chainsaw > for processing log statements from applications, but I'm not sure what >

Re: Bazel for builds

2021-06-18 Thread Ralph Goers
> On Jun 18, 2021, at 8:05 AM, Jochen Wiedmann > wrote: > > On Wed, Jun 16, 2021 at 1:31 PM Volkan Yazıcı wrote: > >> In essence, the build is taking more than it should. Maven "verify" is >> taking more than half an hour and "site" is taking ages. This in addition >> to impeding the develo

Re: [Chainsaw] JSON Support

2021-06-18 Thread Ralph Goers
> On Jun 18, 2021, at 10:40 AM, Matt Sicker wrote: > > A couple other common log collection setups I've come across over time: > > * Logging to stdout/stderr in a standard format, then use a log > collection API from your orchestration engine (common in the > Kubernetes world to avoid logging

Re: Bazel for builds

2021-06-18 Thread Ralph Goers
> On Jun 18, 2021, at 2:19 PM, Jochen Wiedmann > wrote: > > On Fri, Jun 18, 2021 at 6:20 PM Ralph Goers > wrote: > >> 2. The configuration does “strange things” because Maven doesn’t support >> creating a >> JPMS module, JPMS test module, and

Re: Bazel for builds

2021-06-19 Thread Ralph Goers
> On Jun 19, 2021, at 3:45 AM, Volkan Yazıcı wrote: > > That README is such a gem Ralph! Thanks for documenting all that suffering. > (README says Log4j 2 supports JPMS, shouldn't it rather be Log4j 3?) No, I consider it Log4j 2 version 3.0. IOW, the 2 is just part of the name. I can see wh

Re: Bazel for builds

2021-06-19 Thread Ralph Goers
k this approach could potentially work, but we’d end up with > a few more published jars. > > On Sat, Jun 19, 2021 at 11:28 Ralph Goers > wrote: > >> >> >>> On Jun 19, 2021, at 3:45 AM, Volkan Yazıcı >> wrote: >>> >>> That README is

Re: Bazel for builds

2021-06-19 Thread Ralph Goers
template-json > log4j-plugins > > layout testJars are needed by perf. jdbc testJar is needed by jdbc-dbcp2. > We can work these both out and avoid them. There remains only 3 modules > that we need to create a -test module for: api, core, and plugins. > > > > On Sat,

Log4j master branch

2021-06-22 Thread Ralph Goers
I have asked on the Maven dev list about the process of building modules that contain test jars. It seems the recommended approach for test jars in general has changed and it is now recommended to build them in their own project. This means log4j-core would only contain the main source and tha

Re: Thoughts on Java 11 style guide updates?

2021-06-27 Thread Ralph Goers
I would suggest: a) Looking to see what, if anything, the latest version of Effective Java says. b) Looking for style guides from others that cover these newer versions of Java to see what they say. IOW, I don’t think we should adopt our own rules if they are not common practice. Ralph > On Ju

Re: Any plans to release log4j TCP server?

2021-06-29 Thread Ralph Goers
Right now the server is more or less a sample we expect you will want to copy and modify, so releasing it doesn’t have a lot of value. On the “Online Drinks” call this weekend I mentioned that I had been asked about being able to send logs from mobile devices to a backend collector securely (h

Re: Log4Go

2021-06-30 Thread Ralph Goers
ne, I am pretty sure there should be Go experts >> within the Apache community, hence having expert reviews should be >> relatively easy. Second, Apache has such a good track record in delivering >> high quality software, even an inferior project might get quite some >> attr

Re: Log4Go

2021-07-01 Thread Ralph Goers
outside world. For one, I am pretty sure there should be Go experts >>> within the Apache community, hence having expert reviews should be >>> relatively easy. Second, Apache has such a good track record in delivering >>> high quality software, even an inferior project mig

Re: Log4Go

2021-07-01 Thread Ralph Goers
that explains a bit more, what I'm proposing. > > Chris > > > > > On 30.06.21 23:45, Ralph Goers wrote: >> Well, I am on board with part of what you want. >> >> When I looked at various Go logging libraries most of them defined where the >> lo

Re: Custom Appenders not getting initialized for Log4j-2.14.1

2021-07-03 Thread Ralph Goers
Does the jar containing the BWLogFileAppender contain a Log4j2Plugins.data file under the META-INF directory? If not are you compiling your code with annotation processing enabled? Ralph > On Jul 1, 2021, at 11:29 PM, Nilay Prafulla Dhamecha > wrote: > > I am migrating the log4j library fr

Re: Any plans to release log4j TCP server?

2021-07-04 Thread Ralph Goers
>> Cheers >> -- >> Sent from my phone. Typos are a kind gift to anyone who happens to find >> them. >> >> On Tue, Jun 29, 2021, 20:46 Gary Gregory wrote: >> >>> FWIW, we use the server at work to listen to JSON log events. There is >>&

Re: Log4j master branch

2021-07-11 Thread Ralph Goers
ly significantly reduce the JPMS hazard we have >> in "master". Please take your time and go ahead with this. I am looking >> forward to the outcome. >> >> For the records, Ralph's post to Maven Developer List is available here: >> >> https:/

Re: Putting a ribbon onto 2.15.0

2021-07-29 Thread Ralph Goers
I’ve been on vacation - sort of - and very busy with work. I need to go through Jira issues and see if there is anything critical. I don’t recall seeing anything in the emails but I need to look again. I would expect 2.15.0 to be released in the second half of August. Ralph > On Jul 29, 2021,

Re: [general] Recommended event log storage?

2021-08-03 Thread Ralph Goers
We are doing the classic ELK stack. However, doing that isn’t straightforward. Log Forwarders seem to think that all log events should not have newlines in them. However, Java logs with stack traces usually do. You really need to log with a structured format like JSON to be able to get the searc

Re: [general] Recommended event log storage?

2021-08-04 Thread Ralph Goers
Actually, the major reason for the Flume Appender is for audit logging. It provides true guaranteed delivery. So once the appender returns your can be sure the event will eventually make it to its end destination. Ralph > On Aug 4, 2021, at 1:04 AM, Volkan Yazıcı wrote: > > We have our Redi

Re: Cek's new log4j vs logback benchmark

2021-08-20 Thread Ralph Goers
Feel free to respond to his tweet. Ralph > On Aug 20, 2021, at 7:15 AM, Carter Kozak wrote: > > Thanks for flagging this! I've responded to the tweet, copying it here as > well for posterity: > > Looking at the logback benchmark it appears that no bytes are being written > to target/test-ou

Re: Cek's new log4j vs logback benchmark

2021-08-20 Thread Ralph Goers
source shows that async logback > with one logging thread outperforms async log4j2 with 1 logging thread, > however log4j2 performs better with 20 threads. I still need to do a bit of > deeper investigation but will be busy with work for the next several hours. > > On Fri, Aug 20, 2021

Re: Cek's new log4j vs logback benchmark

2021-08-20 Thread Ralph Goers
java/ch/qos/logback/perf/AsyncWithFileAppenderBenchmark.java#L61> > > There’s some discussion on > https://gist.github.com/carterkozak/891ea382a12782b772571059d62d501a > <https://gist.github.com/carterkozak/891ea382a12782b772571059d62d501a> > > -ck > >> On Aug 20, 2021, at 8:04

Re: Cek's new log4j vs logback benchmark

2021-08-25 Thread Ralph Goers
Did you add the no-op appender to Ceki’s project? Or are you using our NullAppender? I have my doubts about using that NullAppender as it does nothing - not even render the Layout, so it may get completely optimized away. I’d still like to know what kind of disks Remko did his original testing

Re: Cek's new log4j vs logback benchmark

2021-08-26 Thread Ralph Goers
2021, at 10:00, Volkan Yazıcı wrote: >> Ralph, maybe a dumb idea but... Can't we simply write to /dev/null to avoid >> hardware's influence in the test results? >> >> On Wed, Aug 25, 2021 at 8:05 PM Ralph Goers >> wrote: >> >>> Did you

Re: Cek's new log4j vs logback benchmark

2021-08-26 Thread Ralph Goers
I’m not sure how soon into the > performance tests that would happen. > > Tim > > >> On Aug 26, 2021, at 10:55 AM, Ralph Goers wrote: >> >> So are you continuing to look at this? Frankly, the work on zero-gc stuff >> made this >> very complica

Re: Cek's new log4j vs logback benchmark

2021-08-27 Thread Ralph Goers
m, but I haven't been following updates from either project >>>> very closely lately, and Loom seems farther along. >>>> >>>> I think the issue with multiple buffers these days is that we have optane >>>> and nvme devices which can be _nea

Re: Cek's new log4j vs logback benchmark

2021-08-28 Thread Ralph Goers
ondFractionDigits to determine if we meed to compare > microseconds. > > On Fri, Aug 27, 2021, at 16:10, Remko Popma wrote: >> I remember looking at PatternLayout performance, I reported my findings >> here, hopefully they’re still useful: >> https://issues.apache.

Re: Cek's new log4j vs logback benchmark

2021-08-28 Thread Ralph Goers
tore it for later. >> During bursts of log events, this could significantly improve performance. >> The ringbuffer may even be very small, only depending on the requested >> resolution. >> >> Cheers >> Dominik >> -- >> Sent from my phone. Typos are a kin

Re: LOG4J2-2978 log4j-jakarta-web module Jakarta EE 9

2021-08-30 Thread Ralph Goers
I already looked at it. Other then needing to update our docs to refer to it I am good with it. We can’t get rid of log4j-web for a while unfortunately. Ralph > On Aug 30, 2021, at 2:21 PM, Volkan Yazıcı wrote: > > Jakarta EE 9 is out and the *javax* package name is renamed to *jakarta*. >

Re: [VOTE] Release Log4j Kotlin API 1.1.0 RC1

2021-09-11 Thread Ralph Goers
My +1 Ralph > On Sep 11, 2021, at 9:03 AM, Matt Sicker wrote: > > My +1. Still looking for a third vote. > > On Thu, Sep 2, 2021 at 11:42 PM Raman Gupta wrote: >> >> +1 >> >> >> On Sat, Aug 28, 2021 at 4:11 PM Matt Sicker wrote: >> >>> Hey everyone, we have a new release candidate for Lo

Json Template Layout event delimiter

2021-09-12 Thread Ralph Goers
I have been working on getting a configuration that works with filebeat going again and have been trying to change the line delimiter so I could avoid doing the multiline crap. I first configured eventDelimiter=“\f” since filebeat supports that as a replacement for newline. Except no matter h

Re: Json Template Layout event delimiter

2021-09-13 Thread Ralph Goers
t; `nullEventDelimiterEnabled` will simply translate to setting >> `eventDelimiter` to `\0`. This breaks the backward compatibility of >> `eventDelimiter`, since there might be users out there who set their >> `eventDelimiter` to `\t\r\n` and was expecting to get that string litera

Re: Json Template Layout event delimiter

2021-09-18 Thread Ralph Goers
problem since they are escaped. Ralph > On Sep 13, 2021, at 9:04 AM, Ralph Goers wrote: > > I just looked at the stack overflow post you referenced. Although the author > is explicitly > giving permission for everyone to use it everything at StackOverflow is > licensed as &g

Re: Cek's new log4j vs logback benchmark

2021-09-23 Thread Ralph Goers
I ran Ceki’s benchmarks against 2.14.1, 2.15.0-SNAPSHOT and Carter’s branch. I ran them with 16 threads on my MacBook Pro and ran each test twice since the tests show some variability from time to time. I can draw 2 conclusions from this. 1. The improvements Carter has made to 2.15.0 have alrea

Re: [VOTE] Release log4cxx 0.12.1

2021-09-28 Thread Ralph Goers
+1 Verified the signature and that the LICENSE AND NOTICE were present on the distribution artifacts. I did no testing. Ralph > On Sep 28, 2021, at 1:13 PM, Volkan Yazıcı wrote: > > +1 > > On Wed, Sep 22, 2021 at 2:37 AM Robert Middleton > wrote: > >> This is a vote to release log4cxx 0.1

Re: Cek's new log4j vs logback benchmark

2021-10-04 Thread Ralph Goers
versions after compact-strings >> was introduced are better >> off without direct encoders until the jdk can be improved using something >> like the linked PR. >> >> 1. https://github.com/openjdk/jdk/pull/5621#issuecomment-925413767 >> >> -ck >> >

Re: Continuous performance testing tooling

2021-10-04 Thread Ralph Goers
If they can be run in Jenkins or GitHub Actions then there is hardware available. However, we would have no idea what the hardware is the test is running on, although the test could probably find a way to figure it out. I don’t know of other tooling. Ralph > On Oct 4, 2021, at 12:22 AM, Volka

Re: Continuous performance testing tooling

2021-10-04 Thread Ralph Goers
Of course, running the benchmarks under Jenkins or as GitHub Actions would be almost useless since there would be no way to control what other workloads were running at the same time. Ralph > On Oct 4, 2021, at 12:39 AM, Ralph Goers wrote: > > If they can be run in Jenkins or GitHu

Re: Continuous performance testing tooling

2021-10-04 Thread Ralph Goers
agent (or > at least one where only a single perf test happens concurrently). Without a > dedicated agent, running the tests repeatedly might help smooth the noisy > neighbors. > > Matt Sicker > >> On Oct 4, 2021, at 02:48, Ralph Goers wrote: >> >> Of cours

JsonTemplateLayout exclusions

2021-10-11 Thread Ralph Goers
Volkan, I am currently including the ThreadContextMap in my JSON. I need to exclude some of the key/value pairs. How can I do that? Ralph

Re: maven-shaded-log4j-transformer

2021-10-15 Thread Ralph Goers
The ASF has automated creating new git repos. PMC members can do it on a simple web form. We just have to have consensus on what we want to do. Whatever we decide to do, you can either make the changes needed in your PR or it can be done after the fact. Although I like Volkan’s idea of using l

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-15 Thread Ralph Goers
I don’t really understand this. When I was migrating the web site from the ASF CMS to GitHub it was made clear that web site hosting using GitHub Pages wasn’t supported. I am not sure what the proposal here is. Ralph > On Oct 15, 2021, at 8:27 AM, Matt Sicker wrote: > > I’m not exactly sure

Re: maven-shaded-log4j-transformer

2021-10-15 Thread Ralph Goers
Yeah, that makes sense. It is less specific than just Maven plugins. Ralph > On Oct 15, 2021, at 9:51 AM, Gary Gregory wrote: > > I think Ralph started a tools repo which we should reuse for this component > IMO. > > Gary > > On Fri, Oct 15, 2021, 11:22 Matt Sicker wrote: > >> I’m in favor

Re: maven-shaded-log4j-transformer

2021-10-18 Thread Ralph Goers
While I am in favor of short names this might be too short. Having a single Maven plugin that does various different things isn’t the norm. I would suggest the name either be log4j-maven-shade-plugin or log4j-maven-transformer-plugin. Ralph > On Oct 18, 2021, at 8:22 AM, Volkan Yazıcı wrote: >

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Ralph Goers
ok pretty doable to me: > https://cwiki.apache.org/confluence/display/INFRA/GitHub+Pages > > On Fri, Oct 15, 2021 at 6:35 PM Ralph Goers > wrote: > >> I don’t really understand this. When I was migrating the web site from the >> ASF CMS to GitHub >> it was mad

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Ralph Goers
Why? Ralph > On Oct 18, 2021, at 8:40 AM, Volkan Yazıcı wrote: > > For the moment, I just want the `gh-pages` branch of the logging-log4j2 > GitHub project to be accessible at "a" URL – just like any other non-ASF > GitHub project. > > On Mon, Oct 18, 2021

Re: maven-shaded-log4j-transformer

2021-10-18 Thread Ralph Goers
down > those maven builds that using only the transformer or other light-weight > functionality. > > Therefore let's consider a risk that a single artifact might become a > burden. > > > Looking forward for your answer > > > -- > Best regards, >

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Ralph Goers
to > the main domain when it’s ready for release. This should all be controllable > via the .asf.yaml file. > > Matt Sicker > >> On Oct 18, 2021, at 12:32, Ralph Goers wrote: >> >> Why? >> >> Ralph >> >>> On Oct 18, 2021, at 8:40 A

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-18 Thread Ralph Goers
is to combine it with GH >>> pages. Since it’s storing generated markup in a git repo, it doesn’t matter >>> much which system it’s using besides whatever integration we already have >>> set up. >>> >>> Matt Sicker >>> >>>> On O

Re: Setting up gh-pages (Was: Continuous performance test bed using GitHub Actions)

2021-10-19 Thread Ralph Goers
oach would provide the following advantages: >> >> - Every repository will contain its own website. (I guess, we can all >> agree this is a good thing to have.) >> - CI (in particular, benchmark) scripts won't need to hack their way >> around multi-repo setups.

Re: Marker design issue

2021-10-19 Thread Ralph Goers
You are free to put dots in marker names, or any other character for that matter. Markers are created with MarkerManager. Every marker has a unique name and can only have one parent. So the way you have expressed the problem below is really incorrect. I really don’t like your example as most p

<    7   8   9   10   11   12   13   14   15   16   >