Tim, Go ahead and create a PR and note that it still has unit test failures that need to be looked into. I can’t guarantee one of us will get to it before you but at least that way we might be able to.
Ralph > On Apr 28, 2021, at 7:55 AM, Tim Perry <tim.v...@gmail.com> wrote: > > Volkan, > > I should probably withdraw that pull request. > > It assumes that the status logger is not a singleton. However, status logger > is a singleton and so this is a problem. > > I’ve implemented to changes which tracks the different status logger > listeners by the context name. There are still a couple of kinks to work out > on that though. If you want, I can push my changes to GitHub and you could > take a look at those. There is some problem that’s causing some of the test > to fail and I haven’t had time to figure out what the issue is. > > Tim > > > Tim Perry > (916) 505-3634 > >> On Apr 28, 2021, at 6:39 AM, Volkan Yazıcı <volkan.yaz...@gmail.com> wrote: >> >> Hello, >> >> Tim has submitted a PR to fix the Windows build on master >> <https://github.com/apache/logging-log4j2/pull/469> in February. In >> essence, it introduces prepareToStop() to StatusLogger. IIRC, there was a >> discussion regarding this subject in the mailing list. I think I have >> missed that. The PR looks good to me, though I'd appreciate some more >> context, which I've shared in my comments for the PR. >> >> I will appreciate it if somebody else who has more knowledge on >> StatusLogger can also skim through the changes. It is not much and should >> be straightforward for somebody who has hacked on StatusLogger recently. >> >> Cheers! >
