Re: Deprecating modules in 2.x

2023-09-12 Thread Ralph Goers
> On Sep 12, 2023, at 1:42 AM, Volkan Yazıcı wrote: > > Hey Piotr, > > [My answers are inline.] > > On Mon, Sep 11, 2023 at 1:10 PM Piotr P. Karwasz > wrote: > >> What about `kubernetes`, `docker` and `jpa`. Are these omissions >> intentional? >> > > They can indeed be gone too. In the c

Re: Deprecating modules in 2.x

2023-09-12 Thread Matt Sicker
For JPA, I’d imagine that the JDBC appenders are better suited. On the other hand, JDBC is still part of standard Java while JPA is technically an Eclipse thing now (Jakarta). On Sep 12, 2023, at 3:42 AM, Volkan Yazıcı wrote: Hey Piotr, [My answers are inline.] On Mon, Sep 11, 2023 at 1:10 P

Re: Deprecating modules in 2.x

2023-09-12 Thread Volkan Yazıcı
Hey Piotr, [My answers are inline.] On Mon, Sep 11, 2023 at 1:10 PM Piotr P. Karwasz wrote: > What about `kubernetes`, `docker` and `jpa`. Are these omissions > intentional? > They can indeed be gone too. In the context of `kubernetes` and `docker`, similar to Matt, my experience has always be

Re: Deprecating modules in 2.x

2023-09-11 Thread Ralph Goers
I wrote the Docker and Kubernetes stuff for anyone who wants to bypass writing to the console and still have the environment variables captured. Ralph > On Sep 11, 2023, at 9:40 AM, Matt Sicker wrote: > > The Kubernetes and Docker plugins are for additional lookup variables, though > based o

Re: Deprecating modules in 2.x

2023-09-11 Thread Matt Sicker
The Kubernetes and Docker plugins are for additional lookup variables, though based on how I’ve used Kubernetes at least (like via Kustomize, Helm, Spinnaker, and general YAML template tooling), I’ve relied mostly on binding anything relevant from the manifest into environment variables. > On S

Re: Deprecating modules in 2.x

2023-09-11 Thread Piotr P. Karwasz
Hi Volkan, On Mon, 11 Sept 2023 at 10:00, Volkan Yazıcı wrote: > > I would be in favor of deprecating the following modules in `2.x` and > dropping them starting from `3.0.0`: > >1. `log4j-jndi` (available only in `main`) – nobody should use JNDI >anyway >2. `log4j-layout-jackson*` –

Re: Deprecating modules in 2.x

2023-09-11 Thread Gary Gregory
We also use the CSV module (but only in some of our tests.) Gary On Mon, Sep 11, 2023 at 7:07 AM Gary Gregory wrote: > > FWIW, I need all JDBC modules. > > Gary > > On Mon, Sep 11, 2023 at 4:00 AM Volkan Yazıcı wrote: > > > > I would be in favor of deprecating the following modules in `2.x` and

Re: Deprecating modules in 2.x

2023-09-11 Thread Gary Gregory
FWIW, I need all JDBC modules. Gary On Mon, Sep 11, 2023 at 4:00 AM Volkan Yazıcı wrote: > > I would be in favor of deprecating the following modules in `2.x` and > dropping them starting from `3.0.0`: > >1. `log4j-jndi` (available only in `main`) – nobody should use JNDI >anyway >2.

Re: Deprecating modules in 2.x

2023-09-11 Thread Volkan Yazıcı
I would be in favor of deprecating the following modules in `2.x` and dropping them starting from `3.0.0`: 1. `log4j-jndi` (available only in `main`) – nobody should use JNDI anyway 2. `log4j-layout-jackson*` – `JsonTemplateLayout` succeeds `JsonLayout`, I doubt if anybody is using `Xm

Re: Deprecating modules in 2.x

2023-09-10 Thread Apache
Spring cloud config client is NOT part of Spring Boot 3. It adds a watcher for the config file. I never created a PR to add it to Sping Cloud Config. Ralph > On Sep 9, 2023, at 11:24 AM, Piotr P. Karwasz wrote: > > Hi Gary, > >> On Sat, 9 Sept 2023 at 18:07, Gary Gregory wrote: >> >> Pleas

Re: Deprecating modules in 2.x

2023-09-09 Thread Piotr P. Karwasz
Hi Gary, On Sat, 9 Sept 2023 at 18:07, Gary Gregory wrote: > > Please do not drop appserver, mongodb4, jdbc-dbcp2. What part of `appserver` are you using: Tomcat or Jetty 9.x? Should we keep Jetty 9.x support in 3.x (Jetty 10.x uses SLF4J and is not Jakartified). I like the way this is going, s

Re: Deprecating modules in 2.x

2023-09-09 Thread Gary Gregory
Please do not drop appserver, mongodb4, jdbc-dbcp2. Gary On Sat, Sep 9, 2023, 11:43 AM Piotr P. Karwasz wrote: > Hi Gary, > > On Sat, 9 Sept 2023 at 15:51, Gary Gregory wrote: > > > * raise the Java requirements in 3.x to Java 17. > > +1 fine w/ me. FWIW, my day job is migrating from Java 11 t

Re: Deprecating modules in 2.x

2023-09-09 Thread Piotr P. Karwasz
Hi Gary, On Sat, 9 Sept 2023 at 15:51, Gary Gregory wrote: > > * raise the Java requirements in 3.x to Java 17. > +1 fine w/ me. FWIW, my day job is migrating from Java 11 to 17 ATM. Nice to hear that. IIRC you were on Java 8 for a long time. > > * deprecate some modules in 2.x and drop them in

Re: Deprecating modules in 2.x

2023-09-09 Thread Apache
I agree with everything Gary says on this one. Furthermore, I still believe some of these should move to their own repo. Ralph > On Sep 9, 2023, at 6:51 AM, Gary Gregory wrote: > > Hi All. > >> * raise the Java requirements in 3.x to Java 17. > +1 fine w/ me. FWIW, my day job is migrating f

Re: Deprecating modules in 2.x

2023-09-09 Thread Gary Gregory
Hi All. > * raise the Java requirements in 3.x to Java 17. +1 fine w/ me. FWIW, my day job is migrating from Java 11 to 17 ATM. > * deprecate some modules in 2.x and drop them in 3.0.x, restore them if a > user requests it in 3.1.x. This feels arbitrary. First, we say 100k downloads, but then we