Re: Deleting log4j-layout-jackson* modules from master

2021-02-18 Thread Matt Sicker
Release-specific notices typically get added (or updated) to the announcement template: https://github.com/apache/logging-log4j2/blob/master/src/changes/announcement.vm On Thu, 18 Feb 2021 at 04:13, Volkan Yazıcı wrote: > > Ralph, I have started working on LOG4J2-3003, i.e., deletion of > log4j-l

Re: Deleting log4j-layout-jackson* modules from master

2021-02-18 Thread Volkan Yazıcı
Ralph, I have started working on LOG4J2-3003, i.e., deletion of log4j-layout-jackson* modules from master. You have mentioned about the deprecation notice. Shall we include that in the 2.14.1 release? How/Where shall I add that notice? On Wed, Dec 30, 2020 at 8:47 PM Ralph Goers wrote: > If we

Re: Deleting log4j-layout-jackson* modules from master

2020-12-30 Thread Ralph Goers
ype'. > [org.osgi:org.osgi.core:jar:6.0.0] > [ERROR] java.class.externalClassExposedInAPI: interface > org.osgi.framework.ServiceObjects: A class from supplementary archives > is used in a public capacity in the API. [org.osgi:org.osgi.core:jar:6.0.0] > [ERROR] java.annotation.added: int

Re: Deleting log4j-layout-jackson* modules from master

2020-12-30 Thread Gary Gregory
ersioning.ProviderType'. [org.osgi:org.osgi.core:jar:6.0.0] Gary > > Ralph > > - Original Message - > From: "ralph.goers @dslextreme.com" > To: dev@logging.apache.org > Sent: Wednesday, December 30, 2020 4:42:19 PM > Subject: Re: Deleting log4j-layout

Re: Deleting log4j-layout-jackson* modules from master

2020-12-30 Thread Ralph Goers
know if that is true with Lambdas. Ralph - Original Message - From: "ralph.goers @dslextreme.com" To: dev@logging.apache.org Sent: Wednesday, December 30, 2020 4:42:19 PM Subject: Re: Deleting log4j-layout-jackson* modules from master Changing package names would require every us

Re: Deleting log4j-layout-jackson* modules from master

2020-12-30 Thread Ralph Goers
Changing package names would require every user of the Log4j API to have to change their code. We are not going to do that to our users. That is one of the reasons folks have stuck with Log4j 1.x for so long. I would be -1 on any changes that require that. Ralph > On Dec 30, 2020, at 2:47 PM,

Re: Deleting log4j-layout-jackson* modules from master

2020-12-30 Thread Gary Gregory
Well. we should clean up our APIs now that we are on Java 8 and probably 11. For example, delete org.apache.logging.log4j.util.Supplier and use java.util.function.Supplier. Fold all interfaces and classes postfixed with "2" into their superclass. All of this will break BC which is what a major vers

Re: Deleting log4j-layout-jackson* modules from master

2020-12-30 Thread Ralph Goers
We would only need to do that if the versions are incompatible. Maven won’t let you have two versions of log4j-api or log4j-core. Ralph > On Dec 30, 2020, at 1:02 PM, Gary Gregory wrote: > > Another thing for 3.0 is when to change the package name so you can have > 2.x and 3.x in the same cla

Re: Deleting log4j-layout-jackson* modules from master

2020-12-30 Thread Volkan Yazıcı
Deprecation notice is indeed necessary. What needs to be done? Can I help there? Though this needs to be a team decision, right? All in all, count me in. On Wed, Dec 30, 2020 at 8:47 PM Ralph Goers wrote: > If we are going to deprecate them we need to announce that in the next > release. I kno

Re: Deleting log4j-layout-jackson* modules from master

2020-12-30 Thread Gary Gregory
Another thing for 3.0 is when to change the package name so you can have 2.x and 3.x in the same class loader without things blowing left and right. Just like you can have 1.x and 2.x at the same time. Gary On Wed, Dec 30, 2020, 14:47 Ralph Goers wrote: > If we are going to deprecate them we ne

Re: Deleting log4j-layout-jackson* modules from master

2020-12-30 Thread Ralph Goers
If we are going to deprecate them we need to announce that in the next release. I know JSONLayout is being used because we have people complain about it. If we do that we should have at least 6 months before 3.0 is released and 2.x and 3.0 are going to both be active for a while. Ralph > On

Re: Deleting log4j-layout-jackson* modules from master

2020-12-30 Thread Volkan Yazıcı
My motivation for dropping these modules are not merely due to the new JsonTemplateLayout, though rather reducing the maintenance burden. I "hypothesise" they are not used. For one, I cannot imagine a single use case for YAML layout. Second, AbstractJacksonLayout renders stack traces in a nested fa

Re: Deleting log4j-layout-jackson* modules from master

2020-12-30 Thread Ralph Goers
They already are in master. If you will notice Volkan is talking about removing those modules. Ralph > On Dec 30, 2020, at 7:54 AM, Matt Sicker wrote: > > I think the Jackson layouts could at least be separated from core, > especially since they require dependencies to function. > > On Tue, 2

Re: Deleting log4j-layout-jackson* modules from master

2020-12-30 Thread Matt Sicker
I think the Jackson layouts could at least be separated from core, especially since they require dependencies to function. On Tue, 29 Dec 2020 at 21:38, Ralph Goers wrote: > > Volkan, I am fine with deleting those modules however that would require that > you make sure that you replace the exist

Re: Deleting log4j-layout-jackson* modules from master

2020-12-29 Thread Ralph Goers
Volkan, I am fine with deleting those modules however that would require that you make sure that you replace the existing Layouts with ones that use JsonTemplateLayout templates, take the same configuration parameters and produce the same results. In other words, when people move from 2.x to 3.

Re: Deleting log4j-layout-jackson* modules from master

2020-12-29 Thread Gary Gregory
On Tue, Dec 29, 2020 at 4:52 PM Volkan Yazıcı wrote: > Hello, > > I propose deleting all the following 4 modules from master: > > log4j-layout-jackson > log4j-layout-jackson-json > log4j-layout-jackson-xml > log4j-layout-jackson-yaml > > The most (only?) used one, JsonLayout, is, IMHO, superseded

Deleting log4j-layout-jackson* modules from master

2020-12-29 Thread Volkan Yazıcı
Hello, I propose deleting all the following 4 modules from master: log4j-layout-jackson log4j-layout-jackson-json log4j-layout-jackson-xml log4j-layout-jackson-yaml The most (only?) used one, JsonLayout, is, IMHO, superseded by JsonTemplateLayout. The rest, I believe, is not even used. If we hap