Re: Release timeline for log4j 2.24.0?

2024-08-14 Thread Ralph Goers
Note that this uses a custom appender that saves only the last log event written. At the end of the test that record is written via System.println. As I recall, for the StringArrayThreadContextMap it prints “null”. Ralph > On Aug 14, 2024, at 4:45 PM, Ralph Goers wrote: > > Try this one > ht

Re: Release timeline for log4j 2.24.0?

2024-08-14 Thread Ralph Goers
Try this one https://github.com/apache/logging-log4j2/blob/2.25.x/log4j-perf-test/src/main/java/org/apache/logging/log4j/perf/jmh/ThreadContextVsScopedContextBenchmark.java Ralph > On Aug 14, 2024, at 7:23 AM, John Engebretson wrote: > > Ralph, I get a 404 on that link to your code, could you

Re: Open GitHub discussions for Log4j Scala and Kotlin

2024-08-14 Thread Matt Sicker
Can’t people submit patches via email still? Also, we have mailing lists for notifications and such that can’t realistically be folded in dev@ because of the immense traffic differences. > On Aug 14, 2024, at 08:17, Ralph Goers wrote: > > I thought gitbox was still an alternative to having to

Re: Open GitHub discussions for Log4j Scala and Kotlin

2024-08-14 Thread Gary Gregory
In fact, it's been broken for ages: when you click on a gitbox repo, it redirects to github! It should instead display its UI as it did in the past... Gary On Wed, Aug 14, 2024, 10:58 AM Gary Gregory wrote: > Gitbox is just a very thin UI on top of git, no PRs. > > Gary > > > > > On Wed, Aug 14

Re: Open GitHub discussions for Log4j Scala and Kotlin

2024-08-14 Thread Gary Gregory
Gitbox is just a very thin UI on top of git, no PRs. Gary On Wed, Aug 14, 2024, 9:19 AM Ralph Goers wrote: > I thought gitbox was still an alternative to having to use GitHub to > submit PRs. That said, it wouldn’t be for discussions, etc. > > Ralph > > > On Aug 14, 2024, at 3:31 AM, Gary Gr

Re: Release timeline for log4j 2.24.0?

2024-08-14 Thread John Engebretson
Ralph, I get a 404 on that link to your code, could you please verify the link is good? FWIW: - the unit test on StringArrayThreadContextMap thoroughly tests puts (verified by gets). I won't rule out a missed case, of course. - the JMH test on the underlying datastructure (UnmodifiableArrayBack

Re: Open GitHub discussions for Log4j Scala and Kotlin

2024-08-14 Thread Ralph Goers
I thought gitbox was still an alternative to having to use GitHub to submit PRs. That said, it wouldn’t be for discussions, etc. Ralph > On Aug 14, 2024, at 3:31 AM, Gary Gregory wrote: > > I think that to "deactivate" the mailing lists you refer to would be very > bad and might not even be al

Re: Open GitHub discussions for Log4j Scala and Kotlin

2024-08-14 Thread Gary Gregory
The issues you bring up are generic Apache issues or mail client issues. I think that if you want to change the traditional set up, you should check with ... infra? to see if nuking mailing lists is acceptable. FWIW, you can see threaded discussions just fine in Apache's Pony mail web UI. Gmail be

Re: Open GitHub discussions for Log4j Scala and Kotlin

2024-08-14 Thread Piotr P. Karwasz
Hi Gary, On Wed, 14 Aug 2024 at 12:34, Gary Gregory wrote: > I think that to "deactivate" the mailing lists you refer to would be very > bad and might not even be allowed by Apache. > > You cannot/shouldn't force people to create a GitHub (Microsoft) account > just to talk to us. Yes, that is an

Re: Unable to locate plugin type for Custom log4j2 Appender

2024-08-14 Thread Piotr P. Karwasz
Hi Volkan, [I am dropping `log4j-user@logging` from the recipients] On Wed, 14 Aug 2024 at 10:24, Volkan Yazıcı wrote: > On Tue, Aug 13, 2024 at 8:52 PM Piotr P. Karwasz > wrote: > > There is no special reason why `JsonTemplateLayout` does not support > > pretty print. It was simply never imple

Re: Open GitHub discussions for Log4j Scala and Kotlin

2024-08-14 Thread Gary Gregory
I think that to "deactivate" the mailing lists you refer to would be very bad and might not even be allowed by Apache. You cannot/shouldn't force people to create a GitHub (Microsoft) account just to talk to us. Odd as it sounds, I've had someone told me they would not submit a PR because they di

Re: Unable to locate plugin type for Custom log4j2 Appender

2024-08-14 Thread Volkan Yazıcı
Thanks for bringing this to our attention, Piotr. [See my comments inline below.] On Tue, Aug 13, 2024 at 8:52 PM Piotr P. Karwasz wrote: > There is no special reason why `JsonTemplateLayout` does not support > pretty print. It was simply never implemented. > See my response to Amanda

Re: Open GitHub discussions for Log4j Scala and Kotlin

2024-08-14 Thread Piotr P. Karwasz
Hi Gary, On Fri, 9 Aug 2024 at 12:15, Gary Gregory wrote: > While it is a different community, I have received negative feedback in > Commons against the trend to spread information all over the place, and we > don't use GitHub. > > The TLDR is that in the past it was easier to find information b

Re: Unable to locate plugin type for Custom log4j2 Appender

2024-08-14 Thread Volkan Yazıcı
Hello Amanda, See my comments inline below. On Tue, 6 Aug 2024 at 01:05, Amanda Liu wrote: > The reason I want a custom appender is to pretty print the JSON log > objects produced by JsonTemplateLayout, to make it more readable. Would you mind giving us a little bit more context, please? Why do