Ralph, I get a 404 on that link to your code, could you please verify the
link is good?

FWIW:
- the unit test on StringArrayThreadContextMap thoroughly tests puts
(verified by gets).  I won't rule out a missed case, of course.
- the JMH test on the underlying datastructure (UnmodifiableArrayBackedMap)
is attached at https://github.com/apache/logging-log4j2/issues/2319, as
well as a description of the performance characteristics.

  I'd love to hear more about any conflicting findings, and will dive in
once I get your code.
  Thanks!  :)
    John



On Tue, Aug 13, 2024 at 5:07 PM Ralph Goers <ralph.go...@dslextreme.com>
wrote:

> The benchmark code I used was
> https://github.com/apache/logging-log4j2/blob/feature/move-thread-context/log4j-perf-test/src/main/java/org/apache/logging/log4j/perf/jmh/ThreadContextVsScopedContextBenchmark.java
>
> Ralph
>
> > On Aug 13, 2024, at 3:00 PM, Ralph Goers <ralph.go...@dslextreme.com>
> wrote:
> >
> > Piotr, I am still concerned that you never looked into the issues I had
> with StringArrayThreadContextMap. My performance tests were showing that it
> was fast because it wasn’t actually setting values.
> >
> > Ralph
> >
> >> On Aug 13, 2024, at 12:43 PM, Piotr P. Karwasz <piotr.karw...@gmail.com>
> wrote:
> >>
> >> Hi John,
> >>
> >> On Tue, 13 Aug 2024 at 21:10, John Engebretson <jengebr...@gmail.com>
> wrote:
> >>> HI - just curious when the updated ThreadContextMap will be available?
> >>> The latest release is 2.23.1, over five months ago.
> >>
> >> We just finished a long series of documentation tasks that kept us
> >> occupied for the past since May[1].
> >>
> >> I will be able to concentrate on cutting this almost mythical 2.24.0
> >> release in the next few weeks.
> >>
> >> Piotr
> >>
> >> [1] https://github.com/apache/logging-log4j2/issues/2542
> >
>
>

Reply via email to