Any tests that rely on shared state that can’t be safely multithreaded
needs to be categorized as such. I thought I covered everything in API
already, but perhaps not.
On Wed, Mar 24, 2021 at 21:38 Ralph Goers
wrote:
> I believe Matt made the tests in the API run in parallel. I’ve often
> wonder
Haha!
putObject?
> On Mar 25, 2021, at 11:39, Ralph Goers wrote:
>
> I’m sure that will drive Gary nuts. Let’s call the new method “put2()”.
>
> Ralph
>
>> On Mar 24, 2021, at 5:18 PM, Remko Popma wrote:
>>
>> Instead of overloading the existing method(s), how about adding new methods
>>
I’m sure that will drive Gary nuts. Let’s call the new method “put2()”.
Ralph
> On Mar 24, 2021, at 5:18 PM, Remko Popma wrote:
>
> Instead of overloading the existing method(s), how about adding new methods
> with a slightly different name that takes Object parameters?
>
> On Thu, Mar 25, 20
I believe Matt made the tests in the API run in parallel. I’ve often wondered
about that since LogManager is creating contexts meant to be shared across
multiple threads. I have no idea how all that will behave in a multi-threaded
environment since most unit tests create and destroy LoggerContex
Instead of overloading the existing method(s), how about adding new methods
with a slightly different name that takes Object parameters?
On Thu, Mar 25, 2021 at 8:46 AM Carter Kozak wrote:
> The method argument type changes are an ABI break, but I recall extending
> MapMessage within a project i
The method argument type changes are an ABI break, but I recall extending
MapMessage within a project in order to support more expressive types -- that
may have relied on dangerously casting the result of getIndexedReadOnlyStringMap
to an IndexedStringMap.
Including a safer Object-valued MapMessage
I called it StringMap because the keys must be Strings. Admittedly not a
great name. :-)
Not sure exactly, but there may be cases where this change could cause an
issue:
putAll(final Map map) ->
putAll(final Map map)
On Thu, Mar 25, 2021 at 2:12 AM Ralph Goers
wrote:
> I looked the other day an
Wild guess: multi-threading issue? (That's my go-to boogeyman)
:-)
On Thu, Mar 25, 2021 at 6:03 AM Carter Kozak wrote:
> The flake appears to be resolved, just as mysteriously as it appeared.
>
> -Carter
>
> On Wed, Mar 24, 2021, at 10:28, Carter Kozak wrote:
> > Any ideas why org.apache.logging
On Wed, Mar 24, 2021 at 5:03 PM Carter Kozak wrote:
>
> The flake appears to be resolved, just as mysteriously as it appeared.
That, or you have special powers ;-)
G
>
> -Carter
>
> On Wed, Mar 24, 2021, at 10:28, Carter Kozak wrote:
> > Any ideas why org.apache.logging.log4j.EventLoggerTest.st
The flake appears to be resolved, just as mysteriously as it appeared.
-Carter
On Wed, Mar 24, 2021, at 10:28, Carter Kozak wrote:
> Any ideas why org.apache.logging.log4j.EventLoggerTest.structuredData would
> fail due to the following?
> > java.lang.NullPointerException
> > at
> > org.apa
Source compatibility versus binary compatibility. It's source
compatible, but not binary compatible. We could be more sure of this
if it's filed against release-2.x since that has all the apicmp
details.
On Wed, 24 Mar 2021 at 12:56, Gary Gregory wrote:
>
> I thought this had to do with limiting
I thought this had to do with limiting garbage retention?
On Wed, Mar 24, 2021, 03:39 Volkan Yazıcı wrote:
> Hello,
>
> Adding non-String-typed value support to MapMessage was also something on
> my radar too. But this PR replacing String with Object in two lines seems
> too good to be true to m
I looked the other day and wondered the same thing Volkan did. There are no
unit tests and the contributor didn’t even indicate that he had tried it.
I was initially concerned that the underlying Map wouldn’t support it since it
has StringMap in its name. It turns out the values are objects.
Pretty sure that would break binary compatibility since it removes the
String method. I think it might be addable but not removed like that.
On Wed, 24 Mar 2021 at 02:39, Volkan Yazıcı wrote:
>
> Hello,
>
> Adding non-String-typed value support to MapMessage was also something on
> my radar too.
Any ideas why org.apache.logging.log4j.EventLoggerTest.structuredData would
fail due to the following?
> java.lang.NullPointerException
> at
> org.apache.logging.log4j.EventLoggerTest.structuredData(EventLoggerTest.java:42)
I haven't been able to reproduce this failure locally, but it appea
Hello,
Adding non-String-typed value support to MapMessage was also something on
my radar too. But this PR replacing String with Object in two lines seems
too good to be true to me. Does anybody mind taking a second look at this,
please?
Kind regards.
-- Forwarded message -
From:
16 matches
Mail list logo
