Source compatibility versus binary compatibility. It's source compatible, but not binary compatible. We could be more sure of this if it's filed against release-2.x since that has all the apicmp details.
On Wed, 24 Mar 2021 at 12:56, Gary Gregory <garydgreg...@gmail.com> wrote: > > I thought this had to do with limiting garbage retention? > > On Wed, Mar 24, 2021, 03:39 Volkan Yazıcı <volkan.yaz...@gmail.com> wrote: > > > Hello, > > > > Adding non-String-typed value support to MapMessage was also something on > > my radar too. But this PR replacing String with Object in two lines seems > > too good to be true to me. Does anybody mind taking a second look at this, > > please? > > > > Kind regards. > > > > ---------- Forwarded message --------- > > From: Henry Widd <notificati...@github.com> > > Date: Tue, Mar 23, 2021 at 4:58 PM > > Subject: [apache/logging-log4j2] MapMessage put methods should not mandate > > String values (#477) > > To: apache/logging-log4j2 <logging-log...@noreply.github.com> > > Cc: Subscribed <subscri...@noreply.github.com> > > > > > > the underlying Map is typed <String,Object> so the put methods on > > MapMessage can also be. > > ------------------------------ > > You can view, comment on, or merge this pull request online at: > > > > https://github.com/apache/logging-log4j2/pull/477 > > Commit Summary > > > > - MapMessage put methods should not mandate String values > > > > File Changes > > > > - *M* > > log4j-api/src/main/java/org/apache/logging/log4j/message/MapMessage.java > > < > > https://github.com/apache/logging-log4j2/pull/477/files#diff-f03ffe9ceefd37c87fd118ce591bd8ad288e43b08cd663dde14441f4e7c117ef > > > > > (6) > > > > Patch Links: > > > > - https://github.com/apache/logging-log4j2/pull/477.patch > > - https://github.com/apache/logging-log4j2/pull/477.diff > > > > — > > You are receiving this because you are subscribed to this thread. > > Reply to this email directly, view it on GitHub > > <https://github.com/apache/logging-log4j2/pull/477>, or unsubscribe > > < > > https://github.com/notifications/unsubscribe-auth/AAARTSKGBRHC4NG637EHA4LTFC3BTANCNFSM4ZVO7L2Q > > > > > . > >
