Re: What is going on with Master?

This is a very good observation. When the status logger was implemented it targeted System.out, which you obviously never want to close. Shortly there after the ability to route it to a file instead was added. I guess we just never thought to add logic to close it at shutdown. Ralph > On Feb 1

Re: What is going on with Master?

> My guess is that the default file locking level is different > between JVM's or OS's. My understanding with Windows is that when you open a file, you have exclusive access by default. If you try to delete a file that another application has open(or possibly even your application?), you'll get a

Re: What is going on with Master?

It looks to me like LoggerContext.stop(...) closes the file 'test.log'. However, I can't find anything closing 'status.log'. They are configured in the same XML file: log4j-filetest.xml target/test.log ... I modified the @Test from FileOutputTe

Re: Removing GelfLayout

I believe we also have a backlog item about creating a sort of "fast by default" or similar mode that allows users to opt-in to a sort of "updated best practices" options for defaults. This would allow configuration files to continue working while allowing new config files to take advantage of simp

Re: Removing GelfLayout

I agree with Ralph's comments here. As a developer shipping an application, it's not clear how all my consumers have configured logging. I can upgrade jars, but I wouldn't want to make a change that breaks some percentage of my customers logging configurations. The cost of continuing to provide

Re: Removing GelfLayout

FYI, at my day job, one major hurdle to updating one of our projects to Log4j 2 are configuration files. This task is in progress. The less pain, the better. In our case, our tooling is responsible for programmatically updating these files. I do NOT want to have to sell this task AGAIN for updating

Re: Deleting log4j-layout-jackson* modules from master

Release-specific notices typically get added (or updated) to the announcement template: https://github.com/apache/logging-log4j2/blob/master/src/changes/announcement.vm On Thu, 18 Feb 2021 at 04:13, Volkan Yazıcı wrote: > > Ralph, I have started working on LOG4J2-3003, i.e., deletion of > log4j-l

Re: Removing GelfLayout

Sorry, the one thing I have learned in the slow migration we have seen of people moving from Log4j 1 to Log4j 2 is that changing logging configuration files is difficult for many users while changing a jar version is not. We have had many customers complain that upgrading was very hard because t

Re: What is going on with Master?

The gist of what I recall the problem being was that sometimes, a file might still be in use asynchronously for various appenders (e.g., during rolling, compression, etc.), so the shutdown and removal of temporary files needs to signal that the configuration needs to shut down. It looks like you ma

Re: Removing GelfLayout

I don't have the benchmark report anymore in json-template-layout-adoc.vm, but the benchmark is still there: JsonTemplateLayoutBenchmark. The last time I have benchmarked it, JsonTemplateLayout was on par with GelfLayout for "lite" (i.e., no stack trace, mdc, ndc) log events and significantly faste

Re: Removing GelfLayout

You would have to prove to me that GelfLayout is slower than JsonLayout. That would be hard for me to believe since the GelfLayout is manually constructing the JSON. Also, You cannot remove any of the GelfLayout or any of the JsonLayouts. You will need to replace them with logic that invokes t

Removing GelfLayout

As the title suggests, in accordance with the aim of reducing the maintenance burden, I want to propose removal of the GelfLayout from master, not release-2.x! Currently, JsonTemplateLayout already ships a template producing exactly the same output as GelfLayout; see GelfLayout.json template and Ge

Review Request: LOG4J2-3003 Remove JSON, XML, and YAML layouts

Yes, I have done it. Removed all Jackson-based layouts from master – as we agreed so. Would anybody mind reviewing GitHub PR #467 , please? Note that, 1) No migration guides are added, yet. 2) All relevant code is deleted. 3) Tests and docs using

Re: Deleting log4j-layout-jackson* modules from master

Ralph, I have started working on LOG4J2-3003, i.e., deletion of log4j-layout-jackson* modules from master. You have mentioned about the deprecation notice. Shall we include that in the 2.14.1 release? How/Where shall I add that notice? On Wed, Dec 30, 2020 at 8:47 PM Ralph Goers wrote: > If we