Re: Test failures in log4j-taglib

2017-10-19 Thread Matt Sicker
On 19 October 2017 at 15:00, Mikael Ståldal wrote: > That's causing the issue, when I changed it to 3.0.1 the test pass. Is > there any particular reason for keeping this at version 2.5? I don't know any specific reason to stick with the old dependency; Nick wrote most of the servlet-related in

Re: Testing log4j-mongodb

2017-10-19 Thread Matt Sicker
As for CouchDB, if we can embed it in an integration test, I think that would be good enough. On 19 October 2017 at 19:17, Gary Gregory wrote: > Hi All: > > In order to do integration tests with MongoDB, we should depend on and use: > > > de.flapdoodle.embed > de.flapdoodle.embe

Re: No more log4j-nosql

2017-10-19 Thread Matt Sicker
WRT to Cassandra, the best I can do is that integration test I added with the plugin. My Cassandra cluster at $job is pretty restricted since improper usage of said cluster could bankrupt the business in theory. On 19 October 2017 at 19:29, Gary Gregory wrote: > WRT MongoDB, please see my other

Re: Revisiting the binary logging format idea

2017-10-19 Thread Matt Sicker
On 19 October 2017 at 14:05, Mikael Ståldal wrote: > And don't forget a corresponding LogEventParser. Right. The basic idea here would be to provide both a reference encoder and decoder. If an existing binary format such as BSON, Avro, or Thrift were appropriate, then there wouldn't be much nee

Re: No more log4j-nosql

2017-10-19 Thread Gary Gregory
WRT MongoDB, please see my other email "Testing log4j-mongodb". Thank you, Gary On Thu, Oct 19, 2017 at 2:02 PM, Mikael Ståldal wrote: > If someone has a running MongoDB, CouchDB or Cassandra handy, some manual > testing would be good. > > Especially for MongoDB and CouchDB since we don't have

Testing log4j-mongodb

2017-10-19 Thread Gary Gregory
Hi All: In order to do integration tests with MongoDB, we should depend on and use: de.flapdoodle.embed de.flapdoodle.embed.mongo 2.0.0 test This is what I did at work and it works like a charm. Gary

Re: Test failures in log4j-taglib

2017-10-19 Thread Ralph Goers
I am wondering why this is suddenly failing. Was it changed recently? Ralph > On Oct 19, 2017, at 1:00 PM, Mikael Ståldal wrote: > > The missing class, javax.servlet.SessionCookieConfig is new in Servlet API > 3.x. In log4j-taglib pom, we have this dependency: > > >javax.servlet

Re: No more log4j-nosql

2017-10-19 Thread Mikael Ståldal
If someone has a running MongoDB, CouchDB or Cassandra handy, some manual testing would be good. Especially for MongoDB and CouchDB since we don't have any unit tests. There are some ignored integration tests for MongoDB. On 2017-10-19 21:52, Mikael Ståldal wrote: I have now done https://is

Re: Test failures in log4j-taglib

2017-10-19 Thread Mikael Ståldal
The missing class, javax.servlet.SessionCookieConfig is new in Servlet API 3.x. In log4j-taglib pom, we have this dependency: javax.servlet servlet-api 2.5 provided That's causing the issue, when I changed it to 3.0.1 the test pass. Is there any pa

No more log4j-nosql

2017-10-19 Thread Mikael Ståldal
I have now done https://issues.apache.org/jira/browse/LOG4J2-2076 splitting up log4j-nosql into its three parts. We should mention in release notes in next release that those who use log4j-nosql need to change dependency to one (or more) of log4j-couchdb, log4j-mongodb or log4j-cassandra instea

Re: Test failures in log4j-taglib

2017-10-19 Thread Ralph Goers
I’m not sure why that would be. AFAIK that hasn’t been modified in a long time. Ralph > On Oct 19, 2017, at 12:15 PM, Mikael Ståldal wrote: > > I get a bunch of these errors in log4j-taglib when trying to build current > master branch locally: > > [ERROR] Errors: > [ERROR] CatchingTagTest.s

Test failures in log4j-taglib

2017-10-19 Thread Mikael Ståldal
I get a bunch of these errors in log4j-taglib when trying to build current master branch locally: [ERROR] Errors: [ERROR] CatchingTagTest.setUp:48 » NoClassDefFound javax/servlet/SessionCookieConfig [ERROR] CatchingTagTest.setUp:48 » NoClassDefFound javax/servlet/SessionCookieConfig [ERROR

Re: Revisiting the binary logging format idea

2017-10-19 Thread Mikael Ståldal
And don't forget a corresponding LogEventParser. On 2017-10-19 18:56, Remko Popma wrote: I agree with Gary: this is just another Layout. Should not need another repo... Prototyping on another branch makes sense. On Fri, Oct 20, 2017 at 1:23 AM, Gary Gregory wrote: Bleh, ANOTHER repo? We hav

Re: Revisiting the binary logging format idea

2017-10-19 Thread Matt Sicker
The idea behind this isn't specific to log4j, hence why I suggested a repo. Although if none of the projects outside log4j want to use it, then it could simply be a module in log4j or part of log4j-core. On 19 October 2017 at 12:09, Ralph Goers wrote: > Core isn’t a multi-module project so I don

Re: Revisiting the binary logging format idea

2017-10-19 Thread Ralph Goers
Core isn’t a multi-module project so I don’t know how you can have a new module in it. That said, I’m fine with a new module for BSON. Ralph > On Oct 19, 2017, at 10:07 AM, Gary Gregory wrote: > > Related: I was thinking of creating a new _module_ in core called > log4j-bson to provide a BSON

Re: Revisiting the binary logging format idea

2017-10-19 Thread Gary Gregory
Related: I was thinking of creating a new _module_ in core called log4j-bson to provide a BSON Layout. This would be a separate module to only drag in the BSON library when needed. Part of the breaking up Core epic. Gary On Thu, Oct 19, 2017 at 10:56 AM, Remko Popma wrote: > I agree with Gary:

Re: Revisiting the binary logging format idea

2017-10-19 Thread Remko Popma
I agree with Gary: this is just another Layout. Should not need another repo... Prototyping on another branch makes sense. On Fri, Oct 20, 2017 at 1:23 AM, Gary Gregory wrote: > Bleh, ANOTHER repo? We have so many already... but I see what the big > picture is. Would this add a new layout in Cor

Re: Revisiting the binary logging format idea

2017-10-19 Thread Gary Gregory
Bleh, ANOTHER repo? We have so many already... but I see what the big picture is. Would this add a new layout in Core? Maybe we should just start with that... then grow... Gary On Thu, Oct 19, 2017 at 9:57 AM, Matt Sicker wrote: > I mean in the logging services project. So it'd be a new repo. >

Re: Revisiting the binary logging format idea

2017-10-19 Thread Matt Sicker
I mean in the logging services project. So it'd be a new repo. On 19 October 2017 at 10:48, Ralph Goers wrote: > When you say “another component in the project” do you mean logging > services project or log4j? I’d prefer to see you do this in a separate repo > or at least a branch until we under

Re: Revisiting the binary logging format idea

2017-10-19 Thread Ralph Goers
When you say “another component in the project” do you mean logging services project or log4j? I’d prefer to see you do this in a separate repo or at least a branch until we understand what it looks like. If it is going to apply to many things it probably makes sense to be a separate repo. Ralp

Re: Revisiting the binary logging format idea

2017-10-19 Thread Matt Sicker
For generic structured records, I'd probably go with Avro or Thrift since LogEvents have a lot of standard fields with only a few optional map-like structures. For optimized log appending, the binary format was proposed as a way to append quickly and without garbage IIRC. On 19 October 2017 at 10:

Re: Revisiting the binary logging format idea

2017-10-19 Thread Gary Gregory
What about BSON? Gary On Oct 19, 2017 08:41, "Matt Sicker" wrote: > I don't have the ticket on hand, but a few months ago, Remko suggested a > binary logging format that would allow for super fast appends of > log-specific information along with companion files for additional metadata > not com

Revisiting the binary logging format idea

2017-10-19 Thread Matt Sicker
I don't have the ticket on hand, but a few months ago, Remko suggested a binary logging format that would allow for super fast appends of log-specific information along with companion files for additional metadata not commonly used in log messages. I've been thinking about this idea a bit in relati