[GitHub] geode pull request #490: Feature/geode 2852

2017-05-03 Thread ladyVader
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/490 Feature/geode 2852 GEODE-2852: Enforce lucene waitUntilFlushed timeout for all buckets * Since we are now batching waitUntilFlushed threads, do not submit more WaitUntilFlushed Callables

[GitHub] geode pull request #490: Feature/geode 2852

2017-05-04 Thread ladyVader
Github user ladyVader closed the pull request at: https://github.com/apache/geode/pull/490 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

2017-05-09 Thread ladyVader
Github user ladyVader commented on a diff in the pull request: https://github.com/apache/geode/pull/503#discussion_r115626998 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneResultStruct.java --- @@ -39,6 +41,8 @@ * Return score the score of the

[GitHub] geode pull request #503: GEODE-2907: Removed @Experimental tag from the Luce...

2017-05-09 Thread ladyVader
Github user ladyVader commented on a diff in the pull request: https://github.com/apache/geode/pull/503#discussion_r115627251 --- Diff: geode-lucene/src/main/java/org/apache/geode/cache/lucene/LuceneIndex.java --- @@ -19,39 +19,62 @@ import

[GitHub] geode pull request #552: GEODE-3013: Reduce log level for FunctionInvocation...

2017-05-31 Thread ladyVader
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/552 GEODE-3013: Reduce log level for FunctionInvocationTargetException GEODE-3013: Reduce log level for FunctionInvocationTargetExceptions - Modified to display at debug vs. warning level

[GitHub] geode pull request #552: GEODE-3013: Reduce log level for FunctionInvocation...

2017-05-31 Thread ladyVader
Github user ladyVader closed the pull request at: https://github.com/apache/geode/pull/552 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #552: GEODE-3013: Reduce log level for FunctionInvocationTargetE...

2017-05-31 Thread ladyVader
Github user ladyVader commented on the issue: https://github.com/apache/geode/pull/552 Actually, with this change, I'm still seeing these log messages in testing, so retracting this pull request. --- If your project is set up for it, you can reply to this email and have your

[GitHub] geode issue #622: GEODE-1731: Modifying region size check to be more accurat...

2017-07-10 Thread ladyVader
Github user ladyVader commented on the issue: https://github.com/apache/geode/pull/622 Looks good! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] geode pull request #645: GEODE-3113: Modify HARegionQueue test to use Awaiti...

2017-07-19 Thread ladyVader
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/645 GEODE-3113: Modify HARegionQueue test to use Awaitility vs. timeouts * Modify test to use Awaitility (at most 60 seconds) vs. sleeps prior to checking expiration @upthewaterspout

[GitHub] geode pull request #659: GEODE-3308: Lucene rolling upgrade and backwards co...

2017-07-26 Thread ladyVader
Github user ladyVader commented on a diff in the pull request: https://github.com/apache/geode/pull/659#discussion_r129672503 --- Diff: geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneSearchWithRollingUpgradeDUnit.java --- @@ -0,0 +1,1044

[GitHub] geode pull request #669: GEODE-2226: SessionReplicationIntegrationTests do n...

2017-07-31 Thread ladyVader
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/669 GEODE-2226: SessionReplicationIntegrationTests do not run on Windows * Disable SessionReplicationIntegrationTests on Windows @nabarunnag, @jhuynh1 Thank you for submitting a

[GitHub] geode pull request #744: GEODE-3522: create via load needs to add event to A...

2017-08-25 Thread ladyVader
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/744 GEODE-3522: create via load needs to add event to AEQ under same lock… … as update to local region * create via load was invoking handleWANEvent prior to obtaining a lock, which

[GitHub] geode pull request #411: GEODE-2589, GEODE-2590 lucene index region attribut...

2017-03-03 Thread ladyVader
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/411 GEODE-2589, GEODE-2590 lucene index region attributes should be based… lucene index region attributes should reflect those on data region - lucene index region now inherits recoveryDelay

[GitHub] geode pull request #448: GEODE-2745: WaitUntilBucketRegionQueueFlushedCallab...

2017-04-11 Thread ladyVader
GitHub user ladyVader opened a pull request: https://github.com/apache/geode/pull/448 GEODE-2745: WaitUntilBucketRegionQueueFlushedCallable gets BucketRegi… GEODE-2745: waitUntilFlushed method waits longer than it should - Added getter in BucketRegionQueue for

[GitHub] geode pull request #448: GEODE-2745: WaitUntilBucketRegionQueueFlushedCallab...

2017-04-11 Thread ladyVader
Github user ladyVader commented on a diff in the pull request: https://github.com/apache/geode/pull/448#discussion_r111012023 --- Diff: geode-core/src/main/java/org/apache/geode/internal/cache/BucketRegionQueue.java --- @@ -464,16 +464,21 @@ private void setLatestAcknowledgedKey

[GitHub] geode pull request #448: GEODE-2745: WaitUntilBucketRegionQueueFlushedCallab...

2017-04-12 Thread ladyVader
Github user ladyVader closed the pull request at: https://github.com/apache/geode/pull/448 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is