GitHub user gregt5259 opened a pull request:
https://github.com/apache/geode-native/pull/105
GEODE-2891 connect-timeout violation in C++ Native Client
THe fix enables to interpret the time measure unit in handshake as
milliseconds rather than seconds.
You can merge this pull
Github user gregt5259 commented on the issue:
https://github.com/apache/geode-native/pull/105
I suggest to fix the issue by defining handshake pseudo message within the
range probably defined for such pseudo messages by original design i.e.:
typedef enum {
/* Server
GitHub user gregt5259 opened a pull request:
https://github.com/apache/geode-native/pull/106
GEODE-2891 connect-timeout violation in C++ Native Client
Pseudo message ID is added to recognize handshake message and use the
correct time unit depending on the appropriate configuration
Github user gregt5259 commented on the issue:
https://github.com/apache/geode-native/pull/106
Did I understood correct that there are no issues found during the code
review in the reviewed code? Probably the decision regarding the accepting of
the pull request doesnât depend in
Github user gregt5259 commented on the issue:
https://github.com/apache/geode-native/pull/106
In my mind we talk about the some kind of redesign rather than about
correct change: the original design is based de-facto exactly on using âmagic
numbersâ; configurable measurements
Github user gregt5259 closed the pull request at:
https://github.com/apache/geode-native/pull/105
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user gregt5259 commented on the issue:
https://github.com/apache/geode-native/pull/105
Closed by Ernie Burghardt request as duplicated #106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user gregt5259 closed the pull request at:
https://github.com/apache/geode-native/pull/106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user gregt5259 commented on the issue:
https://github.com/apache/geode-native/pull/106
Pull request is closed after passing of all checks and marked as resolved
in Jira GEODE-2891 with resolution "Won't fix" as following:
GEODE-2891 - connect-timeout violatio
