Github user gregt5259 commented on the issue:
https://github.com/apache/geode-native/pull/106
Did I understood correct that there are no issues found during the code
review in the reviewed code? Probably the decision regarding the accepting of
the pull request doesnât depend in this case on the code quality but should
depend on ETA for GEODE-3136<https://issues.apache.org/jira/browse/GEODE-3136>
and GEODE-3137<https://issues.apache.org/jira/browse/GEODE-3136>, on the
appropriate next client version deployment readiness et cetera. If these dates
will be published, that will assist us within the company to take decision
whether we may wait for this client version or will require to accept the pull
request even as the temporary fix.
Thanks,
Dr. Gregory Turovets
From: Jacob Barrett [mailto:notificati...@github.com]
Sent: Wednesday, July 05, 2017 17:41
To: apache/geode-native <geode-nat...@noreply.github.com>
Cc: Gregory Turovets <gregory.turov...@amdocs.com>; Author
<aut...@noreply.github.com>
Subject: Re: [apache/geode-native] GEODE-2891 connect-timeout violation in
C++ Native Client (#106)
@pivotal-jbarrett requested changes on this pull request.
I am not in favor of accepting this pull request on the heals of correcting
all timeouts via GEODE-3136<https://issues.apache.org/jira/browse/GEODE-3136>
and GEODE-3137<https://issues.apache.org/jira/browse/GEODE-3136> as mentioned
in pull #105<https://github.com/apache/geode-native/pull/105>.
â
You are receiving this because you authored the thread.
Reply to this email directly, view it on
GitHub<https://github.com/apache/geode-native/pull/106#pullrequestreview-48073734>,
or mute the
thread<https://github.com/notifications/unsubscribe-auth/AbZcfvST1gIEk8aYilBGwKHkEhPC0_ecks5sK6CXgaJpZM4OOTnp>.
This message and the information contained herein is proprietary and
confidential and subject to the Amdocs policy statement,
you may review at https://www.amdocs.com/about/email-disclaimer
<https://www.amdocs.com/about/email-disclaimer>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
