[GitHub] geode pull request #344: Fix the Native Client Build on Ubuntu

GitHub user davinash opened a pull request: https://github.com/apache/geode/pull/344 Fix the Native Client Build on Ubuntu verified on Ubuntu and centos Change is ``` ~/source/open/geode/build (next-gen-native-client-software-grant) $ git diff diff --git

[GitHub] geode issue #344: Fix the Native Client Build on Ubuntu

Github user davinash commented on the issue: https://github.com/apache/geode/pull/344 @pivotal-jbarrett Yes you are correct, previous change will break windows. I have updated PR. Tested on ubuntu and CentOS. --- If your project is set up for it, you can reply to this email and

[GitHub] geode issue #344: Fix the Native Client Build on Ubuntu

Github user davinash commented on the issue: https://github.com/apache/geode/pull/344 Thanks @pivotal-jbarrett , I have handled review comments, tested on Ubuntu and CentOS. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] geode pull request #344: Fix the Native Client Build on Ubuntu

Github user davinash closed the pull request at: https://github.com/apache/geode/pull/344 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] geode issue #344: Fix the Native Client Build on Ubuntu

Github user davinash commented on the issue: https://github.com/apache/geode/pull/344 @pivotal-jbarrett @metatype I have merged the change. https://git-wip-us.apache.org/repos/asf?p=geode.git;h=e92cb63 Closing this PR now. --- If your project is set up for it, you can

[GitHub] geode issue #367: GEODE-2370: First pass at a CONTRIBUTING document.

Github user davinash commented on the issue: https://github.com/apache/geode/pull/367 IMO we also should add command on how to run integration run. I could run integration tests using following command. `cmake --build . --target run-integration-tests` --- If your project is

[GitHub] geode issue #367: GEODE-2370: First pass at a CONTRIBUTING document.

Github user davinash commented on the issue: https://github.com/apache/geode/pull/367 LGTM one question since I am new to CMAKE, how can we run single test ? And should we include instructions for a the same --- If your project is set up for it, you can reply to this email and

[GitHub] geode issue #367: GEODE-2370: First pass at a CONTRIBUTING document.

Github user davinash commented on the issue: https://github.com/apache/geode/pull/367 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

<    1   2