GitHub user davinash opened a pull request:

    https://github.com/apache/geode/pull/344

    Fix the Native Client Build on Ubuntu

    verified on Ubuntu and centos
    
    Change is 
    
    ```
     ~/source/open/geode/build (next-gen-native-client-software-grant) $ git 
diff
    diff --git a/src/cppcache/src/CMakeLists.txt 
b/src/cppcache/src/CMakeLists.txt
    index 04c51a0..35b3799 100644
    --- a/src/cppcache/src/CMakeLists.txt
    +++ b/src/cppcache/src/CMakeLists.txt
    @@ -78,11 +78,7 @@ if(CMAKE_SYSTEM_NAME STREQUAL "SunOS")
         set(SOURCES ${SOURCES} $<TARGET_OBJECTS:gfcppasm>)
       endif()
     endif()
    -if (${UNIX})
    -  target_link_libraries(_gfcppcache INTERFACE
    -      z
    -  )
    -elseif (${WIN32})
    +if (${WIN32})
       target_link_libraries(_gfcppcache INTERFACE
           Dbghelp
       )
    @@ -91,6 +87,7 @@ endif()
     target_link_libraries(_gfcppcache INTERFACE
       ACE
       libxml2
    +  z
     )
     target_compile_definitions(_gfcppcache INTERFACE
         # TODO replace BUILD_CPPCACHE with built-in _DLL
    
    ```
    
    I am not sure why   bc7fa36 is showing in the PR.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/davinash/geode 
next-gen-native-client-software-grant

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/344.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #344
    
----
commit bc7fa368f987c41a69732e1f452949349acb038f
Author: Jacob Barrett <jbarr...@pivotal.io>
Date:   2017-01-17T06:45:45Z

    GEODE-2309: Replace Pivotal Copyright and add Apache License notice.

commit 4b3fdbdc08064e56dd11c63115dc64e857dad698
Author: adongre <adon...@apache.org>
Date:   2017-01-18T10:58:10Z

    GEODE-2319: change the order of libz for linking

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to