Re: Fwd: [DISCUSS] Improvements on client function execution API

2019-08-23 Thread Alberto Gomez
Hi Dan, Please, see my answers below. On 22/8/19 20:29, Dan Smith wrote: > For the two new execute() methods you are proposing, are you also > suggesting that they be implemented on the server? I was only thinking about the client. > > I took a look at the C++ API. The C++ API also has a > Result

Re: [DISCUSS] Improvements on client function execution API

2019-08-23 Thread Alberto Gomez
Hi Jake, Please, see my answers below. On 22/8/19 21:16, Jacob Barrett wrote: > >> On Aug 21, 2019, at 8:49 AM, Alberto Gomez wrote: >> 2. Timeout in ResultCollector::getResult() and Execution::execute() blocking >> >> Regarding the timeout in the ResultCollector::getResult() method problem and

Re: Failed: apache/geode-native#2059 (rel/v1.9.1.RC1 - add53da)

2019-08-23 Thread Blake Bender
This looks spurious - apparently a download issue with Apache Rat jar file. I just ran Rat locally at this Git tag and it passed. Thanks, Blake On Thu, Aug 22, 2019 at 7:33 PM Travis CI wrote: > Build Update for apache/geode-native > - > > Build: #2059 > S

[DISCUSS] Version 1.11 serialization ordinal is wrong

2019-08-23 Thread Bruce Schuchardt
We've been incrementing the serialization version by 5 for each x.x.0 release but I see that we went from 105 in 1.10.0 to 107 in develop for 1.11.0.  That gives us only one opportunity to make a serialization change if we need to release patches for 1.10.  I don't think that's safe & we need t

Re: [DISCUSS] Version 1.11 serialization ordinal is wrong

2019-08-23 Thread Kirk Lund
I think they did that because the datatypes in the Version class are too small. I'm not sure why bytes and shorts were chosen. The version constants are defined as bytes: private static final *byte* GEODE_1_11_0_ORDINAL = 107; While the ordinal is defined as a short: private final *short* ordin

Re: [DISCUSS] Version 1.11 serialization ordinal is wrong

2019-08-23 Thread Bruce Schuchardt
Yeah, that code is confusing.  I think the ordinal constants should all be changed to shorts and the constructor for Version should take a short as well.  I can see why someone creating a new ordinal would be hesitant to do that - it will need to be tested. The on-wire representation of a Vers

Re: Need help: Jetty dunit tests blocking creation of geode-log4j

2019-08-23 Thread Robert Houghton
If the distributedTest jobs are swapping then we have a bigger problem than just this test. We can crank down on the number of parallel jobs and see if that relieves the memory pressure, or we can check for machine types with more memory. I can look at this on Monday, or maybe ping @Sean Goller

Re: [DISCUSS] Add a public API to add endpoints to Geode's HTTP server

2019-08-23 Thread Aaron Lindsey
Would it be practical to remove the dependency on Jetty from the HttpService interface? I admit that I don't know a lot about this area of the code, but I noticed that the current HttpService public interface doesn't have any dependencies on Jetty (except the getHttpService() method, which would be

Re: [DISCUSS] Add a public API to add endpoints to Geode's HTTP server

2019-08-23 Thread Dale Emery
In my proposal as drafted, I assumed Jetty. If we want to support some additional set of server implementations, we will have to define an abstract version of Handler, and perhaps other types, that would be adaptable to all of those implementations. To do that, we would have to have some set of

Re: [DISCUSS] Version 1.11 serialization ordinal is wrong

2019-08-23 Thread Jacob Barrett
I commented in the jira about using int. > On Aug 23, 2019, at 9:54 AM, Bruce Schuchardt wrote: > > Yeah, that code is confusing. I think the ordinal constants should all be > changed to shorts and the constructor for Version should take a short as > well. I can see why someone creating a ne

Passed: apache/geode-examples#342 (release/1.9.1 - fc97f58)

2019-08-23 Thread Travis CI
Build Update for apache/geode-examples - Build: #342 Status: Passed Duration: 20 mins and 50 secs Commit: fc97f58 (release/1.9.1) Author: Owen Nichols Message: temporary commit to allow CI access to the Release Candidate staging maven View the changeset: htt

Failed: apache/geode-examples#344 (tag-test-deleteme - e50c908)

2019-08-23 Thread Travis CI
Build Update for apache/geode-examples - Build: #344 Status: Failed Duration: 2 mins and 14 secs Commit: e50c908 (tag-test-deleteme) Author: Owen Nichols Message: this commit should follow the tag View the changeset: https://github.com/apache/geode-examples/c

Failed: apache/geode-examples#343 (rel/vTEST - 51abdfa)

2019-08-23 Thread Travis CI
Build Update for apache/geode-examples - Build: #343 Status: Failed Duration: 2 mins and 8 secs Commit: 51abdfa (rel/vTEST) Author: Owen Nichols Message: this is the commit that should be tagged View the changeset: https://github.com/apache/geode-examples/comp