In my proposal as drafted, I assumed Jetty. If we want to support some additional set of server implementations, we will have to define an abstract version of Handler, and perhaps other types, that would be adaptable to all of those implementations.
To do that, we would have to have some set of server implementations in mind. I don’t have any insight into that, so I don’t know how to assess the cost or value of making this independent of Jetty. — Dale Emery dem...@pivotal.io > On Aug 23, 2019, at 9:59 AM, Aaron Lindsey <alind...@pivotal.io> wrote: > > Would it be practical to remove the dependency on Jetty from the > HttpService interface? I admit that I don't know a lot about this area of > the code, but I noticed that the current HttpService public interface > doesn't have any dependencies on Jetty (except the getHttpService() method, > which would be changed by this proposal). It seems desirable to decouple > the interface from the underlying web server in case we need to change it > later. > > I like this proposal's intent and think it's an important area of work, > because any Geode user who wants to add a custom HTTP endpoint currently > has to rely on unstable internal APIs. > > - Aaron > > > On Tue, Aug 20, 2019 at 1:34 PM Dale Emery <dem...@pivotal.io> wrote: > >> I’ve drafted a proposal to add a public API to add endpoints to Geode’s >> HTTP server. >> >> >> https://cwiki.apache.org/confluence/display/GEODE/%5BDraft%5D+Public+API+to+Add+Endpoints+to+Geode+HTTP+Server >> < >> https://cwiki.apache.org/confluence/display/GEODE/[Draft]+Public+API+to+Add+Endpoints+to+Geode+HTTP+Server >> <https://cwiki.apache.org/confluence/display/GEODE/%5BDraft%5D+Public+API+to+Add+Endpoints+to+Geode+HTTP+Server> >>> >> >> Currently it is possible to serve additional HTTP content only by creating >> a separate server or by using internal Geode APIs to add endpoints to the >> existing server. >> >> We would like to give users a public way to serve additional HTTP content. >> For example, a user may wish to use a PrometheusMeterRegistry to publish >> Geode’s Micrometer-based metrics via HTTP. Geode’s existing HTTP server >> would be a convenient way to publish that information. >> >> I invite your feedback and ideas. >> >> Dale >> >> — >> Dale Emery >> dem...@pivotal.io >> >>
