[Discuss] replace jsonToObject method with com.fasterxml.jackson.databind. ObjectMapper ->readValue

2017-09-19 Thread Dinesh Akhand
Hi Team, In geode, we are using our own written parsing method in geode. Method : public static T jsonToObject(String jsonString, Class klass) { it have custom parsing logic while (keys.hasNext()) { String key = keys.next(); Method method = methodsMap.get("set" + capitalize(k

Re: Return types form methods on Cache

2017-09-19 Thread David Kimura
I favor values, but we should probably be diligent. Do any of the objects returned from Cache depend on Cache to out-live the returned object? A quick scan suggested no, but we still have a std::enable_shared_from_this. Maybe dead code. In code example, if this happens (for any cache.get*), cou

Re: Return types form methods on Cache

2017-09-19 Thread David Kimura
Err... I missed a return in example above. Region r = [](){ return CacheFactory::create().getRegion("myregion"); } (); On Tue, Sep 19, 2017 at 10:19 AM, David Kimura wrote: > I favor values, but we should probably be diligent. > > Do any of the objects returned from Cache depend on Cache to out

Re: Return types form methods on Cache

2017-09-19 Thread Jacob Barrett
Region returned by this would no longer be valid. It’s “references” to interns cache/region would be invalid. The behavior is undefined. > On Sep 19, 2017, at 10:24 AM, David Kimura wrote: > > Err... I missed a return in example above. > > Region r = [](){ return CacheFactory::create().getRegi

Re: Return types form methods on Cache

2017-09-19 Thread David Kimura
Oh, man. I hope I didn't just kill the original idea. Unless we are somehow using shared_from_this, it shouldn't be a divergence from existing behavior? Thanks, David On Tue, Sep 19, 2017 at 10:47 AM, Jacob Barrett wrote: > Region returned by this would no longer be valid. It’s “references” to

Re: Return types form methods on Cache

2017-09-19 Thread Jacob Barrett
It isn’t. A Region should not outlive cache. > On Sep 19, 2017, at 10:54 AM, David Kimura wrote: > > Oh, man. I hope I didn't just kill the original idea. Unless we are > somehow using shared_from_this, it shouldn't be a divergence from existing > behavior? > > Thanks, > David > >> On Tue, Se

Re: Return types form methods on Cache

2017-09-19 Thread David Kimura
Cool. +1 value model. Thanks, David On Tue, Sep 19, 2017 at 11:15 AM, Jacob Barrett wrote: > It isn’t. A Region should not outlive cache. > > > On Sep 19, 2017, at 10:54 AM, David Kimura wrote: > > > > Oh, man. I hope I didn't just kill the original idea. Unless we are > > somehow using share

Re: [DISCUSS] GEODE-3617 Replace gemfire prefix with geode

2017-09-19 Thread Dave Barnes
There's no single list of "all properties". Here's one that Tech Pubs last reviewed about 6 months ago... https://docs.google.com/spreadsheets/d/1C2D7cpcYMy5bd0aXXReJn6wWsBuLZrCegl7_cevvKo0/edit#gid=0 On Thu, Sep 14, 2017 at 12:06 PM, Bruce Schuchardt wrote: > There are plenty of places beside

Re: [DISCUSS] GEODE-3617 Replace gemfire prefix with geode

2017-09-19 Thread Dave Barnes
Here's an updated link to the properties spreadsheet that should have wider viewability: https://docs.google.com/spreadsheets/d/1C2D7cpcYMy5bd0aXXReJn6wWsBuLZrCegl7_cevvKo0/edit?usp=sharing On Tue, Sep 19, 2017 at 12:10 PM, Dave Barnes wrote: > There's no single list of "all properties". Here's

Re: [DISCUSS] GEODE-3617 Replace gemfire prefix with geode

2017-09-19 Thread Swapnil Bawaskar
In the interest of keeping the re-branding tasks together, I took the liberty to made GEODE-3617 a subtask of https://issues.apache.org/jira/browse/GEODE-1466. On Tue, Sep 19, 2017 at 2:05 PM Dave Barnes wrote: > Here's an updated link to the properties spreadsheet that should have wider > viewa

Passed: apache/geode#3910 (develop - 8211f2f)

2017-09-19 Thread Travis CI
Build Update for apache/geode - Build: #3910 Status: Passed Duration: 13 minutes and 17 seconds Commit: 8211f2f (develop) Author: galen-pivotal Message: GEODE-3609 Small AcceptorImpl refactor (#772) Use one CommunicationMode variable, not 3. Also, refactor th

[Spring CI] Spring Data GemFire > Nightly-ApacheGeode > #683 was SUCCESSFUL (with 2042 tests)

2017-09-19 Thread Spring CI
--- Spring Data GemFire > Nightly-ApacheGeode > #683 was successful. --- Scheduled 2044 tests in total. https://build.spring.io/browse/SGF-NAG-683/ -- This

Build failed in Jenkins: Geode-nightly #959

2017-09-19 Thread Apache Jenkins Server
See Changes: [nreich] GEODE-3180: Fix flaky test [huynhja] GEODE-3578: Only DATA:READ permissions are required for creating/closing [kohlmu-pivotal] GEODE-3623 Clean up [jstewart] GEODE-3426: Ignore RestServersJU

Build failed in Jenkins: Geode-nightly-flaky #126

2017-09-19 Thread Apache Jenkins Server
See Changes: [nreich] GEODE-3180: Fix flaky test [huynhja] GEODE-3578: Only DATA:READ permissions are required for creating/closing [kohlmu-pivotal] GEODE-3623 Clean up [jstewart] GEODE-3426: Ignore RestSer