Re: how to get a good commit comment when using gitbox to merge a pull request

2017-12-15 Thread Jinmei Liao
On the pull request web UI, I usually just use "Squash and Merge" which will give me a chance to revise the commit messages. On Thu, Dec 14, 2017 at 11:15 AM, Darrel Schneider wrote: > I noticed that the git log message for a pull request I just merged was > lacking what I expected it to pick up

how to get a good commit comment when using gitbox to merge a pull request

2017-12-14 Thread Darrel Schneider
I noticed that the git log message for a pull request I just merged was lacking what I expected it to pick up from the single revision in the pull request. It ended up with a message like this: Merge pull request #1165 from dschneider-pivotal/feature/GEODE-4091 GEODE-4091: add ThreadFactory