On the pull request web UI, I usually just use "Squash and Merge" which
will give me a chance to revise the commit messages.
On Thu, Dec 14, 2017 at 11:15 AM, Darrel Schneider <dschnei...@pivotal.io>
wrote:
> I noticed that the git log message for a pull request I just merged was
> lacking what I expected it to pick up from the single revision in the pull
> request. It ended up with a message like this:
>
> Merge pull request #1165 from dschneider-pivotal/feature/GEODE-4091
>
>
>
> GEODE-4091: add ThreadFactory for evictor
>
>
>
> The threads created to do background eviction scanning
>
> will now be named "LRUListWithAsyncSortingThreadNNN".
>
> The will now be daemon threads.
>
> They now have an unhandled exception handler.
>
> Their group is named "LRUListWithAsyncSorting Threads".
>
>
> I wanted it to look like this:
>
> GEODE-4091: add ThreadFactory for evictor
>
>
>
> The threads created to do background eviction scanning
>
> will now be named "LRUListWithAsyncSortingThreadNNN".
>
> The will now be daemon threads.
>
> They now have an unhandled exception handler.
>
> Their group is named "LRUListWithAsyncSorting Threads".
>
> I added the last five lines to it myself because I saw they were missing.
> Did my adding those mess this up?
> Am I correct that we don't want that first line ("Merge pull request
> #...")?
>
> Thanks for any help
>
--
Cheers
Jinmei
