Re: geode-core dependencies for maven pom

2018-12-06 Thread Jacob Barrett
You misunderstood my reply. You were saying it was missing from the Pom and I was saying that it should be in the Pom but marked optional. Whether it should be optional or not in the Pom isn’t really a concern I have. I plan on correcting this nasty stuff with a BOM. See modules PR. > On Dec 6,

Re: geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund
I disagree 100%. It is required for the main use of geode-core which is to create a Cache. Client Cache is something that came later. If you want it a dependency to be optional for Client Caches then please create a geode-client module that generates a pom without this dependency or move the depend

Re: geode-core dependencies for maven pom

2018-12-06 Thread Jacob Barrett
It should be in the POM as optional. > On Dec 6, 2018, at 10:17 AM, Kirk Lund wrote: > > Is the presence of "ext.optional = true" for spring-shell in > geode-core/build.gradle the reason it's missing from the geode-core maven > pom? > > compile('org.springframework.shell:spring-shell:' + > pr

Re: geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund
Is the presence of "ext.optional = true" for spring-shell in geode-core/build.gradle the reason it's missing from the geode-core maven pom? compile('org.springframework.shell:spring-shell:' + project.'spring-shell.version') { exclude module: 'aopalliance' exclude module: 'asm' exclud

Re: geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund
The geode-core maven pom is missing "spring-shell" -- where can I go to add in "spring-shell" as a required dependency? That's the code or gradle or xml that I want to look at. On Thu, Dec 6, 2018 at 9:57 AM Jacob Barrett wrote: > That file is only for testing that the contents are as expected.

Re: geode-core dependencies for maven pom

2018-12-06 Thread Jacob Barrett
That file is only for testing that the contents are as expected. The POM is generated from dependencies and transitive dependencies specified in the various Gradle files. > On Dec 6, 2018, at 9:55 AM, Kirk Lund wrote: > > Is this the only file controlling and testing the dependencies for the >

Re: geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund
Is this the only file controlling and testing the dependencies for the geode-core maven pom that we publish? geode-core/src/test/resources/expected-pom.xml On Thu, Dec 6, 2018 at 9:52 AM Kirk Lund wrote: > Can someone please point me at the right place to review and alter > the dependencies for

geode-core dependencies for maven pom

2018-12-06 Thread Kirk Lund
Can someone please point me at the right place to review and alter the dependencies for geode-core that are being published for its maven pom? Also, are there any tests involving the dependencies of the geode-core maven pom?