It should be in the POM as optional. 
> On Dec 6, 2018, at 10:17 AM, Kirk Lund <kl...@apache.org> wrote:
> 
> Is the presence of "ext.optional = true" for spring-shell in
> geode-core/build.gradle the reason it's missing from the geode-core maven
> pom?
> 
>  compile('org.springframework.shell:spring-shell:' +
> project.'spring-shell.version') {
>    exclude module: 'aopalliance'
>    exclude module: 'asm'
>    exclude module: 'cglib'
>    exclude module: 'guava'
>    exclude module: 'spring-aop'
>    exclude module: 'spring-context-support'
>    exclude module: 'spring-core'
>    *ext.optional = true*
>  }
> 
> 
>> On Thu, Dec 6, 2018 at 10:12 AM Kirk Lund <kl...@apache.org> wrote:
>> 
>> The geode-core maven pom is missing "spring-shell" -- where can I go to
>> add in "spring-shell" as a required dependency? That's the code or gradle
>> or xml that I want to look at.
>> 
>>> On Thu, Dec 6, 2018 at 9:57 AM Jacob Barrett <jbarr...@pivotal.io> wrote:
>>> 
>>> That file is only for testing that the contents are as expected. The POM
>>> is generated from dependencies and transitive dependencies specified in the
>>> various Gradle files.
>>> 
>>>> On Dec 6, 2018, at 9:55 AM, Kirk Lund <kl...@apache.org> wrote:
>>>> 
>>>> Is this the only file controlling and testing the dependencies for the
>>>> geode-core maven pom that we publish?
>>>> 
>>>> geode-core/src/test/resources/expected-pom.xml
>>>> 
>>>>> On Thu, Dec 6, 2018 at 9:52 AM Kirk Lund <kl...@apache.org> wrote:
>>>>> 
>>>>> Can someone please point me at the right place to review and alter
>>>>> the dependencies for geode-core that are being published for its maven
>>> pom?
>>>>> 
>>>>> Also, are there any tests involving the dependencies of the geode-core
>>>>> maven pom?
>>>>> 
>>> 
>> 

Reply via email to