Re: Review Request 60985: GEODE-3217: Reimplement gfsh query as a single-step command

2017-07-20 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60985/#review181069 --- Ship it! Ship It! - Ken Howe On July 20, 2017, 5:54 p.m., Ja

Re: Review Request 60985: GEODE-3217: Reimplement gfsh query as a single-step command

2017-07-20 Thread Jared Stewart
> On July 20, 2017, 2:52 p.m., Ken Howe wrote: > > geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/QueryCommandUnitTest.java > > Lines 24 (patched) > > > > > > Seems there's opportunity for

Re: Review Request 60985: GEODE-3217: Reimplement gfsh query as a single-step command

2017-07-20 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60985/ --- (Updated July 20, 2017, 5:54 p.m.) Review request for geode, Emily Yeh, Jared S

Re: Review Request 60985: GEODE-3217: Reimplement gfsh query as a single-step command

2017-07-20 Thread Ken Howe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60985/#review181043 --- geode-core/src/main/java/org/apache/geode/management/internal/cli

Re: Review Request 60985: GEODE-3217: Reimplement gfsh query as a single-step command

2017-07-19 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60985/#review180980 --- Ship it! Ship It! - Jinmei Liao On July 19, 2017, 9:06 p.m.,

Review Request 60985: GEODE-3217: Reimplement gfsh query as a single-step command

2017-07-19 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60985/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat