Re: Review Request 60451: GEODE-2996: adding Put handler

2017-07-07 Thread Brian Rowe
> On June 28, 2017, 4:24 a.m., Udo Kohlmeyer wrote: > > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java > > Lines 68 (patched) > > > > > > This has nothing to do with the Prot

Re: Review Request 60451: GEODE-2996: adding Put handler

2017-06-29 Thread Alexander Murmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60451/#review179269 --- geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUti

Re: Review Request 60451: GEODE-2996: adding Put handler

2017-06-28 Thread Udo Kohlmeyer
> On June 28, 2017, 4:24 a.m., Udo Kohlmeyer wrote: > > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java > > Lines 68 (patched) > > > > > > This has nothing to do with the Prot

Re: Review Request 60451: GEODE-2996: adding Put handler

2017-06-28 Thread Brian Rowe
> On June 28, 2017, 4:24 a.m., Udo Kohlmeyer wrote: > > geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java > > Lines 68 (patched) > > > > > > This has nothing to do with the Prot

Re: Review Request 60451: GEODE-2996: adding Put handler

2017-06-28 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60451/#review179145 --- Remove the use of getLogger(). The rest looks okay to me. geode

Re: Review Request 60451: GEODE-2996: adding Put handler

2017-06-27 Thread Udo Kohlmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60451/#review179071 --- geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/P

Re: Review Request 60451: GEODE-2996: adding Put handler

2017-06-27 Thread Hitesh Khamesra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60451/#review179015 --- Ship it! Ship It! - Hitesh Khamesra On June 27, 2017, 1:20 a

Re: Review Request 60451: GEODE-2996: adding Put handler

2017-06-27 Thread Alexander Murmann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60451/#review178988 --- Ship it! Ship It! - Alexander Murmann On June 27, 2017, 1:20

Review Request 60451: GEODE-2996: adding Put handler

2017-06-26 Thread Brian Rowe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60451/ --- Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen O'Sullivan,