-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60451/
-----------------------------------------------------------
Review request for geode, Alexander Murmann, Bruce Schuchardt, Galen
O'Sullivan, Hitesh Khamesra, and Udo Kohlmeyer.
Bugs: GEODE-2996
https://issues.apache.org/jira/browse/GEODE-2996
Repository: geode
Description
-------
This is a continuation of the review Alex submitted this morning with the
following changes:
Addresses review feedback for GEODE-2996, mainly refactoring getOpertionHandler
to handle failures like the putOperationHandler
Adding put operations to the RoundTripCacheConnectionJUnitTest, which is the
integration test for the protobuf module
Removing service loading for protobuf operations and instead have the
ProtobufStreamProcessor populate its OperationHandlerRegistry
Remove exception throwing from OperationHandler.process calls and remove
TypeEncodingException
Fixing ProtobufOpsProcessor to handle responses for types other than get
Diffs
-----
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/OperationHandler.java
7683e3bf3
geode-protobuf/src/main/java/org/apache/geode/protocol/operations/registry/OperationsHandlerRegistry.java
8e3a33149
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessor.java
d426149e4
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufStreamProcessor.java
d7b5d4bd2
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/ProtobufUtilities.java
d76366298
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandler.java
d9c14752f
geode-protobuf/src/main/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandler.java
PRE-CREATION
geode-protobuf/src/main/java/org/apache/geode/serialization/exception/TypeEncodingException.java
f3145a774
geode-protobuf/src/main/java/org/apache/geode/serialization/exception/UnsupportedEncodingTypeException.java
c577e768a
geode-protobuf/src/main/java/org/apache/geode/serialization/registry/exception/CodecNotRegisteredForTypeException.java
5c923a520
geode-protobuf/src/main/proto/region_API.proto 52291c451
geode-protobuf/src/test/java/org/apache/geode/protocol/MessageUtil.java
f0b0b417b
geode-protobuf/src/test/java/org/apache/geode/protocol/RoundTripCacheConnectionJUnitTest.java
b9faca3c9
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/ProtobufOpsProcessorJUnitTest.java
fc980aec9
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/GetRequestOperationHandlerJUnitTest.java
daa5870ed
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/60451/diff/1/
Testing
-------
Unit tests, whole module test, precheckin in progress.
Thanks,
Brian Rowe
