Re: Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable

2017-06-08 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59754/#review177382 --- Fix it, then Ship it! Fix it and ship it! geode-core/src/test

Re: Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable

2017-06-08 Thread Emily Yeh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59754/#review177355 --- geode-core/src/main/java/org/apache/geode/management/cli/CliMetaD

Re: Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable

2017-06-08 Thread Patrick Rhomberg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59754/#review177336 --- geode-core/src/main/java/org/apache/geode/management/internal/cli

Re: Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable

2017-06-05 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59754/ --- (Updated June 5, 2017, 8:03 p.m.) Review request for geode, Emily Yeh, Jared St

Re: Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable

2017-06-02 Thread Jinmei Liao
> On June 2, 2017, 5:53 p.m., Jared Stewart wrote: > > geode-core/src/test/java/org/apache/TestSuite.java > > Lines 24 (patched) > > > > > > I suspect that you may not have intended to include this file in your > > c

Re: Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable

2017-06-02 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59754/#review176809 --- geode-core/src/test/java/org/apache/TestSuite.java Lines 24 (patc

Review Request 59754: GEODE-2928: get rid of the isGfshVM static variable

2017-06-02 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59754/ --- Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Pat