----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59754/ -----------------------------------------------------------
Review request for geode, Emily Yeh, Jared Stewart, Ken Howe, Kirk Lund, and Patrick Rhomberg. Repository: geode Description ------- * consolidate the availability indicators * remove the isGfshVM and isGfshVM() method * enhance the MultiStepCommand to include info on shellOnly commands to enhance command validation * remove the SUPPORT_MULTIPLE_GFSH static flag and properly remove the gfsh instance at the end of each test Diffs ----- geode-core/src/main/java/org/apache/geode/internal/GfeConsoleReaderFactory.java 120d6257b geode-core/src/main/java/org/apache/geode/management/cli/CliMetaData.java 2e6dc3973 geode-core/src/main/java/org/apache/geode/management/internal/cli/CliUtil.java 038e0691e geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ClientCommands.java e61934261 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CommandAvailabilityIndicator.java PRE-CREATION geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ConfigCommands.java bc9c05b81 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/CreateAlterDestroyRegionCommands.java ad40518f8 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DataCommands.java cb9c4fe50 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DeployCommands.java 30d840a0f geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommands.java 64fafda84 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/DurableClientCommands.java 6441f20cc geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ExportImportClusterConfigurationCommands.java 9d263d110 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/FunctionCommands.java 2774584ff geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/GfshCommand.java d46024d38 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/IndexCommands.java b3d96757b geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/LauncherLifecycleCommands.java 4c668b681 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MemberCommands.java 695718a82 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/MiscellaneousCommands.java 9754d7d52 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/PDXCommands.java 9f1290d16 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/QueueCommands.java d3c263509 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/RegionCommands.java 2009dcc05 geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/ShellCommands.java efd10d27b geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/StatusCommands.java fffb9646f geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/WanCommands.java 28686ce4d geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/DataCommandFunction.java e2164a375 geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/CLIMultiStepHelper.java d53261d04 geode-core/src/main/java/org/apache/geode/management/internal/cli/multistep/MultiStepCommand.java 6708726cd geode-core/src/main/java/org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java fa0f3b259 geode-core/src/main/java/org/apache/geode/management/internal/cli/result/AbstractResultData.java f453ec67c geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/Gfsh.java c5ff6b6a5 geode-core/src/main/java/org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java 2b39bedd1 geode-core/src/test/java/org/apache/TestSuite.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/DataCommandMBeanTest.java PRE-CREATION geode-core/src/test/java/org/apache/geode/management/internal/cli/HeadlessGfsh.java 9ea22dac0 geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/CliCommandTestBase.java b582e529c geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/MemberCommandsDUnitTest.java 5bbfc5b3d geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowDeadlockDUnitTest.java e7ae38e43 geode-core/src/test/java/org/apache/geode/test/dunit/rules/GfshShellConnectionRule.java bc709db56 geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/cli/LuceneIndexCommands.java da0dfa23c Diff: https://reviews.apache.org/r/59754/diff/1/ Testing ------- precheckin running Thanks, Jinmei Liao
