Re: Review Request 56396: Refactor test rules

2017-02-07 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56396/#review164597 --- Ship it! - Kirk Lund On Feb. 7, 2017, 5:28 p.m., Jinmei Liao

Re: Review Request 56396: Refactor test rules

2017-02-07 Thread Jared Stewart
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56396/#review164537 --- Ship it! I think before() and after() in GfshShellConnectionRul

Re: Review Request 56396: Refactor test rules

2017-02-07 Thread Kevin Duling
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56396/#review164535 --- Ship it! My only comment is that I like to see @Before and @Aft

Review Request 56396: Refactor test rules

2017-02-07 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56396/ --- Review request for geode, Jared Stewart, Kevin Duling, Ken Howe, and Kirk Lund.