Re: Review Request 54943: GEODE-2197: refactor cluster config

2016-12-23 Thread Kirk Lund
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54943/#review160103 --- Ship it! Ship It! - Kirk Lund On Dec. 22, 2016, 6:48 a.m., J

Re: Review Request 54943: GEODE-2197: refactor cluster config

2016-12-23 Thread Kirk Lund
> On Dec. 21, 2016, 8:52 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/org/apache/geode/distributed/internal/SharedConfiguration.java, > > line 743 > > > > > > I can't tell from the diff if this method

Re: Review Request 54943: GEODE-2197: refactor cluster config

2016-12-21 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54943/ --- (Updated Dec. 22, 2016, 6:48 a.m.) Review request for geode, Bruce Schuchardt,

Re: Review Request 54943: GEODE-2197: refactor cluster config

2016-12-21 Thread Jinmei Liao
> On Dec. 21, 2016, 8:52 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/org/apache/geode/distributed/internal/SharedConfiguration.java, > > line 743 > > > > > > I can't tell from the diff if this method

Re: Review Request 54943: GEODE-2197: refactor cluster config

2016-12-21 Thread Bruce Schuchardt
If it's used at startup you could have this happen: Locator A running 1.0.0 Locator B running 1.0.0 Server R running 1.0.0 Server S running 1.0.0 In a rolling upgrade Locators are rolled to the new version first, one by one. Locator B running 1.0.0 Server R running 1.0.0

Re: Review Request 54943: GEODE-2197: refactor cluster config

2016-12-21 Thread Jinmei Liao
> On Dec. 21, 2016, 8:52 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/org/apache/geode/distributed/internal/SharedConfiguration.java, > > line 743 > > > > > > I can't tell from the diff if this method

Re: Review Request 54943: GEODE-2197: refactor cluster config

2016-12-21 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54943/#review159856 --- I don't know much about shared-configuration code but I looked thr

Re: Review Request 54943: GEODE-2197: refactor cluster config

2016-12-21 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54943/ --- (Updated Dec. 21, 2016, 6:16 p.m.) Review request for geode, Bruce Schuchardt,

Review Request 54943: GEODE-2197: refactor cluster config

2016-12-21 Thread Jinmei Liao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54943/ --- Review request for geode, Bruce Schuchardt, Jared Stewart, John Blum, Kevin Duli