> On Dec. 21, 2016, 8:52 p.m., Bruce Schuchardt wrote: > > geode-core/src/main/java/org/apache/geode/distributed/internal/SharedConfiguration.java, > > line 743 > > <https://reviews.apache.org/r/54943/diff/1/?file=1590422#file1590422line743> > > > > I can't tell from the diff if this method is rolling-upgrade safe. If > > it's just used during jar deployment then there's no problem. If it's used > > during locator start-up then it will not work during rolling upgrade and > > backward-compatibility needs to be addressed. > > > > If it's just used during jar deployment then you can ignore this > > comment. > > Jinmei Liao wrote: > This is used in locator start-up. So in rolling-upgrade scenario, we > would have a locator in 9.1 trying to start up and contacting locator in 9.0 > which doesn't have this function? > > Jinmei Liao wrote: > In this case, we should be fine. Locator A before shutting down, should > have all the deployed jars in its cluster_config directory, when it starts up > with newer version, it shouldn't be trying to contact other locators to get > the jars because all the deployed jars it knows of is already in it's working > dir (it only goes to download jars from other locator when the jar is not in > it's own file system). > > This code is run when a new locator gets started up. we won't run into > problems as long as we finish rolling upgrade all the existing locators > before starting up new locator.
It would be safest to write a rolling-upgrade test that involves cluster config and jar deployment (even if we write that test as a follow-up to this change). - Kirk ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54943/#review159856 ----------------------------------------------------------- On Dec. 22, 2016, 6:48 a.m., Jinmei Liao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54943/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2016, 6:48 a.m.) > > > Review request for geode, Bruce Schuchardt, Jared Stewart, John Blum, Kevin > Duling, and Kirk Lund. > > > Repository: geode > > > Description > ------- > > * not to save the xml, properties in the file system, only in the internal > region. > * the cc region's change listener is to download the jar from other locators > > > GEODE-2197: refactor cluster config and fix the test failures > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/distributed/internal/SharedConfiguration.java > 3119823d6b8886cf893fd38ed58ca90b0c28eeb5 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ExportSharedConfigurationFunction.java > 821e04b2c590bddd28b0727e504c6460d77cf709 > > geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ImportSharedConfigurationArtifactsFunction.java > 2ddeda69177b2aea41ee1d1318d8fdb19324a20b > > geode-core/src/main/java/org/apache/geode/management/internal/configuration/SharedConfigurationWriter.java > 3af55874282d380e340874a24860fafad7ace126 > > geode-core/src/main/java/org/apache/geode/management/internal/configuration/callbacks/ConfigurationChangeListener.java > c08ba924b652c05436f921c19d65392fd7f6859b > > geode-core/src/main/java/org/apache/geode/management/internal/configuration/domain/Configuration.java > 4adf2110c4a270127adda1a5090d537a5e2de8c1 > > geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/ModifyPropertiesFunction.java > 075993716c1afe47ca116727994a3a3661d35a61 > > geode-core/src/main/java/org/apache/geode/management/internal/configuration/utils/XmlUtils.java > 0b4e0f617cf4b5b91f49dc185d7c02b6b7fe0472 > > geode-core/src/test/java/org/apache/geode/distributed/internal/SharedConfigurationJUnitTest.java > 4787c6665cb62eb3dbfe18f3e0128f572d5a36b4 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigBaseTest.java > 63c88dd1aa521a6781a8e07567df661cd42fb6f7 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigDeployJarDUnitTest.java > da4fcf9be6637ddd79403f0a01cb2ba1823f7bd4 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigImportDUnitTest.java > c135f3d9b3370b4a756a2c7688530c63a4e06d77 > > geode-core/src/test/java/org/apache/geode/management/internal/configuration/ClusterConfigStartMemberDUnitTest.java > cfcbeed86ade004eb305d9a01d6fb128132a21ac > > geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt > d6b770f6c9b18e8c090045a66864a027f0ad8062 > > Diff: https://reviews.apache.org/r/54943/diff/ > > > Testing > ------- > > precheckin successful > > > Thanks, > > Jinmei Liao > >
