Re: build is broken on develop

I fixed the build. My apologies I didn't rebase before merging my PR. On Tue, Feb 26, 2019 at 12:33 PM Sai Boorlagadda wrote: > My commit broke the build on develop. I am on it. > >

Re: build is broken

There was a PR for these changes: https://github.com/apache/geode/pull/1212 I didn’t comment on the PR but I did review the dependency for license compatibility (it’s ASL 2.0). Anthony > On Jan 23, 2018, at 2:29 PM, Mark Bretl wrote: > > I agree

Re: build is broken

I agree with Kirk. A simple notice to the dev list to say what dependency and why it is being added, this would also be an opportunity to make sure the dependency is not using a Cat-X license [1]. --Mark [1] https://www.apache.org/legal/resolved.html#category-x On Tue, Jan 23, 2018 at 2:09 PM, K

Re: build is broken

Discussing the addition of new dependencies is something the community should be doing on the dev-list regardless of how many git repos we have. It's part of the Apache Way that we are beholden to as an Apache project. On Tue, Jan 23, 2018 at 11:25 AM, Udo Kohlmeyer wrote: > This really just ano

Re: build is broken

This really just another reason that we should be pushing for the separation of Geode into different (independent) modules with potentially separate repos. This way modules can advance and iterate faster without having to be influenced by external factors causing unrelated failures. I would push f

Re: build is broken

I have it working now. My IntelliJ project was using JDK1.8.0_66 for Gradle which prevented updating of dependencies which then caused compilation in IntelliJ to fail on that new dependency. This doesn't resolve my main issue here which is this: *all new dependencies should be discussed on the dev

Re: build is broken

I just ran `gradle clean build` from HEAD and did not get any errors. > On Jan 23, 2018, at 10:08 AM, Jens Deppe wrote: > > The dependency is the rmi-io library. It provides functionality for > streaming data over RMI. > > It was added a few weeks ago, so I'm not sure why your build is breaking

Re: build is broken

The dependency is the rmi-io library. It provides functionality for streaming data over RMI. It was added a few weeks ago, so I'm not sure why your build is breaking now. --Jens On Tue, Jan 23, 2018 at 9:41 AM, Kirk Lund wrote: > Looks like this dependency is Jackcess (used for reading and wri

Re: build is broken

Looks like this dependency is Jackcess (used for reading and writing MS Access databases). I cannot find any discussion about adding this dependency on the dev-list. Why does Geode need to talk to MS Access databases for Cluster Configuration? It does have an Apache 2.0 license, but I think there